| Message ID | 20201012111529.GA17606@udhay-Latitude-E6330 |
|---|---|
| State | Accepted |
| Headers | show |
| Series | mesh: Stop SAE auth timer when mesh node is removed | expand |
On Mon, Oct 12, 2020 at 04:45:29PM +0530, Udhayakumar Mahendiran wrote:
> Not doing this causes wpa_supplicant to crash.
Thanks, applied. It was not immediately obvious how this would result
into a crash since mesh_auth_time gets canceled in mesh_mpm_free_sta(),
but anyway, doing this in mesh_mpm_plink_close() seems reasonable.
diff --git a/wpa_supplicant/mesh_mpm.c b/wpa_supplicant/mesh_mpm.c index ddcc33d..9a7a5d8 100644 --- a/wpa_supplicant/mesh_mpm.c +++ b/wpa_supplicant/mesh_mpm.c @@ -540,6 +540,7 @@ static int mesh_mpm_plink_close(struct hostapd_data *hapd, struct sta_info *sta, wpa_printf(MSG_DEBUG, "MPM closing plink sta=" MACSTR, MAC2STR(sta->addr)); eloop_cancel_timeout(plink_timer, wpa_s, sta); + eloop_cancel_timeout(mesh_auth_timer, wpa_s, sta); return 0; }
Not doing this causes wpa_supplicant to crash. Signed-off-by: Udhayakumar Mahendiran <udhayakumar@qubercomm.com> --- wpa_supplicant/mesh_mpm.c | 1 + 1 file changed, 1 insertion(+)