| Message ID | 20200811063304.581395-1-leon@kernel.org |
|---|---|
| State | Superseded |
| Delegated to: | stephen hemminger |
| Headers | show |
| Series | [iproute2-rc] rdma: Fix owner name for the kernel resources | expand |
On Tue, Aug 11, 2020 at 09:33:04AM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky <leonro@nvidia.com> > > Owner of kernel resources is printed in different format than user > resources to easy with the reader by simply looking on the name. > The kernel owner will have "[ ]" around the name. > > Before this change: > [leonro@vm ~]$ rdma res show qp > link rocep0s9/1 lqpn 1 type GSI state RTS sq-psn 58 comm ib_core > > After this change: > [leonro@vm ~]$ rdma res show qp > link rocep0s9/1 lqpn 1 type GSI state RTS sq-psn 58 comm [ib_core] > > Fixes: b0a688a542cd ("rdma: Rewrite custom JSON and prints logic to use common API") > Signed-off-by: Leon Romanovsky <leonro@nvidia.com> > --- > rdma/res.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Please drop this patch, I'll send another version with extra fix. Thanks
On Tue, 11 Aug 2020 09:33:04 +0300
Leon Romanovsky <leon@kernel.org> wrote:
> + print_color_string(PRINT_ANY, COLOR_NONE, "comm", "comm %s ", tmp);
If you don't want color then just print_string will do the same thing.
print_string(PRINT_ANY, "comm", "comm %s ", tmp);
On Tue, Aug 11, 2020 at 08:54:17AM -0700, Stephen Hemminger wrote: > On Tue, 11 Aug 2020 09:33:04 +0300 > Leon Romanovsky <leon@kernel.org> wrote: > > > + print_color_string(PRINT_ANY, COLOR_NONE, "comm", "comm %s ", tmp); > > If you don't want color then just print_string will do the same thing. > > print_string(PRINT_ANY, "comm", "comm %s ", tmp); We put print_color_string() in all places as a preparation to for the future and didn't color it on purpose at this point of time. I prefer to keep it in this way and color it later. Thanks > > >
diff --git a/rdma/res.c b/rdma/res.c index c99a1fcb..6eca87e5 100644 --- a/rdma/res.c +++ b/rdma/res.c @@ -161,7 +161,7 @@ void print_comm(struct rd *rd, const char *str, struct nlattr **nla_line) snprintf(tmp, sizeof(tmp), "%s", str); else snprintf(tmp, sizeof(tmp), "[%s]", str); - print_color_string(PRINT_ANY, COLOR_NONE, "comm", "comm %s ", str); + print_color_string(PRINT_ANY, COLOR_NONE, "comm", "comm %s ", tmp); } void print_dev(struct rd *rd, uint32_t idx, const char *name)