| Message ID | 20200626071357.21421-3-miquel.raynal@bootlin.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | NAND ECC engine binding changes | expand |
On Fri, Jun 26, 2020 at 09:13:57AM +0200, Miquel Raynal wrote: > Document nand-use-soft-ecc-engine and nand-no-ecc-engine properties. > The former is here to force software correction, the latter prevents > any correction to happen. > > These properties (along with nand-ecc-engine) are supposed to be more > accurate than the current nand-ecc-modes wich is very misleading and > very often people think it is mandatory while the core should be > relied upon to decide which correction to handle. > > nand-ecc-mode was already inacurate, but it becomes totally > problematic with setups where there are several hardware engines. > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > --- > Documentation/devicetree/bindings/mtd/nand-controller.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mtd/nand-controller.yaml b/Documentation/devicetree/bindings/mtd/nand-controller.yaml > index 0969d2e6720b..a3750978ebb8 100644 > --- a/Documentation/devicetree/bindings/mtd/nand-controller.yaml > +++ b/Documentation/devicetree/bindings/mtd/nand-controller.yaml > @@ -68,6 +68,12 @@ patternProperties: > 3/ The ECC engine is external, in this case the phandle should > reference the specific ECC engine node. > > + nand-use-soft-ecc-engine: true > + description: Use a software ECC engine. > + > + nand-no-ecc-engine: true > + description: Do not use any ECC correction. > + Still the same problem as v10. You want: nand-no-ecc-engine: type: boolean description: Do not use any ECC correction. > nand-ecc-placement: > allOf: > - $ref: /schemas/types.yaml#/definitions/string > -- > 2.20.1 >
Hi Rob, Rob Herring <robh@kernel.org> wrote on Mon, 29 Jun 2020 17:08:00 -0600: > On Fri, Jun 26, 2020 at 09:13:57AM +0200, Miquel Raynal wrote: > > Document nand-use-soft-ecc-engine and nand-no-ecc-engine properties. > > The former is here to force software correction, the latter prevents > > any correction to happen. > > > > These properties (along with nand-ecc-engine) are supposed to be more > > accurate than the current nand-ecc-modes wich is very misleading and > > very often people think it is mandatory while the core should be > > relied upon to decide which correction to handle. > > > > nand-ecc-mode was already inacurate, but it becomes totally > > problematic with setups where there are several hardware engines. > > > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > > --- > > Documentation/devicetree/bindings/mtd/nand-controller.yaml | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mtd/nand-controller.yaml b/Documentation/devicetree/bindings/mtd/nand-controller.yaml > > index 0969d2e6720b..a3750978ebb8 100644 > > --- a/Documentation/devicetree/bindings/mtd/nand-controller.yaml > > +++ b/Documentation/devicetree/bindings/mtd/nand-controller.yaml > > @@ -68,6 +68,12 @@ patternProperties: > > 3/ The ECC engine is external, in this case the phandle should > > reference the specific ECC engine node. > > > > + nand-use-soft-ecc-engine: true > > + description: Use a software ECC engine. > > + > > + nand-no-ecc-engine: true > > + description: Do not use any ECC correction. > > + > > Still the same problem as v10. I am very sorry for the error, I fixed both commits with a fixup! commit at the end of my series and forgot to squash them before sending... I'll resend the proper patches. Again, sorry for the time lost. Thanks, Miquèl
diff --git a/Documentation/devicetree/bindings/mtd/nand-controller.yaml b/Documentation/devicetree/bindings/mtd/nand-controller.yaml index 0969d2e6720b..a3750978ebb8 100644 --- a/Documentation/devicetree/bindings/mtd/nand-controller.yaml +++ b/Documentation/devicetree/bindings/mtd/nand-controller.yaml @@ -68,6 +68,12 @@ patternProperties: 3/ The ECC engine is external, in this case the phandle should reference the specific ECC engine node. + nand-use-soft-ecc-engine: true + description: Use a software ECC engine. + + nand-no-ecc-engine: true + description: Do not use any ECC correction. + nand-ecc-placement: allOf: - $ref: /schemas/types.yaml#/definitions/string
Document nand-use-soft-ecc-engine and nand-no-ecc-engine properties. The former is here to force software correction, the latter prevents any correction to happen. These properties (along with nand-ecc-engine) are supposed to be more accurate than the current nand-ecc-modes wich is very misleading and very often people think it is mandatory while the core should be relied upon to decide which correction to handle. nand-ecc-mode was already inacurate, but it becomes totally problematic with setups where there are several hardware engines. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- Documentation/devicetree/bindings/mtd/nand-controller.yaml | 6 ++++++ 1 file changed, 6 insertions(+)