| Message ID | 20200521093805.64398-6-chenzhou10@huawei.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | support reserving crashkernel above 4G on arm64 kdump | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/checkpatch | success |
On Thu, May 21, 2020 at 3:35 AM Chen Zhou <chenzhou10@huawei.com> wrote: > > Add documentation for DT property used by arm64 kdump: > linux,low-memory-range. > "linux,low-memory-range" is an another memory region used for crash > dump kernel devices. > > Signed-off-by: Chen Zhou <chenzhou10@huawei.com> > --- > Documentation/devicetree/bindings/chosen.txt | 25 ++++++++++++++++++++ > 1 file changed, 25 insertions(+) chosen is now a schema documented here[1]. > diff --git a/Documentation/devicetree/bindings/chosen.txt b/Documentation/devicetree/bindings/chosen.txt > index 45e79172a646..bfe6fb6976e6 100644 > --- a/Documentation/devicetree/bindings/chosen.txt > +++ b/Documentation/devicetree/bindings/chosen.txt > @@ -103,6 +103,31 @@ While this property does not represent a real hardware, the address > and the size are expressed in #address-cells and #size-cells, > respectively, of the root node. > > +linux,low-memory-range > +---------------------- > +This property (arm64 only) holds a base address and size, describing a > +limited region below 4G. Similar to "linux,usable-memory-range", it is > +an another memory range which may be considered available for use by the > +kernel. Why can't you just add a range to "linux,usable-memory-range"? It shouldn't be hard to figure out which part is below 4G. Rob [1] https://github.com/devicetree-org/dt-schema/blob/master/schemas/chosen.yaml
Hi Rob, On 2020/5/21 21:29, Rob Herring wrote: > On Thu, May 21, 2020 at 3:35 AM Chen Zhou <chenzhou10@huawei.com> wrote: >> Add documentation for DT property used by arm64 kdump: >> linux,low-memory-range. >> "linux,low-memory-range" is an another memory region used for crash >> dump kernel devices. >> >> Signed-off-by: Chen Zhou <chenzhou10@huawei.com> >> --- >> Documentation/devicetree/bindings/chosen.txt | 25 ++++++++++++++++++++ >> 1 file changed, 25 insertions(+) > chosen is now a schema documented here[1]. Ok, that is, i don't need to modify the doc in kernel, just create a pull request in github [1]? > >> diff --git a/Documentation/devicetree/bindings/chosen.txt b/Documentation/devicetree/bindings/chosen.txt >> index 45e79172a646..bfe6fb6976e6 100644 >> --- a/Documentation/devicetree/bindings/chosen.txt >> +++ b/Documentation/devicetree/bindings/chosen.txt >> @@ -103,6 +103,31 @@ While this property does not represent a real hardware, the address >> and the size are expressed in #address-cells and #size-cells, >> respectively, of the root node. >> >> +linux,low-memory-range >> +---------------------- >> +This property (arm64 only) holds a base address and size, describing a >> +limited region below 4G. Similar to "linux,usable-memory-range", it is >> +an another memory range which may be considered available for use by the >> +kernel. > Why can't you just add a range to "linux,usable-memory-range"? It > shouldn't be hard to figure out which part is below 4G. I did like this in my previous version, such as v5. After discussed with James, i modified it to the current way. We think the existing behavior should be unchanged, which helps with keeping compatibility with existing user-space and older kdump kernels. The comments from James: > linux,usable-memory-range = <BASE1 SIZE1 [BASE2 SIZE2]>. Won't this break if your kdump kernel doesn't know what the extra parameters are? Or if it expects two ranges, but only gets one? These DT properties should be treated as ABI between kernel versions, we can't really change it like this. I think the 'low' region is an optional-extra, that is never mapped by the first kernel. I think the simplest thing to do is to add an 'linux,low-memory-range' that we memblock_add() after memblock_cap_memory_range() has been called. If its missing, or the new kernel doesn't know what its for, everything keeps working. previous discusses: https://lkml.org/lkml/2019/6/5/674 https://lkml.org/lkml/2019/6/13/229 Thanks, Chen Zhou > > Rob > > [1] https://github.com/devicetree-org/dt-schema/blob/master/schemas/chosen.yaml > > . >
On Fri, May 22, 2020 at 11:24:11AM +0800, chenzhou wrote: > Hi Rob, +James M (It's nice to Cc folks if you mention/quote them) > On 2020/5/21 21:29, Rob Herring wrote: > > On Thu, May 21, 2020 at 3:35 AM Chen Zhou <chenzhou10@huawei.com> wrote: > >> Add documentation for DT property used by arm64 kdump: > >> linux,low-memory-range. > >> "linux,low-memory-range" is an another memory region used for crash > >> dump kernel devices. > >> > >> Signed-off-by: Chen Zhou <chenzhou10@huawei.com> > >> --- > >> Documentation/devicetree/bindings/chosen.txt | 25 ++++++++++++++++++++ > >> 1 file changed, 25 insertions(+) > > chosen is now a schema documented here[1]. > Ok, that is, i don't need to modify the doc in kernel, just create a pull request in github [1]? > > > > >> diff --git a/Documentation/devicetree/bindings/chosen.txt b/Documentation/devicetree/bindings/chosen.txt > >> index 45e79172a646..bfe6fb6976e6 100644 > >> --- a/Documentation/devicetree/bindings/chosen.txt > >> +++ b/Documentation/devicetree/bindings/chosen.txt > >> @@ -103,6 +103,31 @@ While this property does not represent a real hardware, the address > >> and the size are expressed in #address-cells and #size-cells, > >> respectively, of the root node. > >> > >> +linux,low-memory-range > >> +---------------------- > >> +This property (arm64 only) holds a base address and size, describing a > >> +limited region below 4G. Similar to "linux,usable-memory-range", it is > >> +an another memory range which may be considered available for use by the > >> +kernel. > > Why can't you just add a range to "linux,usable-memory-range"? It > > shouldn't be hard to figure out which part is below 4G. > I did like this in my previous version, such as v5. After discussed with James, i modified it to the current way. > > We think the existing behavior should be unchanged, which helps with keeping compatibility with existing > user-space and older kdump kernels. > > The comments from James: > > linux,usable-memory-range = <BASE1 SIZE1 [BASE2 SIZE2]>. > Won't this break if your kdump kernel doesn't know what the extra parameters are? > Or if it expects two ranges, but only gets one? These DT properties should be treated as > ABI between kernel versions, we can't really change it like this. > > I think the 'low' region is an optional-extra, that is never mapped by the first kernel. I > think the simplest thing to do is to add an 'linux,low-memory-range' that we > memblock_add() after memblock_cap_memory_range() has been called. > If its missing, or the new kernel doesn't know what its for, everything keeps working. I don't think there's a compatibility issue here though. The current kernel doesn't care if the property is longer than 1 base+size. It only checks if the size is less than 1 base+size. And yes, we can rely on that implementation detail. It's only an ABI if an existing user notices. Now, if the low memory is listed first, then an older kdump kernel would get a different memory range. If that's a problem, then define that low memory goes last. Rob
Hi guys, On 26/05/2020 22:18, Rob Herring wrote: > On Fri, May 22, 2020 at 11:24:11AM +0800, chenzhou wrote: >> On 2020/5/21 21:29, Rob Herring wrote: >>> On Thu, May 21, 2020 at 3:35 AM Chen Zhou <chenzhou10@huawei.com> wrote: >>>> Add documentation for DT property used by arm64 kdump: >>>> linux,low-memory-range. >>>> "linux,low-memory-range" is an another memory region used for crash >>>> dump kernel devices. >>>> diff --git a/Documentation/devicetree/bindings/chosen.txt b/Documentation/devicetree/bindings/chosen.txt >>>> index 45e79172a646..bfe6fb6976e6 100644 >>>> --- a/Documentation/devicetree/bindings/chosen.txt >>>> +++ b/Documentation/devicetree/bindings/chosen.txt >>>> +linux,low-memory-range >>>> +---------------------- >>>> +This property (arm64 only) holds a base address and size, describing a >>>> +limited region below 4G. Similar to "linux,usable-memory-range", it is >>>> +an another memory range which may be considered available for use by the >>>> +kernel. >>> Why can't you just add a range to "linux,usable-memory-range"? It >>> shouldn't be hard to figure out which part is below 4G. >> The comments from James: >> Won't this break if your kdump kernel doesn't know what the extra parameters are? >> Or if it expects two ranges, but only gets one? These DT properties should be treated as >> ABI between kernel versions, we can't really change it like this. >> >> I think the 'low' region is an optional-extra, that is never mapped by the first kernel. I >> think the simplest thing to do is to add an 'linux,low-memory-range' that we >> memblock_add() after memblock_cap_memory_range() has been called. >> If its missing, or the new kernel doesn't know what its for, everything keeps working. > > > I don't think there's a compatibility issue here though. The current > kernel doesn't care if the property is longer than 1 base+size. It only > checks if the size is less than 1 base+size. Aha! I missed that. > And yes, we can rely on > that implementation detail. It's only an ABI if an existing user > notices. > > Now, if the low memory is listed first, then an older kdump kernel > would get a different memory range. If that's a problem, then define > that low memory goes last. This first entry would need to be the 'crashkernel' range where the kdump kernel is placed, otherwise an older kernel won't boot. The rest can be optional extras, as long as we are tolerant of it being missing... I'll try and look at the rest of this series on Monday, Thanks, James
Hi James, Rob, On 2020/5/30 0:11, James Morse wrote: > Hi guys, > > On 26/05/2020 22:18, Rob Herring wrote: >> On Fri, May 22, 2020 at 11:24:11AM +0800, chenzhou wrote: >>> On 2020/5/21 21:29, Rob Herring wrote: >>>> On Thu, May 21, 2020 at 3:35 AM Chen Zhou <chenzhou10@huawei.com> wrote: >>>>> Add documentation for DT property used by arm64 kdump: >>>>> linux,low-memory-range. >>>>> "linux,low-memory-range" is an another memory region used for crash >>>>> dump kernel devices. >>>>> diff --git a/Documentation/devicetree/bindings/chosen.txt b/Documentation/devicetree/bindings/chosen.txt >>>>> index 45e79172a646..bfe6fb6976e6 100644 >>>>> --- a/Documentation/devicetree/bindings/chosen.txt >>>>> +++ b/Documentation/devicetree/bindings/chosen.txt >>>>> +linux,low-memory-range >>>>> +---------------------- >>>>> +This property (arm64 only) holds a base address and size, describing a >>>>> +limited region below 4G. Similar to "linux,usable-memory-range", it is >>>>> +an another memory range which may be considered available for use by the >>>>> +kernel. >>>> Why can't you just add a range to "linux,usable-memory-range"? It >>>> shouldn't be hard to figure out which part is below 4G. >>> The comments from James: >>> Won't this break if your kdump kernel doesn't know what the extra parameters are? >>> Or if it expects two ranges, but only gets one? These DT properties should be treated as >>> ABI between kernel versions, we can't really change it like this. >>> >>> I think the 'low' region is an optional-extra, that is never mapped by the first kernel. I >>> think the simplest thing to do is to add an 'linux,low-memory-range' that we >>> memblock_add() after memblock_cap_memory_range() has been called. >>> If its missing, or the new kernel doesn't know what its for, everything keeps working. >> >> I don't think there's a compatibility issue here though. The current >> kernel doesn't care if the property is longer than 1 base+size. It only >> checks if the size is less than 1 base+size. > Aha! I missed that. > > >> And yes, we can rely on >> that implementation detail. It's only an ABI if an existing user >> notices. >> >> Now, if the low memory is listed first, then an older kdump kernel >> would get a different memory range. If that's a problem, then define >> that low memory goes last. > This first entry would need to be the 'crashkernel' range where the kdump kernel is > placed, otherwise an older kernel won't boot. The rest can be optional extras, as long as > we are tolerant of it being missing... How about like this: 1. The low memory region remained as "Crash kernel (low)". 2. Userspace will find "Crash kernel" and "Crash kernel (low)" region in /proc/iomem, and add "Crash kernel (low)" as the last range of property "linux,usable-memory-range". Thanks, Chen Zhou > > I'll try and look at the rest of this series on Monday, > > > Thanks, > > James > > . >
diff --git a/Documentation/devicetree/bindings/chosen.txt b/Documentation/devicetree/bindings/chosen.txt index 45e79172a646..bfe6fb6976e6 100644 --- a/Documentation/devicetree/bindings/chosen.txt +++ b/Documentation/devicetree/bindings/chosen.txt @@ -103,6 +103,31 @@ While this property does not represent a real hardware, the address and the size are expressed in #address-cells and #size-cells, respectively, of the root node. +linux,low-memory-range +---------------------- +This property (arm64 only) holds a base address and size, describing a +limited region below 4G. Similar to "linux,usable-memory-range", it is +an another memory range which may be considered available for use by the +kernel. + +e.g. + +/ { + chosen { + linux,low-memory-range = <0x0 0x70000000 0x0 0x10000000>; + linux,usable-memory-range = <0x202f 0xc0000000 0x0 0x40000000>; + }; +}; + +The main usage is for crash dump kernel devices when reserving crashkernel +above 4G. When reserving crashkernel above 4G, there may be two crash kernel +regions, one is below 4G, the other is above 4G. In order to distinct from +the high region, use this property to pass the low region. + +While this property does not represent a real hardware, the address +and the size are expressed in #address-cells and #size-cells, +respectively, of the root node. + linux,elfcorehdr ----------------
Add documentation for DT property used by arm64 kdump: linux,low-memory-range. "linux,low-memory-range" is an another memory region used for crash dump kernel devices. Signed-off-by: Chen Zhou <chenzhou10@huawei.com> --- Documentation/devicetree/bindings/chosen.txt | 25 ++++++++++++++++++++ 1 file changed, 25 insertions(+)