| Message ID | 028270d0-20f0-7037-3b28-dbcc3d93f0cb@fgznet.ch |
|---|---|
| State | New |
| Headers | show |
| Series | libsanitizer: Add missign file and regen Makefile.in | expand |
On Wed, 2020-01-22 at 22:23 +0100, Andreas Tobler wrote: > Hi all, > > I'm digginig out old patches and I want to complete the libasan support > for FreeBSD x86_64. The below one was not that obvious when you have > been away for the past years. > > In the last import the sanitizer_platform_limits_freebsd.cpp got > forgotten. Fix this. > > Ok for trunk once it's open again? > > Thanks, > Andreas > > libsanitizer/sanitizer_common: > > * Makefile.am: Add sanitizer_platform_limits_freebsd.cpp. > * makefile.in: Regenerate I think all the patches in this space are fine for the trunk. As someone else mentioned, the sanitizer patches should probably go through the upstream project as GCC is downstream. Jeff >
On 23.01.20 21:09, Jeff Law wrote: > On Wed, 2020-01-22 at 22:23 +0100, Andreas Tobler wrote: >> Hi all, >> >> I'm digginig out old patches and I want to complete the libasan support >> for FreeBSD x86_64. The below one was not that obvious when you have >> been away for the past years. >> >> In the last import the sanitizer_platform_limits_freebsd.cpp got >> forgotten. Fix this. >> >> Ok for trunk once it's open again? >> >> Thanks, >> Andreas >> >> libsanitizer/sanitizer_common: >> >> * Makefile.am: Add sanitizer_platform_limits_freebsd.cpp. >> * makefile.in: Regenerate > I think all the patches in this space are fine for the trunk. As > someone else mentioned, the sanitizer patches should probably go > through the upstream project as GCC is downstream. Yup. Thanks for the feedback. I'm working on this one. It'll take some time since I learned it is not that easy to build llvm and run a simple test. But that is another story. I'll commit w/o the sanitizer bit once trunk is open for new features. Andreas
On 23.01.20 21:09, Jeff Law wrote: > On Wed, 2020-01-22 at 22:23 +0100, Andreas Tobler wrote: >> Hi all, >> >> I'm digginig out old patches and I want to complete the libasan support >> for FreeBSD x86_64. The below one was not that obvious when you have >> been away for the past years. >> >> In the last import the sanitizer_platform_limits_freebsd.cpp got >> forgotten. Fix this. >> >> Ok for trunk once it's open again? >> >> Thanks, >> Andreas >> >> libsanitizer/sanitizer_common: >> >> * Makefile.am: Add sanitizer_platform_limits_freebsd.cpp. >> * makefile.in: Regenerate > I think all the patches in this space are fine for the trunk. As > someone else mentioned, the sanitizer patches should probably go > through the upstream project as GCC is downstream. I finally did commit the gcc part. The one bit for libsanitizer I left away. Thanks, Andreas
diff --git a/libsanitizer/sanitizer_common/Makefile.am b/libsanitizer/sanitizer_ common/Makefile.am index df9c294151d..9653f27c09f 100644 --- a/libsanitizer/sanitizer_common/Makefile.am +++ b/libsanitizer/sanitizer_common/Makefile.am @@ -44,6 +44,7 @@ sanitizer_common_files = \ sanitizer_netbsd.cpp \ sanitizer_openbsd.cpp \ sanitizer_persistent_allocator.cpp \ + sanitizer_platform_limits_freebsd.cpp \ sanitizer_platform_limits_linux.cpp \ sanitizer_platform_limits_openbsd.cpp \ sanitizer_platform_limits_posix.cpp \
Hi all, I'm digginig out old patches and I want to complete the libasan support for FreeBSD x86_64. The below one was not that obvious when you have been away for the past years. In the last import the sanitizer_platform_limits_freebsd.cpp got forgotten. Fix this. Ok for trunk once it's open again? Thanks, Andreas libsanitizer/sanitizer_common: * Makefile.am: Add sanitizer_platform_limits_freebsd.cpp. * makefile.in: Regenerate