| Message ID | 20200323184228.10798-1-alexander@wetzel-home.de |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/3] AP: Fix Extended Key ID parameter check | expand |
On Mon, Mar 23, 2020 at 07:42:26PM +0100, Alexander Wetzel wrote:
> Check the new variable to be set instead the current setting.
Thanks, applied.
diff --git a/hostapd/config_file.c b/hostapd/config_file.c index 2bc0679b5..8b9b43f9c 100644 --- a/hostapd/config_file.c +++ b/hostapd/config_file.c @@ -2872,10 +2872,10 @@ static int hostapd_config_fill(struct hostapd_config *conf, } else if (os_strcmp(buf, "extended_key_id") == 0) { int val = atoi(pos); - if (bss->extended_key_id < 0 || bss->extended_key_id > 2) { + if (val < 0 || val > 2) { wpa_printf(MSG_ERROR, "Line %d: Invalid extended_key_id=%d; allowed range 0..2", - line, bss->extended_key_id); + line, val); return 1; } bss->extended_key_id = val;
Check the new variable to be set instead the current setting. Signed-off-by: Alexander Wetzel <alexander@wetzel-home.de> --- Without running any tests I have just three changes which look odd. The others also look ok and I'll make some test runs to see how they play out. The first issue in this patch looks like you got distracted when adding "val" and then missed some replacements. hostapd/config_file.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)