mbox series

[v3,bpf-next,0/3] Fixes for bpftool-prog-profile

Message ID 20200312182332.3953408-1-songliubraving@fb.com
Headers show
Series Fixes for bpftool-prog-profile | expand

Message

Song Liu March 12, 2020, 6:23 p.m. UTC 
1. Fix build for older clang;
2. Fix skeleton's dependency on libbpf;
3. Add files to .gitignore.

Changes v2 => v3:
1. Add -I$(LIBBPF_PATH) to Makefile (Quentin);
2. Use p_err() for error message (Quentin).

Changes v1 => v2:
1. Rewrite patch 1 with real feature detection (Quentin, Alexei).
2. Add files to .gitignore (Andrii).

Song Liu (3):
  bpftool: only build bpftool-prog-profile if supported by clang
  bpftool: skeleton should depend on libbpf
  bpftool: add _bpftool and profiler.skel.h to .gitignore

 tools/bpf/bpftool/.gitignore                  |  2 ++
 tools/bpf/bpftool/Makefile                    | 20 +++++++++++++------
 tools/bpf/bpftool/prog.c                      |  1 +
 tools/build/feature/Makefile                  |  9 ++++++++-
 .../build/feature/test-clang-bpf-global-var.c |  4 ++++
 5 files changed, 29 insertions(+), 7 deletions(-)
 create mode 100644 tools/build/feature/test-clang-bpf-global-var.c

--
2.17.1

Comments

Quentin Monnet March 12, 2020, 6:29 p.m. UTC | #1 
2020-03-12 11:23 UTC-0700 ~ Song Liu <songliubraving@fb.com>
> 1. Fix build for older clang;
> 2. Fix skeleton's dependency on libbpf;
> 3. Add files to .gitignore.
> 
> Changes v2 => v3:
> 1. Add -I$(LIBBPF_PATH) to Makefile (Quentin);
> 2. Use p_err() for error message (Quentin).
> 
> Changes v1 => v2:
> 1. Rewrite patch 1 with real feature detection (Quentin, Alexei).
> 2. Add files to .gitignore (Andrii).
> 
> Song Liu (3):
>   bpftool: only build bpftool-prog-profile if supported by clang
>   bpftool: skeleton should depend on libbpf
>   bpftool: add _bpftool and profiler.skel.h to .gitignore
> 
>  tools/bpf/bpftool/.gitignore                  |  2 ++
>  tools/bpf/bpftool/Makefile                    | 20 +++++++++++++------
>  tools/bpf/bpftool/prog.c                      |  1 +
>  tools/build/feature/Makefile                  |  9 ++++++++-
>  .../build/feature/test-clang-bpf-global-var.c |  4 ++++
>  5 files changed, 29 insertions(+), 7 deletions(-)
>  create mode 100644 tools/build/feature/test-clang-bpf-global-var.c
> 
> --
> 2.17.1
> 

Series looks great, thank you!

Reviewed-by: Quentin Monnet <quentin@isovalent.com>
Daniel Borkmann March 12, 2020, 11:11 p.m. UTC | #2 
On 3/12/20 7:23 PM, Song Liu wrote:
> 1. Fix build for older clang;
> 2. Fix skeleton's dependency on libbpf;
> 3. Add files to .gitignore.
> 
> Changes v2 => v3:
> 1. Add -I$(LIBBPF_PATH) to Makefile (Quentin);
> 2. Use p_err() for error message (Quentin).
> 
> Changes v1 => v2:
> 1. Rewrite patch 1 with real feature detection (Quentin, Alexei).
> 2. Add files to .gitignore (Andrii).
> 
> Song Liu (3):
>    bpftool: only build bpftool-prog-profile if supported by clang
>    bpftool: skeleton should depend on libbpf
>    bpftool: add _bpftool and profiler.skel.h to .gitignore
> 
>   tools/bpf/bpftool/.gitignore                  |  2 ++
>   tools/bpf/bpftool/Makefile                    | 20 +++++++++++++------
>   tools/bpf/bpftool/prog.c                      |  1 +
>   tools/build/feature/Makefile                  |  9 ++++++++-
>   .../build/feature/test-clang-bpf-global-var.c |  4 ++++
>   5 files changed, 29 insertions(+), 7 deletions(-)
>   create mode 100644 tools/build/feature/test-clang-bpf-global-var.c

Tested with clang-7 and clang-11; looks good, applied, thanks!