| Message ID | 20200120201823.887937-1-antoine.tenart@bootlin.com |
|---|---|
| Headers | show |
| Series | macsec: add offloading support | expand |
2020-01-20, 21:18:21 +0100, Antoine Tenart wrote: > If a mode isn't supported, `ip macsec offload` will report an issue > (-EOPNOTSUPP). > > One thing not supported in this series would be the ability to list all > supported modes (for now 'off' and 'phy') depending on the h/w interface > capabilities. This can come up in a later patch, as this is not critical > to get the feature used, but I would like this to be compatible with the > current series. I can think of 2 possibilities: either through > `ip macsec show` or through `ip macsec offload` (for example when no > argument is given). What are your thoughts on this? I don't think that's really helpful. The device could change between listing available modes and enabling offloading. The failure of "ip macsec offload blah" (or whatever the command ends up being) will do the same job anyway.
Hello, This series adds support for selecting and reporting the offloading mode of a MACsec interface. Available modes are for now 'off' and 'phy', 'off' being the default when an interface is created. Modes are not only 'off' and 'on' as the MACsec operations can be offloaded to multiple kinds of specialized hardware devices, at least to PHYs and Ethernet MACs. The later isn't currently supported in the kernel though. The first patch adds support for reporting the offloading mode currently selected for a given MACsec interface through the `ip macsec show` command: # ip macsec show 18: macsec0: protect on validate strict sc off sa off encrypt on send_sci on end_station off scb off replay off cipher suite: GCM-AES-128, using ICV length 16 TXSC: 3e5035b67c860001 on SA 0 0: PN 1, state on, key 00000000000000000000000000000000 RXSC: b4969112700f0001, state on 0: PN 1, state on, key 01000000000000000000000000000000 -> offload: phy 19: macsec1: protect on validate strict sc off sa off encrypt on send_sci on end_station off scb off replay off cipher suite: GCM-AES-128, using ICV length 16 TXSC: 3e5035b67c880001 on SA 0 1: PN 1, state on, key 00000000000000000000000000000000 RXSC: b4969112700f0001, state on 1: PN 1, state on, key 01000000000000000000000000000000 -> offload: off The second patch allows an user to change the offloading mode at runtime through a new subcommand, `ip macsec offload`: # ip macsec offload macsec0 phy # ip macsec offload macsec0 off If a mode isn't supported, `ip macsec offload` will report an issue (-EOPNOTSUPP). One thing not supported in this series would be the ability to list all supported modes (for now 'off' and 'phy') depending on the h/w interface capabilities. This can come up in a later patch, as this is not critical to get the feature used, but I would like this to be compatible with the current series. I can think of 2 possibilities: either through `ip macsec show` or through `ip macsec offload` (for example when no argument is given). What are your thoughts on this? Thanks! Antoine Antoine Tenart (2): macsec: report the offloading mode currently selected macsec: add support for changing the offloading mode ip/ipmacsec.c | 63 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 63 insertions(+)