| Message ID | 20110526030600.GB4978@rox.home.comstyle.com |
|---|---|
| State | New |
| Headers | show |
On 25/05/11 11:06 PM, Brad wrote: > Use the correct header in the TCG MIPS code to find cacheflush() on OpenBSD > to fix compilation of the MIPS host support for OpenBSD/mips64 based architecures. ping. > Signed-off-by: Brad Smith<brad@comstyle.com> > > --- > tcg/mips/tcg-target.h | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/tcg/mips/tcg-target.h b/tcg/mips/tcg-target.h > index 0028bfa..8cb7d88 100644 > --- a/tcg/mips/tcg-target.h > +++ b/tcg/mips/tcg-target.h > @@ -102,7 +102,11 @@ enum { > /* guest base is supported */ > #define TCG_TARGET_HAS_GUEST_BASE > > +#ifdef __OpenBSD__ > +#include<machine/sysarch.h> > +#else > #include<sys/cachectl.h> > +#endif > > static inline void flush_icache_range(unsigned long start, unsigned long stop) > {
Am 30.05.2011 um 23:01 schrieb Brad: > On 25/05/11 11:06 PM, Brad wrote: >> Use the correct header in the TCG MIPS code to find cacheflush() on >> OpenBSD >> to fix compilation of the MIPS host support for OpenBSD/mips64 >> based architecures. > > ping. > >> Signed-off-by: Brad Smith<brad@comstyle.com> >> >> --- >> tcg/mips/tcg-target.h | 4 ++++ >> 1 files changed, 4 insertions(+), 0 deletions(-) >> >> diff --git a/tcg/mips/tcg-target.h b/tcg/mips/tcg-target.h >> index 0028bfa..8cb7d88 100644 >> --- a/tcg/mips/tcg-target.h >> +++ b/tcg/mips/tcg-target.h >> @@ -102,7 +102,11 @@ enum { >> /* guest base is supported */ >> #define TCG_TARGET_HAS_GUEST_BASE >> >> +#ifdef __OpenBSD__ >> +#include<machine/sysarch.h> Usually we have a space in there. Bad example below. ;) >> +#else >> #include<sys/cachectl.h> >> +#endif >> >> static inline void flush_icache_range(unsigned long start, >> unsigned long stop) >> {
On 30/05/11 5:16 PM, Andreas Färber wrote: > Am 30.05.2011 um 23:01 schrieb Brad: > >> On 25/05/11 11:06 PM, Brad wrote: >>> Use the correct header in the TCG MIPS code to find cacheflush() on >>> OpenBSD >>> to fix compilation of the MIPS host support for OpenBSD/mips64 based >>> architecures. >> >> ping. >> >>> Signed-off-by: Brad Smith<brad@comstyle.com> >>> >>> --- >>> tcg/mips/tcg-target.h | 4 ++++ >>> 1 files changed, 4 insertions(+), 0 deletions(-) >>> >>> diff --git a/tcg/mips/tcg-target.h b/tcg/mips/tcg-target.h >>> index 0028bfa..8cb7d88 100644 >>> --- a/tcg/mips/tcg-target.h >>> +++ b/tcg/mips/tcg-target.h >>> @@ -102,7 +102,11 @@ enum { >>> /* guest base is supported */ >>> #define TCG_TARGET_HAS_GUEST_BASE >>> >>> +#ifdef __OpenBSD__ >>> +#include<machine/sysarch.h> > > Usually we have a space in there. Bad example below. ;) In the original diff as it came across the mailing list even there is a space.
On 30/05/11 5:22 PM, Brad wrote: > On 30/05/11 5:16 PM, Andreas Färber wrote: >> Am 30.05.2011 um 23:01 schrieb Brad: >> >>> On 25/05/11 11:06 PM, Brad wrote: >>>> Use the correct header in the TCG MIPS code to find cacheflush() on >>>> OpenBSD >>>> to fix compilation of the MIPS host support for OpenBSD/mips64 based >>>> architecures. >>> >>> ping. >>> >>>> Signed-off-by: Brad Smith<brad@comstyle.com> >>>> >>>> --- >>>> tcg/mips/tcg-target.h | 4 ++++ >>>> 1 files changed, 4 insertions(+), 0 deletions(-) >>>> >>>> diff --git a/tcg/mips/tcg-target.h b/tcg/mips/tcg-target.h >>>> index 0028bfa..8cb7d88 100644 >>>> --- a/tcg/mips/tcg-target.h >>>> +++ b/tcg/mips/tcg-target.h >>>> @@ -102,7 +102,11 @@ enum { >>>> /* guest base is supported */ >>>> #define TCG_TARGET_HAS_GUEST_BASE >>>> >>>> +#ifdef __OpenBSD__ >>>> +#include<machine/sysarch.h> >> >> Usually we have a space in there. Bad example below. ;) > > In the original diff as it came across the mailing list even there > is a space. Looks like a case of stupid ThunderBird mangling the e-mail content upon replying. I didn't send the diff with ThunderBird.
Am 30.05.2011 um 23:22 schrieb Brad: > On 30/05/11 5:16 PM, Andreas Färber wrote: >> Am 30.05.2011 um 23:01 schrieb Brad: >> >>> On 25/05/11 11:06 PM, Brad wrote: >>>> Use the correct header in the TCG MIPS code to find cacheflush() on >>>> OpenBSD >>>> to fix compilation of the MIPS host support for OpenBSD/mips64 >>>> based >>>> architecures. >>> >>> ping. >>> >>>> Signed-off-by: Brad Smith<brad@comstyle.com> >>>> >>>> --- >>>> tcg/mips/tcg-target.h | 4 ++++ >>>> 1 files changed, 4 insertions(+), 0 deletions(-) >>>> >>>> diff --git a/tcg/mips/tcg-target.h b/tcg/mips/tcg-target.h >>>> index 0028bfa..8cb7d88 100644 >>>> --- a/tcg/mips/tcg-target.h >>>> +++ b/tcg/mips/tcg-target.h >>>> @@ -102,7 +102,11 @@ enum { >>>> /* guest base is supported */ >>>> #define TCG_TARGET_HAS_GUEST_BASE >>>> >>>> +#ifdef __OpenBSD__ >>>> +#include<machine/sysarch.h> >> >> Usually we have a space in there. Bad example below. ;) > > In the original diff as it came across the mailing list even there > is a space. Confirmed, looks better on Patchwork: http://patchwork.ozlabs.org/patch/97488/ Andreas
On Wed, May 25, 2011 at 11:06:00PM -0400, Brad wrote: > Use the correct header in the TCG MIPS code to find cacheflush() on OpenBSD > to fix compilation of the MIPS host support for OpenBSD/mips64 based architecures. > > Signed-off-by: Brad Smith <brad@comstyle.com> > > --- > tcg/mips/tcg-target.h | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) Thanks, applied. > diff --git a/tcg/mips/tcg-target.h b/tcg/mips/tcg-target.h > index 0028bfa..8cb7d88 100644 > --- a/tcg/mips/tcg-target.h > +++ b/tcg/mips/tcg-target.h > @@ -102,7 +102,11 @@ enum { > /* guest base is supported */ > #define TCG_TARGET_HAS_GUEST_BASE > > +#ifdef __OpenBSD__ > +#include <machine/sysarch.h> > +#else > #include <sys/cachectl.h> > +#endif > > static inline void flush_icache_range(unsigned long start, unsigned long stop) > { > -- > 1.7.5 > > -- > This message has been scanned for viruses and > dangerous content by MailScanner, and is > believed to be clean. > > >
diff --git a/tcg/mips/tcg-target.h b/tcg/mips/tcg-target.h index 0028bfa..8cb7d88 100644 --- a/tcg/mips/tcg-target.h +++ b/tcg/mips/tcg-target.h @@ -102,7 +102,11 @@ enum { /* guest base is supported */ #define TCG_TARGET_HAS_GUEST_BASE +#ifdef __OpenBSD__ +#include <machine/sysarch.h> +#else #include <sys/cachectl.h> +#endif static inline void flush_icache_range(unsigned long start, unsigned long stop) {
Use the correct header in the TCG MIPS code to find cacheflush() on OpenBSD to fix compilation of the MIPS host support for OpenBSD/mips64 based architecures. Signed-off-by: Brad Smith <brad@comstyle.com> --- tcg/mips/tcg-target.h | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)