| Message ID | 1573148860-30254-4-git-send-email-magnus.karlsson@intel.com |
|---|---|
| State | Accepted |
| Delegated to: | BPF Maintainers |
| Headers | show |
| Series | Extend libbpf to support shared umems and Rx|Tx-only sockets | expand |
On 7 Nov 2019, at 9:47, Magnus Karlsson wrote: > The libbpf AF_XDP code is extended to allow for the creation of Rx > only or Tx only sockets. Previously it returned an error if the socket > was not initialized for both Rx and Tx. > > Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com> Acked-by: Jonathan Lemon <jonathan.lemon@gmail.com>
On Fri, Nov 8, 2019 at 3:00 PM Jonathan Lemon <jonathan.lemon@gmail.com> wrote: > > > > On 7 Nov 2019, at 9:47, Magnus Karlsson wrote: > > > The libbpf AF_XDP code is extended to allow for the creation of Rx > > only or Tx only sockets. Previously it returned an error if the socket > > was not initialized for both Rx and Tx. > > > > Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com> > > Acked-by: Jonathan Lemon <jonathan.lemon@gmail.com> Tested-by: William Tu <u9012063@gmail.com>
diff --git a/tools/lib/bpf/xsk.c b/tools/lib/bpf/xsk.c index 8ebd810..303ed63 100644 --- a/tools/lib/bpf/xsk.c +++ b/tools/lib/bpf/xsk.c @@ -562,7 +562,8 @@ static int xsk_setup_xdp_prog(struct xsk_socket *xsk) } } - err = xsk_set_bpf_maps(xsk); + if (xsk->rx) + err = xsk_set_bpf_maps(xsk); if (err) { xsk_delete_bpf_maps(xsk); close(xsk->prog_fd); @@ -583,7 +584,7 @@ int xsk_socket__create(struct xsk_socket **xsk_ptr, const char *ifname, struct xsk_socket *xsk; int err; - if (!umem || !xsk_ptr || !rx || !tx) + if (!umem || !xsk_ptr || !(rx || tx)) return -EFAULT; xsk = calloc(1, sizeof(*xsk));
The libbpf AF_XDP code is extended to allow for the creation of Rx only or Tx only sockets. Previously it returned an error if the socket was not initialized for both Rx and Tx. Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com> --- tools/lib/bpf/xsk.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)