diff mbox series

parser: extend SERIES_DELAY_INTERVAL

Message ID 20191021054431.28584-1-dja@axtens.net
State Accepted
Headers show
Series parser: extend SERIES_DELAY_INTERVAL | expand

Commit Message

Daniel Axtens Oct. 21, 2019, 5:44 a.m. UTC
There was a series on linuxppc today that was spread over ~13 mins,
so the last two patches were put into a new series.

Extend the time window to 20 mins, and attempt to document it.

Signed-off-by: Daniel Axtens <dja@axtens.net>
---
 patchwork/parser.py | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

Comments

Andrew Donnellan Oct. 23, 2019, 2:41 a.m. UTC | #1
On 21/10/19 4:44 pm, Daniel Axtens wrote:
> There was a series on linuxppc today that was spread over ~13 mins,
> so the last two patches were put into a new series.
> 
> Extend the time window to 20 mins, and attempt to document it.
> 
> Signed-off-by: Daniel Axtens <dja@axtens.net>

Reviewed-by: Andrew Donnellan <ajd@linux.ibm.com>

> ---
>   patchwork/parser.py | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git patchwork/parser.py patchwork/parser.py
> index be1e51652dd3..c794f093c412 100644
> --- patchwork/parser.py
> +++ patchwork/parser.py
> @@ -35,7 +35,12 @@ _hunk_re = re.compile(r'^\@\@ -\d+(?:,(\d+))? \+\d+(?:,(\d+))? \@\@')
>   _filename_re = re.compile(r'^(---|\+\+\+) (\S+)')
>   list_id_headers = ['List-ID', 'X-Mailing-List', 'X-list']
>   
> -SERIES_DELAY_INTERVAL = 10
> +# How many minutes must pass since the first email of a series before we
> +# say that subsequent mails are definitely not part of that same series?
> +#
> +# Only used when there are not proper references to determine the series
> +# (such as when the mail is not threaded)
> +SERIES_DELAY_INTERVAL = 20
>   
>   # @see https://git-scm.com/docs/git-diff#_generating_patches_with_p
>   EXTENDED_HEADER_LINES = (
>
Daniel Axtens Oct. 29, 2019, 6:24 a.m. UTC | #2
Applied, thanks for the review Andrew.


> On 21/10/19 4:44 pm, Daniel Axtens wrote:
>> There was a series on linuxppc today that was spread over ~13 mins,
>> so the last two patches were put into a new series.
>> 
>> Extend the time window to 20 mins, and attempt to document it.
>> 
>> Signed-off-by: Daniel Axtens <dja@axtens.net>
>
> Reviewed-by: Andrew Donnellan <ajd@linux.ibm.com>
>
>> ---
>>   patchwork/parser.py | 7 ++++++-
>>   1 file changed, 6 insertions(+), 1 deletion(-)
>> 
>> diff --git patchwork/parser.py patchwork/parser.py
>> index be1e51652dd3..c794f093c412 100644
>> --- patchwork/parser.py
>> +++ patchwork/parser.py
>> @@ -35,7 +35,12 @@ _hunk_re = re.compile(r'^\@\@ -\d+(?:,(\d+))? \+\d+(?:,(\d+))? \@\@')
>>   _filename_re = re.compile(r'^(---|\+\+\+) (\S+)')
>>   list_id_headers = ['List-ID', 'X-Mailing-List', 'X-list']
>>   
>> -SERIES_DELAY_INTERVAL = 10
>> +# How many minutes must pass since the first email of a series before we
>> +# say that subsequent mails are definitely not part of that same series?
>> +#
>> +# Only used when there are not proper references to determine the series
>> +# (such as when the mail is not threaded)
>> +SERIES_DELAY_INTERVAL = 20
>>   
>>   # @see https://git-scm.com/docs/git-diff#_generating_patches_with_p
>>   EXTENDED_HEADER_LINES = (
>> 
>
> -- 
> Andrew Donnellan              OzLabs, ADL Canberra
> ajd@linux.ibm.com             IBM Australia Limited
diff mbox series

Patch

diff --git patchwork/parser.py patchwork/parser.py
index be1e51652dd3..c794f093c412 100644
--- patchwork/parser.py
+++ patchwork/parser.py
@@ -35,7 +35,12 @@  _hunk_re = re.compile(r'^\@\@ -\d+(?:,(\d+))? \+\d+(?:,(\d+))? \@\@')
 _filename_re = re.compile(r'^(---|\+\+\+) (\S+)')
 list_id_headers = ['List-ID', 'X-Mailing-List', 'X-list']
 
-SERIES_DELAY_INTERVAL = 10
+# How many minutes must pass since the first email of a series before we
+# say that subsequent mails are definitely not part of that same series?
+#
+# Only used when there are not proper references to determine the series
+# (such as when the mail is not threaded)
+SERIES_DELAY_INTERVAL = 20
 
 # @see https://git-scm.com/docs/git-diff#_generating_patches_with_p
 EXTENDED_HEADER_LINES = (