| Message ID | 20191019153437.9820-8-f4bug@amsat.org |
|---|---|
| State | New |
| Headers | show |
| Series | tests/acceptance: Fix 64-bit MIPS target tests | expand |
On Saturday, October 19, 2019, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: > If a test fails, it can corrupt the underlying QCow2 image, > making further tests failing. > Fix this by running each test with a snapshot. > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > tests/acceptance/linux_ssh_mips_malta.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Reviewed-by: Aleksandar Markovic <amarkovic@wavecomp.com> > diff --git a/tests/acceptance/linux_ssh_mips_malta.py > b/tests/acceptance/linux_ssh_mips_malta.py > index ffbb06f846..27907e8fbd 100644 > --- a/tests/acceptance/linux_ssh_mips_malta.py > +++ b/tests/acceptance/linux_ssh_mips_malta.py > @@ -90,7 +90,7 @@ class LinuxSSH(Test): > self.vm.add_args('-no-reboot', > '-kernel', kernel_path, > '-append', kernel_command_line, > - '-hda', image_path, > + '-drive', 'file=%s,snapshot=on' % image_path, > '-netdev', 'user,id=vnet,hostfwd=:127.0. > 0.1:0-:22', > '-device', 'pcnet,netdev=vnet') > self.vm.launch() > -- > 2.21.0 > > >
Cleber, Eduardo: ping? On 10/19/19 5:34 PM, Philippe Mathieu-Daudé wrote: > If a test fails, it can corrupt the underlying QCow2 image, > making further tests failing. > Fix this by running each test with a snapshot. > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > tests/acceptance/linux_ssh_mips_malta.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/acceptance/linux_ssh_mips_malta.py b/tests/acceptance/linux_ssh_mips_malta.py > index ffbb06f846..27907e8fbd 100644 > --- a/tests/acceptance/linux_ssh_mips_malta.py > +++ b/tests/acceptance/linux_ssh_mips_malta.py > @@ -90,7 +90,7 @@ class LinuxSSH(Test): > self.vm.add_args('-no-reboot', > '-kernel', kernel_path, > '-append', kernel_command_line, > - '-hda', image_path, > + '-drive', 'file=%s,snapshot=on' % image_path, > '-netdev', 'user,id=vnet,hostfwd=:127.0.0.1:0-:22', > '-device', 'pcnet,netdev=vnet') > self.vm.launch() >
On Sat, Jan 18, 2020 at 12:32 PM Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > > Cleber, Eduardo: ping? Oops wrong patch =) > On 10/19/19 5:34 PM, Philippe Mathieu-Daudé wrote: > > If a test fails, it can corrupt the underlying QCow2 image, > > making further tests failing. > > Fix this by running each test with a snapshot. > > > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > > --- > > tests/acceptance/linux_ssh_mips_malta.py | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tests/acceptance/linux_ssh_mips_malta.py b/tests/acceptance/linux_ssh_mips_malta.py > > index ffbb06f846..27907e8fbd 100644 > > --- a/tests/acceptance/linux_ssh_mips_malta.py > > +++ b/tests/acceptance/linux_ssh_mips_malta.py > > @@ -90,7 +90,7 @@ class LinuxSSH(Test): > > self.vm.add_args('-no-reboot', > > '-kernel', kernel_path, > > '-append', kernel_command_line, > > - '-hda', image_path, > > + '-drive', 'file=%s,snapshot=on' % image_path, > > '-netdev', 'user,id=vnet,hostfwd=:127.0.0.1:0-:22', > > '-device', 'pcnet,netdev=vnet') > > self.vm.launch() > >
diff --git a/tests/acceptance/linux_ssh_mips_malta.py b/tests/acceptance/linux_ssh_mips_malta.py index ffbb06f846..27907e8fbd 100644 --- a/tests/acceptance/linux_ssh_mips_malta.py +++ b/tests/acceptance/linux_ssh_mips_malta.py @@ -90,7 +90,7 @@ class LinuxSSH(Test): self.vm.add_args('-no-reboot', '-kernel', kernel_path, '-append', kernel_command_line, - '-hda', image_path, + '-drive', 'file=%s,snapshot=on' % image_path, '-netdev', 'user,id=vnet,hostfwd=:127.0.0.1:0-:22', '-device', 'pcnet,netdev=vnet') self.vm.launch()
If a test fails, it can corrupt the underlying QCow2 image, making further tests failing. Fix this by running each test with a snapshot. Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- tests/acceptance/linux_ssh_mips_malta.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)