| Message ID | 1b01287241d49638c43222d32f3ece5a38c95ddf.1566458029.git.rahul.tanwar@linux.intel.com |
|---|---|
| State | Rejected, archived |
| Headers | show |
| Series | x86/rtc: Add option to skip using RTC | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | "total: 0 errors, 1 warnings, 14 lines checked" |
On Thu, Aug 22, 2019 at 03:44:04PM +0800, Rahul Tanwar wrote: > Some products may not support MC146818 RTC CMOS device. Introduce a optional > 'status' standard property for RTC-CMOS to indicate if the MC146818 RTC device > is available (status="okay") or not (status="disabled") This needs to be converted to YAML
On 22/08/2019 11:56:59+0300, Andy Shevchenko wrote: > On Thu, Aug 22, 2019 at 03:44:04PM +0800, Rahul Tanwar wrote: > > Some products may not support MC146818 RTC CMOS device. Introduce a optional > > 'status' standard property for RTC-CMOS to indicate if the MC146818 RTC device > > is available (status="okay") or not (status="disabled") > > This needs to be converted to YAML > Well, I think the status property doesn't even need to be documented because it is simply the generic behaviour.
On 22/8/2019 5:09 PM, Alexandre Belloni wrote: > On 22/08/2019 11:56:59+0300, Andy Shevchenko wrote: >> On Thu, Aug 22, 2019 at 03:44:04PM +0800, Rahul Tanwar wrote: >>> Some products may not support MC146818 RTC CMOS device. Introduce a optional >>> 'status' standard property for RTC-CMOS to indicate if the MC146818 RTC device >>> is available (status="okay") or not (status="disabled") >> This needs to be converted to YAML >> > Well, I think the status property doesn't even need to be documented > because it is simply the generic behaviour. Thanks for your comments. I now realize it. I will omit posting this again. Regards, Rahul
diff --git a/Documentation/devicetree/bindings/rtc/rtc-cmos.txt b/Documentation/devicetree/bindings/rtc/rtc-cmos.txt index b94b35f3600b..fea4fe0ed4b9 100644 --- a/Documentation/devicetree/bindings/rtc/rtc-cmos.txt +++ b/Documentation/devicetree/bindings/rtc/rtc-cmos.txt @@ -11,6 +11,9 @@ Optional properties: called "Register B". - freq-reg : Contains the initial value of the frequency register also called "Regsiter A". + - status: indicates the operational status of the device. + Value must be either "disabled" or "okay". + "Register A" and "B" are usually initialized by the firmware (BIOS for instance). If this is not done, it can be performed by the driver. @@ -24,4 +27,5 @@ ISA Example: ctrl-reg = <2>; freq-reg = <0x26>; reg = <1 0x70 2>; + status = "okay"; };
Some products may not support MC146818 RTC CMOS device. Introduce a optional 'status' standard property for RTC-CMOS to indicate if the MC146818 RTC device is available (status="okay") or not (status="disabled") Signed-off-by: Rahul Tanwar <rahul.tanwar@linux.intel.com> --- Documentation/devicetree/bindings/rtc/rtc-cmos.txt | 4 ++++ 1 file changed, 4 insertions(+)