mbox series

[v2,0/2] Add Sharp panel option for Lenovo Miix 630

Message ID 20190708165647.46224-1-jeffrey.l.hugo@gmail.com
Headers show
Series Add Sharp panel option for Lenovo Miix 630 | expand

Message

Jeffrey Hugo July 8, 2019, 4:56 p.m. UTC 
The Lenovo Miix 630 laptop can be found with one of two panels - a BOE
or Sharp option.  This likely provides options during manufacturing.

These panels connect via eDP, however they sit behind a DSI to eDP
bridge on the laptop, so they can easily be handled by the existing
simple panel code.

This series adds support for the Sharp option.

v2:
-removed no-hpd from dt example
-added .bus_format and .bus_flags fields based on reviews
-added .flags after Bjorn pointed me to something I missed
-added Sam's reviewed-by tags

Jeffrey Hugo (2):
  dt-bindings: panel: Add Sharp LD-D5116Z01B
  drm/panel: simple: Add support for Sharp LD-D5116Z01B panel

 .../display/panel/sharp,ld-d5116z01b.txt      | 26 +++++++++++++++++
 drivers/gpu/drm/panel/panel-simple.c          | 29 +++++++++++++++++++
 2 files changed, 55 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,ld-d5116z01b.txt

Comments

Sam Ravnborg July 26, 2019, 12:36 p.m. UTC | #1 
Hi Jeffrey.

On Mon, Jul 08, 2019 at 09:56:47AM -0700, Jeffrey Hugo wrote:
> The Lenovo Miix 630 laptop can be found with one of two panels - a BOE
> or Sharp option.  This likely provides options during manufacturing.
> 
> These panels connect via eDP, however they sit behind a DSI to eDP
> bridge on the laptop, so they can easily be handled by the existing
> simple panel code.
> 
> This series adds support for the Sharp option.
> 
> v2:
> -removed no-hpd from dt example
> -added .bus_format and .bus_flags fields based on reviews
> -added .flags after Bjorn pointed me to something I missed
> -added Sam's reviewed-by tags
> 
> Jeffrey Hugo (2):
>   dt-bindings: panel: Add Sharp LD-D5116Z01B
>   drm/panel: simple: Add support for Sharp LD-D5116Z01B panel

Thanks.
Both patches applied and pushed to drm-misc-next.

Are you up to a little janitorial work?
Today the preferred format for bindings files are the new yaml format.
Could you update 'your' file, and maybe the other sharp files too?
It would be good to have some progress in this.

	Sam
Jeffrey Hugo July 26, 2019, 2:31 p.m. UTC | #2 
On Fri, Jul 26, 2019 at 6:36 AM Sam Ravnborg <sam@ravnborg.org> wrote:
>
> Hi Jeffrey.
>
> On Mon, Jul 08, 2019 at 09:56:47AM -0700, Jeffrey Hugo wrote:
> > The Lenovo Miix 630 laptop can be found with one of two panels - a BOE
> > or Sharp option.  This likely provides options during manufacturing.
> >
> > These panels connect via eDP, however they sit behind a DSI to eDP
> > bridge on the laptop, so they can easily be handled by the existing
> > simple panel code.
> >
> > This series adds support for the Sharp option.
> >
> > v2:
> > -removed no-hpd from dt example
> > -added .bus_format and .bus_flags fields based on reviews
> > -added .flags after Bjorn pointed me to something I missed
> > -added Sam's reviewed-by tags
> >
> > Jeffrey Hugo (2):
> >   dt-bindings: panel: Add Sharp LD-D5116Z01B
> >   drm/panel: simple: Add support for Sharp LD-D5116Z01B panel
>
> Thanks.
> Both patches applied and pushed to drm-misc-next.

Excellent.  Thanks

> Are you up to a little janitorial work?
> Today the preferred format for bindings files are the new yaml format.
> Could you update 'your' file, and maybe the other sharp files too?

I confess I haven't yet familiarized myself with the yaml format yet,
but I'll take a look and do an update once I understand the
requirements.