Message ID | 20190715152225.26135-1-philmd@redhat.com |
---|---|
Headers | show |
Series | semihosting: Build with CONFIG_SEMIHOSTING disabled | expand |
Patchew URL: https://patchew.org/QEMU/20190715152225.26135-1-philmd@redhat.com/ Hi, This series failed build test on s390x host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a commit that has the patches applied on top of "base" # branch set -e echo echo "=== ENV ===" env echo echo "=== PACKAGES ===" rpm -qa echo echo "=== UNAME ===" uname -a CC=$HOME/bin/cc INSTALL=$PWD/install BUILD=$PWD/build mkdir -p $BUILD $INSTALL SRC=$PWD cd $BUILD $SRC/configure --cc=$CC --prefix=$INSTALL make -j4 # XXX: we need reliable clean up # make check -j4 V=1 make install === TEST SCRIPT END === CC mips64-linux-user/linux-user/fd-trans.o CC mips64-linux-user/target/mips/translate.o CC mips64el-linux-user/target/mips/mips-semi-stubs.o /var/tmp/patchew-tester-tmp-n0mrs_zw/src/target/mips/mips-semi-stubs.c:19:6: error: no previous prototype for ‘helper_do_semihosting’ [-Werror=missing-prototypes] 19 | void helper_do_semihosting(CPUMIPSState *env) | ^~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors --- CC mipsel-linux-user/target/mips/translate.o CC mips64-linux-user/target/mips/msa_helper.o CC mips64-linux-user/target/mips/mips-semi-stubs.o /var/tmp/patchew-tester-tmp-n0mrs_zw/src/target/mips/mips-semi-stubs.c:19:6: error: no previous prototype for ‘helper_do_semihosting’ [-Werror=missing-prototypes] 19 | void helper_do_semihosting(CPUMIPSState *env) | ^~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors --- CC mipsel-linux-user/target/mips/mips-semi-stubs.o GEN trace/generated-helpers.c CC mipsel-linux-user/trace/control-target.o /var/tmp/patchew-tester-tmp-n0mrs_zw/src/target/mips/mips-semi-stubs.c:19:6: error: no previous prototype for ‘helper_do_semihosting’ [-Werror=missing-prototypes] 19 | void helper_do_semihosting(CPUMIPSState *env) | ^~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors The full log is available at http://patchew.org/logs/20190715152225.26135-1-philmd@redhat.com/testing.s390x/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
On 7/15/19 5:22 PM, Philippe Mathieu-Daudé wrote: > Amusingly Miroslav and myself hit this issue at the same time. > > Note now that "config-devices.h" exists (commit 6c22ea9d83) I could use > #include "config-devices.h" to implement Alex's suggestion to avoid a stub: > https://lists.gnu.org/archive/html/qemu-devel/2019-06/msg03607.html > > Some know (arch-specific) limitations are: > > - MIPS ITU is accessed by coprocessor instr (ISA feature) > - MIPS timer is accessed by coprocessor instr (ISA feature) > - MIPS semihosting (ISA feature?) > - ARM semihosting (ISA feature?) > - ARMv7 NVIC (device) > > This series attempt to fix this the most trivial way, adding > stubs for unreachable code. Please disregard this series for 4.1 release. As explained Peter on IRC, "feature changes need to be ready before softfreeze".
Patchew URL: https://patchew.org/QEMU/20190715152225.26135-1-philmd@redhat.com/ Hi, This series failed build test on s390x host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a commit that has the patches applied on top of "base" # branch set -e echo echo "=== ENV ===" env echo echo "=== PACKAGES ===" rpm -qa echo echo "=== UNAME ===" uname -a CC=$HOME/bin/cc INSTALL=$PWD/install BUILD=$PWD/build mkdir -p $BUILD $INSTALL SRC=$PWD cd $BUILD $SRC/configure --cc=$CC --prefix=$INSTALL make -j4 # XXX: we need reliable clean up # make check -j4 V=1 make install === TEST SCRIPT END === CC mips-linux-user/target/mips/gdbstub.o CC mips-linux-user/target/mips/msa_helper.o CC mipsel-linux-user/target/mips/mips-semi-stubs.o /var/tmp/patchew-tester-tmp-3dkdm5ft/src/target/mips/mips-semi-stubs.c:19:6: error: no previous prototype for ‘helper_do_semihosting’ [-Werror=missing-prototypes] 19 | void helper_do_semihosting(CPUMIPSState *env) | ^~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors --- CC mips64-linux-user/fpu/softfloat.o CC mips-linux-user/target/mips/mips-semi-stubs.o CC mips64-linux-user/gdbstub.o /var/tmp/patchew-tester-tmp-3dkdm5ft/src/target/mips/mips-semi-stubs.c:19:6: error: no previous prototype for ‘helper_do_semihosting’ [-Werror=missing-prototypes] 19 | void helper_do_semihosting(CPUMIPSState *env) | ^~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors --- CC mips64-linux-user/accel/tcg/tcg-runtime-gvec.o CC mips64el-linux-user/target/mips/mips-semi-stubs.o CC mips64-linux-user/accel/tcg/cpu-exec.o /var/tmp/patchew-tester-tmp-3dkdm5ft/src/target/mips/mips-semi-stubs.c:19:6: error: no previous prototype for ‘helper_do_semihosting’ [-Werror=missing-prototypes] 19 | void helper_do_semihosting(CPUMIPSState *env) | ^~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors --- CC mips64-linux-user/target/mips/gdbstub.o CC mips64-linux-user/target/mips/msa_helper.o CC mips64-linux-user/target/mips/mips-semi-stubs.o /var/tmp/patchew-tester-tmp-3dkdm5ft/src/target/mips/mips-semi-stubs.c:19:6: error: no previous prototype for ‘helper_do_semihosting’ [-Werror=missing-prototypes] 19 | void helper_do_semihosting(CPUMIPSState *env) | ^~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors The full log is available at http://patchew.org/logs/20190715152225.26135-1-philmd@redhat.com/testing.s390x/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com