| Message ID | 1561958991-21935-1-git-send-email-manish.narani@xilinx.com |
|---|---|
| Headers | show |
| Series | Arasan SDHCI enhancements and ZynqMP Tap Delays Handling | expand |
Hi Manish, > -----Original Message----- > From: Manish Narani <manish.narani@xilinx.com> > Sent: Sunday, June 30, 2019 10:30 PM > To: ulf.hansson@linaro.org; robh+dt@kernel.org; mark.rutland@arm.com; > heiko@sntech.de; Michal Simek <michals@xilinx.com>; > adrian.hunter@intel.com; christoph.muellner@theobroma-systems.com; > philipp.tomsich@theobroma-systems.com; viresh.kumar@linaro.org; > scott.branden@broadcom.com; ayaka@soulik.info; kernel@esmil.dk; > tony.xie@rock-chips.com; Rajan Vaja <RAJANV@xilinx.com>; Jolly Shah > <JOLLYS@xilinx.com>; Nava kishore Manne <navam@xilinx.com>; > mdf@kernel.org; Manish Narani <MNARANI@xilinx.com>; olof@lixom.net > Cc: linux-mmc@vger.kernel.org; devicetree@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > rockchip@lists.infradead.org > Subject: [PATCH v2 09/11] firmware: xilinx: Add SDIO Tap Delay APIs > > Add APIs for setting SDIO Tap Delays on ZynqMP platform. > > Signed-off-by: Manish Narani <manish.narani@xilinx.com> > --- > drivers/firmware/xilinx/zynqmp.c | 48 > ++++++++++++++++++++++++++++++++++++ > include/linux/firmware/xlnx-zynqmp.h | 15 ++++++++++- > 2 files changed, 62 insertions(+), 1 deletion(-) > > diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c > index fd3d837..b81f1be 100644 > --- a/drivers/firmware/xilinx/zynqmp.c > +++ b/drivers/firmware/xilinx/zynqmp.c > @@ -664,6 +664,52 @@ static int zynqmp_pm_set_requirement(const u32 > node, const u32 capabilities, > qos, ack, NULL); > } > > +/** > + * zynqmp_pm_sdio_out_setphase() - PM call to set clock output delays for SD > + * @device_id: Device ID of the SD controller > + * @tap_delay: Tap Delay value for output clock > + * > + * This API function is to be used for setting the clock output delays for SD > + * clock. > + * > + * Return: Returns status, either success or error+reason > + */ > +static int zynqmp_pm_sdio_out_setphase(u32 device_id, u8 tap_delay) > +{ > + u32 node_id = (!device_id) ? NODE_SD_0 : NODE_SD_1; > + int ret; > + > + ret = zynqmp_pm_ioctl(node_id, IOCTL_SET_SD_TAPDELAY, > + PM_TAPDELAY_OUTPUT, tap_delay, NULL); > + if (ret) > + pr_err("Error setting Output Tap Delay\n"); > + > + return ret; > +} > + > +/** > + * zynqmp_pm_sdio_in_setphase() - PM call to set clock input delays for SD > + * @device_id: Device ID of the SD controller > + * @tap_delay: Tap Delay value for input clock > + * > + * This API function is to be used for setting the clock input delays for SD > + * clock. > + * > + * Return: Returns status, either success or error+reason > + */ > +static int zynqmp_pm_sdio_in_setphase(u32 device_id, u8 tap_delay) > +{ > + u32 node_id = (!device_id) ? NODE_SD_0 : NODE_SD_1; > + int ret; > + > + ret = zynqmp_pm_ioctl(node_id, IOCTL_SET_SD_TAPDELAY, > + PM_TAPDELAY_INPUT, tap_delay, NULL); > + if (ret) > + pr_err("Error setting Input Tap Delay\n"); > + > + return ret; > +} > + > static const struct zynqmp_eemi_ops eemi_ops = { > .get_api_version = zynqmp_pm_get_api_version, > .get_chipid = zynqmp_pm_get_chipid, > @@ -687,6 +733,8 @@ static const struct zynqmp_eemi_ops eemi_ops = { > .set_requirement = zynqmp_pm_set_requirement, > .fpga_load = zynqmp_pm_fpga_load, > .fpga_get_status = zynqmp_pm_fpga_get_status, > + .sdio_out_setphase = zynqmp_pm_sdio_out_setphase, > + .sdio_in_setphase = zynqmp_pm_sdio_in_setphase, Are these eemi APIs? You are using ioctl eemi api to set the delay. Thanks, Jolly Shah > }; > > /** > diff --git a/include/linux/firmware/xlnx-zynqmp.h b/include/linux/firmware/xlnx- > zynqmp.h > index 1262ea6..d9b53e5 100644 > --- a/include/linux/firmware/xlnx-zynqmp.h > +++ b/include/linux/firmware/xlnx-zynqmp.h > @@ -92,7 +92,8 @@ enum pm_ret_status { > }; > > enum pm_ioctl_id { > - IOCTL_SET_PLL_FRAC_MODE = 8, > + IOCTL_SET_SD_TAPDELAY = 7, > + IOCTL_SET_PLL_FRAC_MODE, > IOCTL_GET_PLL_FRAC_MODE, > IOCTL_SET_PLL_FRAC_DATA, > IOCTL_GET_PLL_FRAC_DATA, > @@ -251,6 +252,16 @@ enum zynqmp_pm_request_ack { > ZYNQMP_PM_REQUEST_ACK_NON_BLOCKING, > }; > > +enum pm_node_id { > + NODE_SD_0 = 39, > + NODE_SD_1, > +}; > + > +enum tap_delay_type { > + PM_TAPDELAY_INPUT = 0, > + PM_TAPDELAY_OUTPUT, > +}; > + > /** > * struct zynqmp_pm_query_data - PM query data > * @qid: query ID > @@ -295,6 +306,8 @@ struct zynqmp_eemi_ops { > const u32 capabilities, > const u32 qos, > const enum zynqmp_pm_request_ack ack); > + int (*sdio_out_setphase)(u32 device_id, u8 tap_delay); > + int (*sdio_in_setphase)(u32 device_id, u8 tap_delay); > }; > > int zynqmp_pm_invoke_fn(u32 pm_api_id, u32 arg0, u32 arg1, > -- > 2.1.1
Hi Jolly, > -----Original Message----- > From: Jolly Shah > Sent: Monday, July 1, 2019 11:36 PM > To: Manish Narani <MNARANI@xilinx.com>; ulf.hansson@linaro.org; > robh+dt@kernel.org; mark.rutland@arm.com; heiko@sntech.de; Michal Simek > <michals@xilinx.com>; adrian.hunter@intel.com; > christoph.muellner@theobroma-systems.com; philipp.tomsich@theobroma- > systems.com; viresh.kumar@linaro.org; scott.branden@broadcom.com; > ayaka@soulik.info; kernel@esmil.dk; tony.xie@rock-chips.com; Rajan Vaja > <RAJANV@xilinx.com>; Nava kishore Manne <navam@xilinx.com>; > mdf@kernel.org; Manish Narani <MNARANI@xilinx.com>; olof@lixom.net > Cc: linux-mmc@vger.kernel.org; devicetree@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > rockchip@lists.infradead.org > Subject: RE: [PATCH v2 09/11] firmware: xilinx: Add SDIO Tap Delay APIs > > Hi Manish, > > > -----Original Message----- > > From: Manish Narani <manish.narani@xilinx.com> > > Sent: Sunday, June 30, 2019 10:30 PM > > To: ulf.hansson@linaro.org; robh+dt@kernel.org; mark.rutland@arm.com; > > heiko@sntech.de; Michal Simek <michals@xilinx.com>; > > adrian.hunter@intel.com; christoph.muellner@theobroma-systems.com; > > philipp.tomsich@theobroma-systems.com; viresh.kumar@linaro.org; > > scott.branden@broadcom.com; ayaka@soulik.info; kernel@esmil.dk; > > tony.xie@rock-chips.com; Rajan Vaja <RAJANV@xilinx.com>; Jolly Shah > > <JOLLYS@xilinx.com>; Nava kishore Manne <navam@xilinx.com>; > > mdf@kernel.org; Manish Narani <MNARANI@xilinx.com>; olof@lixom.net > > Cc: linux-mmc@vger.kernel.org; devicetree@vger.kernel.org; linux- > > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > > rockchip@lists.infradead.org > > Subject: [PATCH v2 09/11] firmware: xilinx: Add SDIO Tap Delay APIs > > > > Add APIs for setting SDIO Tap Delays on ZynqMP platform. > > > > Signed-off-by: Manish Narani <manish.narani@xilinx.com> > > --- > > drivers/firmware/xilinx/zynqmp.c | 48 > > ++++++++++++++++++++++++++++++++++++ > > include/linux/firmware/xlnx-zynqmp.h | 15 ++++++++++- > > 2 files changed, 62 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/firmware/xilinx/zynqmp.c > b/drivers/firmware/xilinx/zynqmp.c > > index fd3d837..b81f1be 100644 > > --- a/drivers/firmware/xilinx/zynqmp.c > > +++ b/drivers/firmware/xilinx/zynqmp.c > > @@ -664,6 +664,52 @@ static int zynqmp_pm_set_requirement(const u32 > > node, const u32 capabilities, > > qos, ack, NULL); > > } > > > > +/** > > + * zynqmp_pm_sdio_out_setphase() - PM call to set clock output delays for > SD > > + * @device_id: Device ID of the SD controller > > + * @tap_delay: Tap Delay value for output clock > > + * > > + * This API function is to be used for setting the clock output delays for SD > > + * clock. > > + * > > + * Return: Returns status, either success or error+reason > > + */ > > +static int zynqmp_pm_sdio_out_setphase(u32 device_id, u8 tap_delay) > > +{ > > + u32 node_id = (!device_id) ? NODE_SD_0 : NODE_SD_1; > > + int ret; > > + > > + ret = zynqmp_pm_ioctl(node_id, IOCTL_SET_SD_TAPDELAY, > > + PM_TAPDELAY_OUTPUT, tap_delay, NULL); > > + if (ret) > > + pr_err("Error setting Output Tap Delay\n"); > > + > > + return ret; > > +} > > + > > +/** > > + * zynqmp_pm_sdio_in_setphase() - PM call to set clock input delays for SD > > + * @device_id: Device ID of the SD controller > > + * @tap_delay: Tap Delay value for input clock > > + * > > + * This API function is to be used for setting the clock input delays for SD > > + * clock. > > + * > > + * Return: Returns status, either success or error+reason > > + */ > > +static int zynqmp_pm_sdio_in_setphase(u32 device_id, u8 tap_delay) > > +{ > > + u32 node_id = (!device_id) ? NODE_SD_0 : NODE_SD_1; > > + int ret; > > + > > + ret = zynqmp_pm_ioctl(node_id, IOCTL_SET_SD_TAPDELAY, > > + PM_TAPDELAY_INPUT, tap_delay, NULL); > > + if (ret) > > + pr_err("Error setting Input Tap Delay\n"); > > + > > + return ret; > > +} > > + > > static const struct zynqmp_eemi_ops eemi_ops = { > > .get_api_version = zynqmp_pm_get_api_version, > > .get_chipid = zynqmp_pm_get_chipid, > > @@ -687,6 +733,8 @@ static const struct zynqmp_eemi_ops eemi_ops = { > > .set_requirement = zynqmp_pm_set_requirement, > > .fpga_load = zynqmp_pm_fpga_load, > > .fpga_get_status = zynqmp_pm_fpga_get_status, > > + .sdio_out_setphase = zynqmp_pm_sdio_out_setphase, > > + .sdio_in_setphase = zynqmp_pm_sdio_in_setphase, > > Are these eemi APIs? You are using ioctl eemi api to set the delay. Yes, I am making these eemi APIs and calling ioctl API from these. This is to make the SD driver code more readable. Thanks, Manish
On 1/07/19 8:29 AM, Manish Narani wrote: > This patch series does the following: > - Reorganize the Clock Handling in Arasan SD driver > - Adds new sampling clock in Arasan SD driver > - Adds support to set Clock Delays in SD Arasan Driver > - Add SDIO Tap Delay handling in ZynqMP firmware driver > - Add support for ZynqMP Tap Delays setting in Arasan SD driver > > Changes in v2: > - Replaced the deprecated calls to clock framework APIs > - Added support for dev_clk_get() call to work for SD card clock > - Separated the clock data struct > - Fragmented the patch series in smaller patches to make it more > readable > > This patch series contains a DT patch, which I think should be there to > maintain the order of commits. > > Manish Narani (11): > dt-bindings: mmc: arasan: Update documentation for SD Card Clock > arm64: dts: rockchip: Add optional clock property indicating sdcard > clock > mmc: sdhci-of-arasan: Replace deprecated clk API calls > mmc: sdhci-of-arasan: Separate out clk related data to another > structure > dt-bindings: mmc: arasan: Update Documentation for the input clock > mmc: sdhci-of-arasan: Add sampling clock for a phy to use > dt-bindings: mmc: arasan: Add optional properties for Arasan SDHCI > mmc: sdhci-of-arasan: Add support to set clock phase delays for SD > firmware: xilinx: Add SDIO Tap Delay APIs > dt-bindings: mmc: arasan: Document 'xlnx,zynqmp-8.9a' controller > mmc: sdhci-of-arasan: Add support for ZynqMP Platform Tap Delays Setup > > .../devicetree/bindings/mmc/arasan,sdhci.txt | 49 ++- > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 4 +- > drivers/firmware/xilinx/zynqmp.c | 48 +++ > drivers/mmc/host/sdhci-of-arasan.c | 453 ++++++++++++++++++++- > include/linux/firmware/xlnx-zynqmp.h | 15 +- > 5 files changed, 540 insertions(+), 29 deletions(-) > For SDHCI: Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Ping! > -----Original Message----- > From: Manish Narani <manish.narani@xilinx.com> > Sent: Monday, July 1, 2019 11:00 AM > To: ulf.hansson@linaro.org; robh+dt@kernel.org; mark.rutland@arm.com; > heiko@sntech.de; Michal Simek <michals@xilinx.com>; > adrian.hunter@intel.com; christoph.muellner@theobroma-systems.com; > philipp.tomsich@theobroma-systems.com; viresh.kumar@linaro.org; > scott.branden@broadcom.com; ayaka@soulik.info; kernel@esmil.dk; > tony.xie@rock-chips.com; Rajan Vaja <RAJANV@xilinx.com>; Jolly Shah > <JOLLYS@xilinx.com>; Nava kishore Manne <navam@xilinx.com>; > mdf@kernel.org; Manish Narani <MNARANI@xilinx.com>; olof@lixom.net > Cc: linux-mmc@vger.kernel.org; devicetree@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > rockchip@lists.infradead.org > Subject: [PATCH v2 00/11] Arasan SDHCI enhancements and ZynqMP Tap > Delays Handling > > This patch series does the following: > - Reorganize the Clock Handling in Arasan SD driver > - Adds new sampling clock in Arasan SD driver > - Adds support to set Clock Delays in SD Arasan Driver > - Add SDIO Tap Delay handling in ZynqMP firmware driver > - Add support for ZynqMP Tap Delays setting in Arasan SD driver > > Changes in v2: > - Replaced the deprecated calls to clock framework APIs > - Added support for dev_clk_get() call to work for SD card clock > - Separated the clock data struct > - Fragmented the patch series in smaller patches to make it more > readable > > This patch series contains a DT patch, which I think should be there to > maintain the order of commits. > > Manish Narani (11): > dt-bindings: mmc: arasan: Update documentation for SD Card Clock > arm64: dts: rockchip: Add optional clock property indicating sdcard > clock > mmc: sdhci-of-arasan: Replace deprecated clk API calls > mmc: sdhci-of-arasan: Separate out clk related data to another > structure > dt-bindings: mmc: arasan: Update Documentation for the input clock > mmc: sdhci-of-arasan: Add sampling clock for a phy to use > dt-bindings: mmc: arasan: Add optional properties for Arasan SDHCI > mmc: sdhci-of-arasan: Add support to set clock phase delays for SD > firmware: xilinx: Add SDIO Tap Delay APIs > dt-bindings: mmc: arasan: Document 'xlnx,zynqmp-8.9a' controller > mmc: sdhci-of-arasan: Add support for ZynqMP Platform Tap Delays Setup > > .../devicetree/bindings/mmc/arasan,sdhci.txt | 49 ++- > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 4 +- > drivers/firmware/xilinx/zynqmp.c | 48 +++ > drivers/mmc/host/sdhci-of-arasan.c | 453 ++++++++++++++++++++- > include/linux/firmware/xlnx-zynqmp.h | 15 +- > 5 files changed, 540 insertions(+), 29 deletions(-) > > -- > 2.1.1
Gentle Ping! > -----Original Message----- > From: Manish Narani > Sent: Monday, July 15, 2019 12:46 PM > To: Manish Narani <MNARANI@xilinx.com>; ulf.hansson@linaro.org; > robh+dt@kernel.org; mark.rutland@arm.com; heiko@sntech.de; Michal Simek > <michals@xilinx.com>; adrian.hunter@intel.com; > christoph.muellner@theobroma-systems.com; philipp.tomsich@theobroma- > systems.com; viresh.kumar@linaro.org; scott.branden@broadcom.com; > ayaka@soulik.info; kernel@esmil.dk; tony.xie@rock-chips.com; > mdf@kernel.org; olof@lixom.net > Cc: linux-mmc@vger.kernel.org; devicetree@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > rockchip@lists.infradead.org > Subject: RE: [PATCH v2 00/11] Arasan SDHCI enhancements and ZynqMP Tap > Delays Handling > > Ping! > > > -----Original Message----- > > From: Manish Narani <manish.narani@xilinx.com> > > Sent: Monday, July 1, 2019 11:00 AM > > To: ulf.hansson@linaro.org; robh+dt@kernel.org; mark.rutland@arm.com; > > heiko@sntech.de; Michal Simek <michals@xilinx.com>; > > adrian.hunter@intel.com; christoph.muellner@theobroma-systems.com; > > philipp.tomsich@theobroma-systems.com; viresh.kumar@linaro.org; > > scott.branden@broadcom.com; ayaka@soulik.info; kernel@esmil.dk; > > tony.xie@rock-chips.com; Rajan Vaja <RAJANV@xilinx.com>; Jolly Shah > > <JOLLYS@xilinx.com>; Nava kishore Manne <navam@xilinx.com>; > > mdf@kernel.org; Manish Narani <MNARANI@xilinx.com>; olof@lixom.net > > Cc: linux-mmc@vger.kernel.org; devicetree@vger.kernel.org; linux- > > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > > rockchip@lists.infradead.org > > Subject: [PATCH v2 00/11] Arasan SDHCI enhancements and ZynqMP Tap > > Delays Handling > > > > This patch series does the following: > > - Reorganize the Clock Handling in Arasan SD driver > > - Adds new sampling clock in Arasan SD driver > > - Adds support to set Clock Delays in SD Arasan Driver > > - Add SDIO Tap Delay handling in ZynqMP firmware driver > > - Add support for ZynqMP Tap Delays setting in Arasan SD driver > > > > Changes in v2: > > - Replaced the deprecated calls to clock framework APIs > > - Added support for dev_clk_get() call to work for SD card clock > > - Separated the clock data struct > > - Fragmented the patch series in smaller patches to make it more > > readable > > > > This patch series contains a DT patch, which I think should be there to > > maintain the order of commits. > > > > Manish Narani (11): > > dt-bindings: mmc: arasan: Update documentation for SD Card Clock > > arm64: dts: rockchip: Add optional clock property indicating sdcard > > clock > > mmc: sdhci-of-arasan: Replace deprecated clk API calls > > mmc: sdhci-of-arasan: Separate out clk related data to another > > structure > > dt-bindings: mmc: arasan: Update Documentation for the input clock > > mmc: sdhci-of-arasan: Add sampling clock for a phy to use > > dt-bindings: mmc: arasan: Add optional properties for Arasan SDHCI > > mmc: sdhci-of-arasan: Add support to set clock phase delays for SD > > firmware: xilinx: Add SDIO Tap Delay APIs > > dt-bindings: mmc: arasan: Document 'xlnx,zynqmp-8.9a' controller > > mmc: sdhci-of-arasan: Add support for ZynqMP Platform Tap Delays Setup > > > > .../devicetree/bindings/mmc/arasan,sdhci.txt | 49 ++- > > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 4 +- > > drivers/firmware/xilinx/zynqmp.c | 48 +++ > > drivers/mmc/host/sdhci-of-arasan.c | 453 > ++++++++++++++++++++- > > include/linux/firmware/xlnx-zynqmp.h | 15 +- > > 5 files changed, 540 insertions(+), 29 deletions(-) > > > > -- > > 2.1.1
This patch series does the following: - Reorganize the Clock Handling in Arasan SD driver - Adds new sampling clock in Arasan SD driver - Adds support to set Clock Delays in SD Arasan Driver - Add SDIO Tap Delay handling in ZynqMP firmware driver - Add support for ZynqMP Tap Delays setting in Arasan SD driver Changes in v2: - Replaced the deprecated calls to clock framework APIs - Added support for dev_clk_get() call to work for SD card clock - Separated the clock data struct - Fragmented the patch series in smaller patches to make it more readable This patch series contains a DT patch, which I think should be there to maintain the order of commits. Manish Narani (11): dt-bindings: mmc: arasan: Update documentation for SD Card Clock arm64: dts: rockchip: Add optional clock property indicating sdcard clock mmc: sdhci-of-arasan: Replace deprecated clk API calls mmc: sdhci-of-arasan: Separate out clk related data to another structure dt-bindings: mmc: arasan: Update Documentation for the input clock mmc: sdhci-of-arasan: Add sampling clock for a phy to use dt-bindings: mmc: arasan: Add optional properties for Arasan SDHCI mmc: sdhci-of-arasan: Add support to set clock phase delays for SD firmware: xilinx: Add SDIO Tap Delay APIs dt-bindings: mmc: arasan: Document 'xlnx,zynqmp-8.9a' controller mmc: sdhci-of-arasan: Add support for ZynqMP Platform Tap Delays Setup .../devicetree/bindings/mmc/arasan,sdhci.txt | 49 ++- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 4 +- drivers/firmware/xilinx/zynqmp.c | 48 +++ drivers/mmc/host/sdhci-of-arasan.c | 453 ++++++++++++++++++++- include/linux/firmware/xlnx-zynqmp.h | 15 +- 5 files changed, 540 insertions(+), 29 deletions(-)