| Message ID | 1303293448-13168-1-git-send-email-daniel@gaisler.com |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
On Wed, Apr 20, 2011 at 11:57:28AM +0200, Daniel Hellstrom wrote: > Signed-off-by: Daniel Hellstrom <daniel@gaisler.com> > --- > arch/sparc/include/asm/pgtable_32.h | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > I guess this is the same warnign that has annoyed me. In general always include the warning that you fix, so we can google for it etc. Sam -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Daniel Hellstrom <daniel@gaisler.com> Date: Wed, 20 Apr 2011 11:57:28 +0200 > Signed-off-by: Daniel Hellstrom <daniel@gaisler.com> I find it amazing that this patch builds, yet with current tools it does. It seems that some time in the recent past, binutils started accepting constants in assembler that have type tag suffixes such as "UL". But I know that older binutils do not accept this, and we use VMALLOC_{START,END} in arch/sparc/kernel/entry.S So please use the mechanism we have in place to handle this problem, include linux/const.h and use the AC() macros as we do in pgtable_64.h for this. Thanks. -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/sparc/include/asm/pgtable_32.h b/arch/sparc/include/asm/pgtable_32.h index 303bd4d..5aa2e9c 100644 --- a/arch/sparc/include/asm/pgtable_32.h +++ b/arch/sparc/include/asm/pgtable_32.h @@ -456,9 +456,9 @@ extern int io_remap_pfn_range(struct vm_area_struct *vma, #endif /* !(__ASSEMBLY__) */ -#define VMALLOC_START 0xfe600000 +#define VMALLOC_START 0xfe600000UL /* XXX Alter this when I get around to fixing sun4c - Anton */ -#define VMALLOC_END 0xffc00000 +#define VMALLOC_END 0xffc00000UL /* We provide our own get_unmapped_area to cope with VA holes for userland */
Signed-off-by: Daniel Hellstrom <daniel@gaisler.com> --- arch/sparc/include/asm/pgtable_32.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)