diff mbox series

[1/7] rtc: jz4740: set range

Message ID 20190418100045.29288-1-alexandre.belloni@bootlin.com
State Superseded
Headers show
Series [1/7] rtc: jz4740: set range | expand

Commit Message

Alexandre Belloni April 18, 2019, 10 a.m. UTC
RTC_SEC is a 32-bit seconds counter.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---
 drivers/rtc/rtc-jz4740.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

Comments

Mathieu Malaterre April 26, 2019, 2:31 p.m. UTC | #1
On Thu, Apr 18, 2019 at 12:01 PM Alexandre Belloni
<alexandre.belloni@bootlin.com> wrote:
>
> RTC_SEC is a 32-bit seconds counter.

For the entire series:

Tested-by: Mathieu Malaterre <malat@debian.org>

Arch is MIPS Creator CI20

>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
>  drivers/rtc/rtc-jz4740.c | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rtc/rtc-jz4740.c b/drivers/rtc/rtc-jz4740.c
> index d0a891777f44..079469627bd7 100644
> --- a/drivers/rtc/rtc-jz4740.c
> +++ b/drivers/rtc/rtc-jz4740.c
> @@ -348,10 +348,18 @@ static int jz4740_rtc_probe(struct platform_device *pdev)
>
>         device_init_wakeup(&pdev->dev, 1);
>
> -       rtc->rtc = devm_rtc_device_register(&pdev->dev, pdev->name,
> -                                       &jz4740_rtc_ops, THIS_MODULE);
> +       rtc->rtc = devm_rtc_allocate_device(&pdev->dev);
>         if (IS_ERR(rtc->rtc)) {
>                 ret = PTR_ERR(rtc->rtc);
> +               dev_err(&pdev->dev, "Failed to allocate rtc device: %d\n", ret);
> +               return ret;
> +       }
> +
> +       rtc->rtc->ops = &jz4740_rtc_ops;
> +       rtc->rtc->range_max = U32_MAX;
> +
> +       ret = rtc_register_device(rtc->rtc);
> +       if (ret) {
>                 dev_err(&pdev->dev, "Failed to register rtc device: %d\n", ret);
>                 return ret;
>         }
> --
> 2.20.1
>
diff mbox series

Patch

diff --git a/drivers/rtc/rtc-jz4740.c b/drivers/rtc/rtc-jz4740.c
index d0a891777f44..079469627bd7 100644
--- a/drivers/rtc/rtc-jz4740.c
+++ b/drivers/rtc/rtc-jz4740.c
@@ -348,10 +348,18 @@  static int jz4740_rtc_probe(struct platform_device *pdev)
 
 	device_init_wakeup(&pdev->dev, 1);
 
-	rtc->rtc = devm_rtc_device_register(&pdev->dev, pdev->name,
-					&jz4740_rtc_ops, THIS_MODULE);
+	rtc->rtc = devm_rtc_allocate_device(&pdev->dev);
 	if (IS_ERR(rtc->rtc)) {
 		ret = PTR_ERR(rtc->rtc);
+		dev_err(&pdev->dev, "Failed to allocate rtc device: %d\n", ret);
+		return ret;
+	}
+
+	rtc->rtc->ops = &jz4740_rtc_ops;
+	rtc->rtc->range_max = U32_MAX;
+
+	ret = rtc_register_device(rtc->rtc);
+	if (ret) {
 		dev_err(&pdev->dev, "Failed to register rtc device: %d\n", ret);
 		return ret;
 	}