| Message ID | 1302747032.3981.181.camel@sli10-conroe |
|---|---|
| State | Accepted, archived |
| Headers | show |
On Thu, Apr 14, 2011 at 10:10:32AM +0800, Shaohua Li wrote: > percpu_counter_sum_positive never returns negative. > > Signed-off-by: Shaohua Li <shaohua.li@intel.com> Acked-by: Tejun Heo <tj@kernel.org> Ted, can you please pick this up? Thanks.
On Fri, Apr 15, 2011 at 01:16:10PM +0900, Tejun Heo wrote: > On Thu, Apr 14, 2011 at 10:10:32AM +0800, Shaohua Li wrote: > > percpu_counter_sum_positive never returns negative. > > > > Signed-off-by: Shaohua Li <shaohua.li@intel.com> > > Acked-by: Tejun Heo <tj@kernel.org> > > Ted, can you please pick this up? Added to the ext4 tree. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Index: linux/fs/ext4/balloc.c =================================================================== --- linux.orig/fs/ext4/balloc.c 2011-04-12 16:22:59.000000000 +0800 +++ linux/fs/ext4/balloc.c 2011-04-13 13:23:01.000000000 +0800 @@ -507,11 +507,6 @@ static int ext4_has_free_blocks(struct e EXT4_FREEBLOCKS_WATERMARK) { free_blocks = percpu_counter_sum_positive(fbc); dirty_blocks = percpu_counter_sum_positive(dbc); - if (dirty_blocks < 0) { - printk(KERN_CRIT "Dirty block accounting " - "went wrong %lld\n", - (long long)dirty_blocks); - } } /* Check whether we have space after * accounting for current dirty blocks & root reserved blocks.
percpu_counter_sum_positive never returns negative. Signed-off-by: Shaohua Li <shaohua.li@intel.com> --- fs/ext4/balloc.c | 5 ----- 1 file changed, 5 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html