| Message ID | 4D9C6FFF.2060807@msgid.tls.msk.ru |
|---|---|
| State | New |
| Headers | show |
On Wed, Apr 6, 2011 at 2:51 PM, Michael Tokarev <mjt@tls.msk.ru> wrote: > Resending (previous attempt was at Wed, 30 Mar 2011). > > In previous life qdev_init_nofail() used to call hw_error() which > did register dump and other scary things. Now it calls > error_report() and does a regular exit(1). Fix the comment > to match reality. > > Signed-off-by: Michael Tokarev <mjt@tls.msk.ru> > --- > hw/qdev.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Merged into my trivial-patches tree: http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivial-patches I will send a pull request so this can be merged into qemu.git. The trivial patches tree is a new thing that was proposed recently so here's the background. The idea is to collect small patches that are easy to review and apply. A single pull request is then sent which a qemu.git maintainer will apply. This should prevent patches slipping through the cracks and lingering on the mailing list. The trivial patches team was announced in yesterdays community call minutes: http://www.mail-archive.com/kvm@vger.kernel.org/msg51601.html If you want to know more: http://wiki.qemu.org/Contribute/TrivialPatches Stefan
diff --git a/hw/qdev.c b/hw/qdev.c index 1aa1ea0..2f4846e 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -358,7 +358,7 @@ int qdev_simple_unplug_cb(DeviceState *dev) return 0; } -/* Like qdev_init(), but terminate program via hw_error() instead of +/* Like qdev_init(), but terminate program via error_report() instead of returning an error value. This is okay during machine creation. Don't use for hotplug, because there callers need to recover from failure. Exception: if you know the device's init() callback can't --
Resending (previous attempt was at Wed, 30 Mar 2011). In previous life qdev_init_nofail() used to call hw_error() which did register dump and other scary things. Now it calls error_report() and does a regular exit(1). Fix the comment to match reality. Signed-off-by: Michael Tokarev <mjt@tls.msk.ru> --- hw/qdev.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) 1.7.2.5