Message ID | 1301474416-8202-2-git-send-email-dedekind1@gmail.com |
---|---|
State | Accepted |
Commit | 81354de3d8691c2dedcc686cd2c167819ff0df10 |
Headers | show |
On Wed, 30 Mar 2011 11:40:15 +0300 Artem Bityutskiy wrote: > From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com> > > All UBIFS needs is to make sure we stacktraces when UBIFS debugging > is enabled. It is enough to select KALLSYMS for this, KALLSYMS_ALL > is not necessary. Moreover, Randy Dunlap reported that UBIFS causes > the following Kconfig dependency warning: > > warning: (UBIFS_FS_DEBUG && LOCKDEP && LATENCYTOP) selects KALLSYMS_ALL > which has unmet direct dependencies (DEBUG_KERNEL && KALLSYMS) > > The reason is that KALLSYMS_ALL requires DEBUG_KERNEL and KALLSYMS, so > ideally, to select KALLSYMS_ALL we'd need to select DEBUG_KERNEL and > KALLSYMS first. > > This seems to be too much to select. The easiest way to go is to forget > about KALLSYMS_ALL and just select KALLSYMS when UBIFS debugging is > enabled - that should be enough for stackdumps. > > Reported-by: Randy Dunlap <randy.dunlap@oracle.com> > Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com> > --- > fs/ubifs/Kconfig | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/fs/ubifs/Kconfig b/fs/ubifs/Kconfig > index d744090..f8b0160 100644 > --- a/fs/ubifs/Kconfig > +++ b/fs/ubifs/Kconfig > @@ -47,7 +47,7 @@ config UBIFS_FS_DEBUG > bool "Enable debugging support" > depends on UBIFS_FS > select DEBUG_FS > - select KALLSYMS_ALL > + select KALLSYMS > help > This option enables UBIFS debugging support. It makes sure various > assertions, self-checks, debugging messages and test modes are compiled > -- Acked-by: Randy Dunlap <randy.dunlap@oracle.com> Thanks. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***
On Wed, 2011-03-30 at 15:41 -0700, Randy Dunlap wrote: > > diff --git a/fs/ubifs/Kconfig b/fs/ubifs/Kconfig > > index d744090..f8b0160 100644 > > --- a/fs/ubifs/Kconfig > > +++ b/fs/ubifs/Kconfig > > @@ -47,7 +47,7 @@ config UBIFS_FS_DEBUG > > bool "Enable debugging support" > > depends on UBIFS_FS > > select DEBUG_FS > > - select KALLSYMS_ALL > > + select KALLSYMS > > help > > This option enables UBIFS debugging support. It makes sure various > > assertions, self-checks, debugging messages and test modes are compiled > > -- > > Acked-by: Randy Dunlap <randy.dunlap@oracle.com> Pushed to UBI / UBIFS trees. These will show-up in linux-next a bit later (around -rc2, if it will be usable enough), and then I'll send this to Linus.
diff --git a/fs/ubifs/Kconfig b/fs/ubifs/Kconfig index d744090..f8b0160 100644 --- a/fs/ubifs/Kconfig +++ b/fs/ubifs/Kconfig @@ -47,7 +47,7 @@ config UBIFS_FS_DEBUG bool "Enable debugging support" depends on UBIFS_FS select DEBUG_FS - select KALLSYMS_ALL + select KALLSYMS help This option enables UBIFS debugging support. It makes sure various assertions, self-checks, debugging messages and test modes are compiled