diff mbox series

[next] i2c: tegra: change phrasing, "fallbacking" to "falling back"

Message ID 20190215153126.18575-1-colin.king@canonical.com
State Deferred
Headers show
Series [next] i2c: tegra: change phrasing, "fallbacking" to "falling back" | expand

Commit Message

Colin Ian King Feb. 15, 2019, 3:31 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

The phrasing in two dev_err messages is using fallbacking which
os less understandable than "falling back", so fix this up.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/i2c/busses/i2c-tegra.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Thierry Reding Feb. 15, 2019, 3:32 p.m. UTC | #1 
On Fri, Feb 15, 2019 at 03:31:26PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The phrasing in two dev_err messages is using fallbacking which
> os less understandable than "falling back", so fix this up.

os -> is, otherwise:

Acked-by: Thierry Reding <treding@nvidia.com>
Colin Ian King Feb. 15, 2019, 3:33 p.m. UTC | #2 
On 15/02/2019 15:32, Thierry Reding wrote:
> On Fri, Feb 15, 2019 at 03:31:26PM +0000, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> The phrasing in two dev_err messages is using fallbacking which
>> os less understandable than "falling back", so fix this up.
> 
> os -> is, otherwise:

Oops, can that be fixed up when it's applied.

> 
> Acked-by: Thierry Reding <treding@nvidia.com>
>
Wolfram Sang Feb. 15, 2019, 3:38 p.m. UTC | #3 
On Fri, Feb 15, 2019 at 03:33:58PM +0000, Colin Ian King wrote:
> On 15/02/2019 15:32, Thierry Reding wrote:
> > On Fri, Feb 15, 2019 at 03:31:26PM +0000, Colin King wrote:
> >> From: Colin Ian King <colin.king@canonical.com>
> >>
> >> The phrasing in two dev_err messages is using fallbacking which
> >> os less understandable than "falling back", so fix this up.
> > 
> > os -> is, otherwise:
> 
> Oops, can that be fixed up when it's applied.

Yes.
Wolfram Sang Feb. 15, 2019, 9:42 p.m. UTC | #4 
On Fri, Feb 15, 2019 at 03:31:26PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The phrasing in two dev_err messages is using fallbacking which
> os less understandable than "falling back", so fix this up.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied to for-next, thanks!
diff mbox series

Patch

diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
index a4cd79c9f7a7..5a403c3ab66c 100644
--- a/drivers/i2c/busses/i2c-tegra.c
+++ b/drivers/i2c/busses/i2c-tegra.c
@@ -452,7 +452,7 @@  static int tegra_i2c_init_dma(struct tegra_i2c_dev *i2c_dev)
 	tegra_i2c_release_dma(i2c_dev);
 	if (err != -EPROBE_DEFER) {
 		dev_err(i2c_dev->dev, "cannot use DMA: %d\n", err);
-		dev_err(i2c_dev->dev, "fallbacking to PIO\n");
+		dev_err(i2c_dev->dev, "falling back to PIO\n");
 		return 0;
 	}
 
@@ -965,7 +965,7 @@  static void tegra_i2c_config_fifo_trig(struct tegra_i2c_dev *i2c_dev,
 		if (ret < 0) {
 			dev_err(i2c_dev->dev, "DMA slave config failed: %d\n",
 				ret);
-			dev_err(i2c_dev->dev, "fallbacking to PIO\n");
+			dev_err(i2c_dev->dev, "falling back to PIO\n");
 			tegra_i2c_release_dma(i2c_dev);
 			i2c_dev->is_curr_dma_xfer = false;
 		} else {