| Message ID | 20190211132342.31009-3-thomas.petazzoni@bootlin.com |
|---|---|
| State | Deferred |
| Headers | show |
| Series | mmc: Introduce support for WP GPIO in the core SDHCI | expand |
On 11/02/19 3:23 PM, Thomas Petazzoni wrote: > The SDHCI core is now properly checking for the state of a WP GPIO, > so there is no longer any need for the sdhci-omap code to implement > ->get_ro() using mmc_gpio_get_ro(). > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com> > Reviewed-by: Thierry Reding <treding@nvidia.com> Acked-by: Adrian Hunter <adrian.hunter@intel.com> > --- > Changes since v1: > - Added Reviewed-by from Thierry Reding > - Fix typo in commit log s/know/now/ noticed by Thierry Reding > > Note: this patch has only been compiled tested, as I don't have the > hardware to test it. > --- > drivers/mmc/host/sdhci-omap.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c > index d264391616f9..c2a28930086f 100644 > --- a/drivers/mmc/host/sdhci-omap.c > +++ b/drivers/mmc/host/sdhci-omap.c > @@ -987,7 +987,6 @@ static int sdhci_omap_probe(struct platform_device *pdev) > goto err_put_sync; > } > > - host->mmc_host_ops.get_ro = mmc_gpio_get_ro; > host->mmc_host_ops.start_signal_voltage_switch = > sdhci_omap_start_signal_voltage_switch; > host->mmc_host_ops.set_ios = sdhci_omap_set_ios; >
On 12/02/19 1:41 PM, Adrian Hunter wrote: > On 11/02/19 3:23 PM, Thomas Petazzoni wrote: >> The SDHCI core is now properly checking for the state of a WP GPIO, >> so there is no longer any need for the sdhci-omap code to implement >> ->get_ro() using mmc_gpio_get_ro(). >> >> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com> >> Reviewed-by: Thierry Reding <treding@nvidia.com> > > Acked-by: Adrian Hunter <adrian.hunter@intel.com> Acked-by: Kishon Vijay Abraham I <kishon@ti.com> > >> --- >> Changes since v1: >> - Added Reviewed-by from Thierry Reding >> - Fix typo in commit log s/know/now/ noticed by Thierry Reding >> >> Note: this patch has only been compiled tested, as I don't have the >> hardware to test it. >> --- >> drivers/mmc/host/sdhci-omap.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c >> index d264391616f9..c2a28930086f 100644 >> --- a/drivers/mmc/host/sdhci-omap.c >> +++ b/drivers/mmc/host/sdhci-omap.c >> @@ -987,7 +987,6 @@ static int sdhci_omap_probe(struct platform_device *pdev) >> goto err_put_sync; >> } >> >> - host->mmc_host_ops.get_ro = mmc_gpio_get_ro; >> host->mmc_host_ops.start_signal_voltage_switch = >> sdhci_omap_start_signal_voltage_switch; >> host->mmc_host_ops.set_ios = sdhci_omap_set_ios; >> >
diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c index d264391616f9..c2a28930086f 100644 --- a/drivers/mmc/host/sdhci-omap.c +++ b/drivers/mmc/host/sdhci-omap.c @@ -987,7 +987,6 @@ static int sdhci_omap_probe(struct platform_device *pdev) goto err_put_sync; } - host->mmc_host_ops.get_ro = mmc_gpio_get_ro; host->mmc_host_ops.start_signal_voltage_switch = sdhci_omap_start_signal_voltage_switch; host->mmc_host_ops.set_ios = sdhci_omap_set_ios;