| Message ID | 20190114131841.1932-1-maximmi@mellanox.com |
|---|---|
| Headers | show |
| Series | AF_PACKET transport_offset fix | expand |
I just realized that the window is still closed. I'll resubmit it when it opens. Sorry for the extra noise. > -----Original Message----- > From: Maxim Mikityanskiy > Sent: 14 January, 2019 15:19 > To: David S. Miller <davem@davemloft.net>; Saeed Mahameed > <saeedm@mellanox.com>; Willem de Bruijn <willemb@google.com>; Jason Wang > <jasowang@redhat.com>; Eric Dumazet <edumazet@google.com> > Cc: netdev@vger.kernel.org; Eran Ben Elisha <eranbe@mellanox.com>; Tariq > Toukan <tariqt@mellanox.com>; Maxim Mikityanskiy <maximmi@mellanox.com> > Subject: [PATCH 0/7] AF_PACKET transport_offset fix > > This patch series contains the implementation of the RFC that was posted > on this mailing list previously: > https://www.spinics.net/lists/netdev/msg541709.html > > It fixes having incorrect skb->transport_header values in cases when > dissect fails. Having correct values set by the kernel fixes mlx5 > operation and allows to remove some unnecessary code flows in mlx5. > > Maxim Mikityanskiy (7): > net: Don't set transport offset to invalid value > net: Introduce parse_protocol header_ops callback > net/ethernet: Add parse_protocol header_ops support > net/packet: Ask driver for protocol if not provided by user > net/packet: Remove redundant skb->protocol set > net/mlx5e: Remove the wrong assumption about transport offset > net/mlx5e: Trust kernel regarding transport offset > > .../net/ethernet/mellanox/mlx5/core/en_tx.c | 15 ++--------- > drivers/net/tap.c | 4 +-- > drivers/net/tun.c | 4 +-- > drivers/net/xen-netback/netback.c | 19 ++++++++------ > include/linux/etherdevice.h | 1 + > include/linux/netdevice.h | 10 +++++++ > include/linux/skbuff.h | 14 +++++----- > net/ethernet/eth.c | 13 ++++++++++ > net/packet/af_packet.c | 26 +++++++++---------- > 9 files changed, 60 insertions(+), 46 deletions(-) > > -- > 2.19.1
From my perspective, after the discussion we had with Willem, the current version of this series can be merged to net-next. Willem, do you approve it? Thanks for reviewing! > -----Original Message----- > From: Maxim Mikityanskiy > Sent: 14 January, 2019 15:19 > To: David S. Miller <davem@davemloft.net>; Saeed Mahameed > <saeedm@mellanox.com>; Willem de Bruijn <willemb@google.com>; Jason Wang > <jasowang@redhat.com>; Eric Dumazet <edumazet@google.com> > Cc: netdev@vger.kernel.org; Eran Ben Elisha <eranbe@mellanox.com>; Tariq > Toukan <tariqt@mellanox.com>; Maxim Mikityanskiy <maximmi@mellanox.com> > Subject: [PATCH 0/7] AF_PACKET transport_offset fix > > This patch series contains the implementation of the RFC that was posted > on this mailing list previously: > https://www.spinics.net/lists/netdev/msg541709.html > > It fixes having incorrect skb->transport_header values in cases when > dissect fails. Having correct values set by the kernel fixes mlx5 > operation and allows to remove some unnecessary code flows in mlx5. > > Maxim Mikityanskiy (7): > net: Don't set transport offset to invalid value > net: Introduce parse_protocol header_ops callback > net/ethernet: Add parse_protocol header_ops support > net/packet: Ask driver for protocol if not provided by user > net/packet: Remove redundant skb->protocol set > net/mlx5e: Remove the wrong assumption about transport offset > net/mlx5e: Trust kernel regarding transport offset > > .../net/ethernet/mellanox/mlx5/core/en_tx.c | 15 ++--------- > drivers/net/tap.c | 4 +-- > drivers/net/tun.c | 4 +-- > drivers/net/xen-netback/netback.c | 19 ++++++++------ > include/linux/etherdevice.h | 1 + > include/linux/netdevice.h | 10 +++++++ > include/linux/skbuff.h | 14 +++++----- > net/ethernet/eth.c | 13 ++++++++++ > net/packet/af_packet.c | 26 +++++++++---------- > 9 files changed, 60 insertions(+), 46 deletions(-) > > -- > 2.19.1
On Wed, Jan 23, 2019 at 5:19 AM Maxim Mikityanskiy <maximmi@mellanox.com> wrote: > > From my perspective, after the discussion we had with Willem, the > current version of this series can be merged to net-next. net-next has moved forward. The patchset as is no longer applies cleanly. > Willem, do you approve it? > > Thanks for reviewing! > > > -----Original Message----- > > From: Maxim Mikityanskiy > > Sent: 14 January, 2019 15:19 > > To: David S. Miller <davem@davemloft.net>; Saeed Mahameed > > <saeedm@mellanox.com>; Willem de Bruijn <willemb@google.com>; Jason Wang > > <jasowang@redhat.com>; Eric Dumazet <edumazet@google.com> > > Cc: netdev@vger.kernel.org; Eran Ben Elisha <eranbe@mellanox.com>; Tariq > > Toukan <tariqt@mellanox.com>; Maxim Mikityanskiy <maximmi@mellanox.com> > > Subject: [PATCH 0/7] AF_PACKET transport_offset fix > > > > This patch series contains the implementation of the RFC that was posted > > on this mailing list previously: > > https://www.spinics.net/lists/netdev/msg541709.html > > > > It fixes having incorrect skb->transport_header values in cases when > > dissect fails. Having correct values set by the kernel fixes mlx5 > > operation and allows to remove some unnecessary code flows in mlx5. > > > > Maxim Mikityanskiy (7): > > net: Don't set transport offset to invalid value > > net: Introduce parse_protocol header_ops callback > > net/ethernet: Add parse_protocol header_ops support > > net/packet: Ask driver for protocol if not provided by user > > net/packet: Remove redundant skb->protocol set > > net/mlx5e: Remove the wrong assumption about transport offset > > net/mlx5e: Trust kernel regarding transport offset > > > > .../net/ethernet/mellanox/mlx5/core/en_tx.c | 15 ++--------- > > drivers/net/tap.c | 4 +-- > > drivers/net/tun.c | 4 +-- > > drivers/net/xen-netback/netback.c | 19 ++++++++------ > > include/linux/etherdevice.h | 1 + > > include/linux/netdevice.h | 10 +++++++ > > include/linux/skbuff.h | 14 +++++----- > > net/ethernet/eth.c | 13 ++++++++++ > > net/packet/af_packet.c | 26 +++++++++---------- > > 9 files changed, 60 insertions(+), 46 deletions(-) > > > > -- > > 2.19.1 >