| Message ID | 20181030132401.11613-1-stephen@that.guru |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/2] travis: Stop testing PostgreSQL 11 | expand |
Stephen Finucane <stephen@that.guru> writes: > Travis seems to be doing something really weird with PG11 since it was > released a few weeks ago. This is currently breaking our CI and can't > continue. It doesn't seem possible to mark this as an expected failure > so simply remove it. We can re-add this once Travis gains proper support > for this version via their addons. I'm also happy to re-add it if the original approach starts working again, e.g. if the postgres people fix their packaging, but I definitely agree that this is the most sensible step at this point. > Acked-by: Daniel Axtens <dja@axtens.net> > Signed-off-by: Stephen Finucane <stephen@that.guru> > Cc: Daniel Black <daniel@linux.ibm.com> > --- > .travis.yml | 21 --------------------- > 1 file changed, 21 deletions(-) > > diff --git a/.travis.yml b/.travis.yml > index bb7ff142..64355450 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -47,27 +47,6 @@ matrix: > sudo: true > before_install: > - sudo -u postgres psql -c "grant ALL on DATABASE postgres to travis WITH GRANT OPTION;" > - - env: > - - PGPORT=5433 > - - PW_TEST_DB_HOST="" > - - PW_TEST_DB_PORT=5433 > - - PW_TEST_DB_TYPE=postgres > - - PW_TEST_DB_USER=travis > - python: 3.6 > - dist: trusty > - addons: > - postgresql: "11" > - apt: > - sources: > - - sourceline: 'deb http://apt.postgresql.org/pub/repos/apt/ trusty-pgdg 11' > - key_url: 'https://www.postgresql.org/media/keys/ACCC4CF8.asc' > - packages: > - - postgresql-11 > - - postgresql-client-11 > - sudo: true > - before_install: > - - sudo -u postgres psql -c "grant ALL on DATABASE postgres to travis WITH GRANT OPTION;" > - > > before_script: > - if [[ $PW_TEST_DB_TYPE == mysql ]]; then mysql -e 'create database patchwork character set utf8;'; fi > -- > 2.17.2 > > _______________________________________________ > Patchwork mailing list > Patchwork@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/patchwork
On Wed, 2018-10-31 at 00:58 +1100, Daniel Axtens wrote: > Stephen Finucane <stephen@that.guru> writes: > > > Travis seems to be doing something really weird with PG11 since it was > > released a few weeks ago. This is currently breaking our CI and can't > > continue. It doesn't seem possible to mark this as an expected failure > > so simply remove it. We can re-add this once Travis gains proper support > > for this version via their addons. > > I'm also happy to re-add it if the original approach starts working > again, e.g. if the postgres people fix their packaging, but I definitely > agree that this is the most sensible step at this point. Agreed. As things stand though, this seems to be the correct thing to do and Daniel (Black) agrees. > Acked-by: Daniel Axtens <dja@axtens.net> Cheers. Applied and pushed. Stephen > > Signed-off-by: Stephen Finucane <stephen@that.guru> > > Cc: Daniel Black <daniel@linux.ibm.com>
On Tue, 2018-10-30 at 15:32 +0000, Stephen Finucane wrote: > On Wed, 2018-10-31 at 00:58 +1100, Daniel Axtens wrote: > > Stephen Finucane <stephen@that.guru> writes: > > > > > Travis seems to be doing something really weird with PG11 since it was > > > released a few weeks ago. This is currently breaking our CI and can't > > > continue. It doesn't seem possible to mark this as an expected failure > > > so simply remove it. We can re-add this once Travis gains proper support > > > for this version via their addons. > > > > I'm also happy to re-add it if the original approach starts working > > again, e.g. if the postgres people fix their packaging, but I definitely > > agree that this is the most sensible step at this point. > > Agreed. As things stand though, this seems to be the correct thing to > do and Daniel (Black) agrees. > > > Acked-by: Daniel Axtens <dja@axtens.net> > > Cheers. Applied and pushed. And we're back to a clean build. Phew. Stephen > > Stephen > > > > Signed-off-by: Stephen Finucane <stephen@that.guru> > > > Cc: Daniel Black <daniel@linux.ibm.com> > > > _______________________________________________ > Patchwork mailing list > Patchwork@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/patchwork
diff --git a/.travis.yml b/.travis.yml index bb7ff142..64355450 100644 --- a/.travis.yml +++ b/.travis.yml @@ -47,27 +47,6 @@ matrix: sudo: true before_install: - sudo -u postgres psql -c "grant ALL on DATABASE postgres to travis WITH GRANT OPTION;" - - env: - - PGPORT=5433 - - PW_TEST_DB_HOST="" - - PW_TEST_DB_PORT=5433 - - PW_TEST_DB_TYPE=postgres - - PW_TEST_DB_USER=travis - python: 3.6 - dist: trusty - addons: - postgresql: "11" - apt: - sources: - - sourceline: 'deb http://apt.postgresql.org/pub/repos/apt/ trusty-pgdg 11' - key_url: 'https://www.postgresql.org/media/keys/ACCC4CF8.asc' - packages: - - postgresql-11 - - postgresql-client-11 - sudo: true - before_install: - - sudo -u postgres psql -c "grant ALL on DATABASE postgres to travis WITH GRANT OPTION;" - before_script: - if [[ $PW_TEST_DB_TYPE == mysql ]]; then mysql -e 'create database patchwork character set utf8;'; fi
Travis seems to be doing something really weird with PG11 since it was released a few weeks ago. This is currently breaking our CI and can't continue. It doesn't seem possible to mark this as an expected failure so simply remove it. We can re-add this once Travis gains proper support for this version via their addons. Signed-off-by: Stephen Finucane <stephen@that.guru> Cc: Daniel Black <daniel@linux.ibm.com> --- .travis.yml | 21 --------------------- 1 file changed, 21 deletions(-)