| Message ID | 4D6F008E.7050308@cn.fujitsu.com |
|---|---|
| State | New |
| Headers | show |
On Thu, Mar 3, 2011 at 3:44 AM, Wen Congyang <wency@cn.fujitsu.com> wrote: > VNC_DIRTY_WORDS is wrong on 64 bit long machine. > > Signed-off-by: Wen Congyang <wency@cn.fujitsu.com> > > --- > ui/vnc.h | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/ui/vnc.h b/ui/vnc.h > index 8a1e7b9..239a7a7 100644 > --- a/ui/vnc.h > +++ b/ui/vnc.h > @@ -81,7 +81,8 @@ typedef void VncSendHextileTile(VncState *vs, > > #define VNC_MAX_WIDTH 2560 > #define VNC_MAX_HEIGHT 2048 > -#define VNC_DIRTY_WORDS (VNC_MAX_WIDTH / (16 * BITS_PER_LONG)) > +#define divideup(x, y) (((x) + ((y) - 1)) / (y)) osdep.h:#define DIV_ROUND_UP(n,d) (((n) + (d) - 1) / (d))
At 03/03/2011 02:41 PM, Corentin Chary Write: > On Thu, Mar 3, 2011 at 3:44 AM, Wen Congyang <wency@cn.fujitsu.com> wrote: >> VNC_DIRTY_WORDS is wrong on 64 bit long machine. >> >> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com> >> >> --- >> ui/vnc.h | 3 ++- >> 1 files changed, 2 insertions(+), 1 deletions(-) >> >> diff --git a/ui/vnc.h b/ui/vnc.h >> index 8a1e7b9..239a7a7 100644 >> --- a/ui/vnc.h >> +++ b/ui/vnc.h >> @@ -81,7 +81,8 @@ typedef void VncSendHextileTile(VncState *vs, >> >> #define VNC_MAX_WIDTH 2560 >> #define VNC_MAX_HEIGHT 2048 >> -#define VNC_DIRTY_WORDS (VNC_MAX_WIDTH / (16 * BITS_PER_LONG)) >> +#define divideup(x, y) (((x) + ((y) - 1)) / (y)) > > osdep.h:#define DIV_ROUND_UP(n,d) (((n) + (d) - 1) / (d)) Thank you for pointing out it. I will update my patch. > >
diff --git a/ui/vnc.h b/ui/vnc.h index 8a1e7b9..239a7a7 100644 --- a/ui/vnc.h +++ b/ui/vnc.h @@ -81,7 +81,8 @@ typedef void VncSendHextileTile(VncState *vs, #define VNC_MAX_WIDTH 2560 #define VNC_MAX_HEIGHT 2048 -#define VNC_DIRTY_WORDS (VNC_MAX_WIDTH / (16 * BITS_PER_LONG)) +#define divideup(x, y) (((x) + ((y) - 1)) / (y)) +#define VNC_DIRTY_WORDS (divideup(VNC_MAX_WIDTH, (16 * BITS_PER_LONG))) #define VNC_STAT_RECT 64 #define VNC_STAT_COLS (VNC_MAX_WIDTH / VNC_STAT_RECT)
VNC_DIRTY_WORDS is wrong on 64 bit long machine. Signed-off-by: Wen Congyang <wency@cn.fujitsu.com> --- ui/vnc.h | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)