| Message ID | 92e37a04e77003f01a67ac5e49e66ae83f87c591.1536916714.git-series.quentin.schulz@bootlin.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | add support for VSC8584 and VSC8574 Microsemi quad-port PHYs | expand |
Hi, On 14/09/2018 11:44:26+0200, Quentin Schulz wrote: > In order to use GPIO4 as a GPIO, we need to mux it in this mode so let's > declare a new pinctrl DT node for it. > > Signed-off-by: Quentin Schulz <quentin.schulz@bootlin.com> > --- > arch/mips/boot/dts/mscc/ocelot.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/mips/boot/dts/mscc/ocelot.dtsi b/arch/mips/boot/dts/mscc/ocelot.dtsi > index 8ce317c..b5c4c74 100644 > --- a/arch/mips/boot/dts/mscc/ocelot.dtsi > +++ b/arch/mips/boot/dts/mscc/ocelot.dtsi > @@ -182,6 +182,11 @@ > interrupts = <13>; > #interrupt-cells = <2>; > > + gpio4: gpio4 { > + pins = "GPIO_4"; > + function = "gpio"; > + }; > + For a GPIO, I would do that in the board dts because it is not used directly in the dtsi. > uart_pins: uart-pins { > pins = "GPIO_6", "GPIO_7"; > function = "uart"; > -- > git-series 0.9.1
Hi Alexandre, On Fri, Sep 14, 2018 at 04:54:46PM +0200, Alexandre Belloni wrote: > Hi, > > On 14/09/2018 11:44:26+0200, Quentin Schulz wrote: > > In order to use GPIO4 as a GPIO, we need to mux it in this mode so let's > > declare a new pinctrl DT node for it. > > > > Signed-off-by: Quentin Schulz <quentin.schulz@bootlin.com> > > --- > > arch/mips/boot/dts/mscc/ocelot.dtsi | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/arch/mips/boot/dts/mscc/ocelot.dtsi b/arch/mips/boot/dts/mscc/ocelot.dtsi > > index 8ce317c..b5c4c74 100644 > > --- a/arch/mips/boot/dts/mscc/ocelot.dtsi > > +++ b/arch/mips/boot/dts/mscc/ocelot.dtsi > > @@ -182,6 +182,11 @@ > > interrupts = <13>; > > #interrupt-cells = <2>; > > > > + gpio4: gpio4 { > > + pins = "GPIO_4"; > > + function = "gpio"; > > + }; > > + > > For a GPIO, I would do that in the board dts because it is not used > directly in the dtsi. > And the day we've two boards using this pinctrl we move it to a dtsi. Is that the plan? Thanks, Quentin
On Fri, Sep 14, 2018 at 06:26:38PM +0200, Quentin Schulz wrote: > Hi Alexandre, > > On Fri, Sep 14, 2018 at 04:54:46PM +0200, Alexandre Belloni wrote: > > Hi, > > > > On 14/09/2018 11:44:26+0200, Quentin Schulz wrote: > > > In order to use GPIO4 as a GPIO, we need to mux it in this mode so let's > > > declare a new pinctrl DT node for it. > > > > > > Signed-off-by: Quentin Schulz <quentin.schulz@bootlin.com> > > > --- > > > arch/mips/boot/dts/mscc/ocelot.dtsi | 5 +++++ > > > 1 file changed, 5 insertions(+) > > > > > > diff --git a/arch/mips/boot/dts/mscc/ocelot.dtsi b/arch/mips/boot/dts/mscc/ocelot.dtsi > > > index 8ce317c..b5c4c74 100644 > > > --- a/arch/mips/boot/dts/mscc/ocelot.dtsi > > > +++ b/arch/mips/boot/dts/mscc/ocelot.dtsi > > > @@ -182,6 +182,11 @@ > > > interrupts = <13>; > > > #interrupt-cells = <2>; > > > > > > + gpio4: gpio4 { > > > + pins = "GPIO_4"; > > > + function = "gpio"; > > > + }; > > > + > > > > For a GPIO, I would do that in the board dts because it is not used > > directly in the dtsi. > > > > And the day we've two boards using this pinctrl we move it to a dtsi. Is > that the plan? Hi Quentin gpio4 appears to be pretty arbitrary. Could a different design use a different gpio? It me, this seems like a board property. Andrew
On 14/09/2018 18:26:38+0200, Quentin Schulz wrote: > Hi Alexandre, > > On Fri, Sep 14, 2018 at 04:54:46PM +0200, Alexandre Belloni wrote: > > Hi, > > > > On 14/09/2018 11:44:26+0200, Quentin Schulz wrote: > > > In order to use GPIO4 as a GPIO, we need to mux it in this mode so let's > > > declare a new pinctrl DT node for it. > > > > > > Signed-off-by: Quentin Schulz <quentin.schulz@bootlin.com> > > > --- > > > arch/mips/boot/dts/mscc/ocelot.dtsi | 5 +++++ > > > 1 file changed, 5 insertions(+) > > > > > > diff --git a/arch/mips/boot/dts/mscc/ocelot.dtsi b/arch/mips/boot/dts/mscc/ocelot.dtsi > > > index 8ce317c..b5c4c74 100644 > > > --- a/arch/mips/boot/dts/mscc/ocelot.dtsi > > > +++ b/arch/mips/boot/dts/mscc/ocelot.dtsi > > > @@ -182,6 +182,11 @@ > > > interrupts = <13>; > > > #interrupt-cells = <2>; > > > > > > + gpio4: gpio4 { > > > + pins = "GPIO_4"; > > > + function = "gpio"; > > > + }; > > > + > > > > For a GPIO, I would do that in the board dts because it is not used > > directly in the dtsi. > > > > And the day we've two boards using this pinctrl we move it to a dtsi. Is > that the plan? > Not really, at least not for gpios. I've included the pinctrl for the uart, i2c and spi because they are the only option if you are to use those peripherals. Else, I've would have left the pinctrl to the board file. From my point of view, the gpios are too board specific to be in a soc dtsi.
Hi Andrew, On Fri, Sep 14, 2018 at 07:02:21PM +0200, Andrew Lunn wrote: > On Fri, Sep 14, 2018 at 06:26:38PM +0200, Quentin Schulz wrote: > > Hi Alexandre, > > > > On Fri, Sep 14, 2018 at 04:54:46PM +0200, Alexandre Belloni wrote: > > > Hi, > > > > > > On 14/09/2018 11:44:26+0200, Quentin Schulz wrote: > > > > In order to use GPIO4 as a GPIO, we need to mux it in this mode so let's > > > > declare a new pinctrl DT node for it. > > > > > > > > Signed-off-by: Quentin Schulz <quentin.schulz@bootlin.com> > > > > --- > > > > arch/mips/boot/dts/mscc/ocelot.dtsi | 5 +++++ > > > > 1 file changed, 5 insertions(+) > > > > > > > > diff --git a/arch/mips/boot/dts/mscc/ocelot.dtsi b/arch/mips/boot/dts/mscc/ocelot.dtsi > > > > index 8ce317c..b5c4c74 100644 > > > > --- a/arch/mips/boot/dts/mscc/ocelot.dtsi > > > > +++ b/arch/mips/boot/dts/mscc/ocelot.dtsi > > > > @@ -182,6 +182,11 @@ > > > > interrupts = <13>; > > > > #interrupt-cells = <2>; > > > > > > > > + gpio4: gpio4 { > > > > + pins = "GPIO_4"; > > > > + function = "gpio"; > > > > + }; > > > > + > > > > > > For a GPIO, I would do that in the board dts because it is not used > > > directly in the dtsi. > > > > > > > And the day we've two boards using this pinctrl we move it to a dtsi. Is > > that the plan? > > Hi Quentin > > gpio4 appears to be pretty arbitrary. Could a different design use a > different gpio? It me, this seems like a board property. > Right now, I don't see why it couldn't be. Quentin
Hi Alexandre, On Fri, Sep 14, 2018 at 08:02:22PM +0200, Alexandre Belloni wrote: > On 14/09/2018 18:26:38+0200, Quentin Schulz wrote: > > Hi Alexandre, > > > > On Fri, Sep 14, 2018 at 04:54:46PM +0200, Alexandre Belloni wrote: > > > Hi, > > > > > > On 14/09/2018 11:44:26+0200, Quentin Schulz wrote: > > > > In order to use GPIO4 as a GPIO, we need to mux it in this mode so let's > > > > declare a new pinctrl DT node for it. > > > > > > > > Signed-off-by: Quentin Schulz <quentin.schulz@bootlin.com> > > > > --- > > > > arch/mips/boot/dts/mscc/ocelot.dtsi | 5 +++++ > > > > 1 file changed, 5 insertions(+) > > > > > > > > diff --git a/arch/mips/boot/dts/mscc/ocelot.dtsi b/arch/mips/boot/dts/mscc/ocelot.dtsi > > > > index 8ce317c..b5c4c74 100644 > > > > --- a/arch/mips/boot/dts/mscc/ocelot.dtsi > > > > +++ b/arch/mips/boot/dts/mscc/ocelot.dtsi > > > > @@ -182,6 +182,11 @@ > > > > interrupts = <13>; > > > > #interrupt-cells = <2>; > > > > > > > > + gpio4: gpio4 { > > > > + pins = "GPIO_4"; > > > > + function = "gpio"; > > > > + }; > > > > + > > > > > > For a GPIO, I would do that in the board dts because it is not used > > > directly in the dtsi. > > > > > > > And the day we've two boards using this pinctrl we move it to a dtsi. Is > > that the plan? > > > > Not really, at least not for gpios. I've included the pinctrl for the > uart, i2c and spi because they are the only option if you are to use > those peripherals. Else, I've would have left the pinctrl to the board > file. From my point of view, the gpios are too board specific to be in a > soc dtsi. > Understood, will move it to the board file. Thanks, Quentin
diff --git a/arch/mips/boot/dts/mscc/ocelot.dtsi b/arch/mips/boot/dts/mscc/ocelot.dtsi index 8ce317c..b5c4c74 100644 --- a/arch/mips/boot/dts/mscc/ocelot.dtsi +++ b/arch/mips/boot/dts/mscc/ocelot.dtsi @@ -182,6 +182,11 @@ interrupts = <13>; #interrupt-cells = <2>; + gpio4: gpio4 { + pins = "GPIO_4"; + function = "gpio"; + }; + uart_pins: uart-pins { pins = "GPIO_6", "GPIO_7"; function = "uart";
In order to use GPIO4 as a GPIO, we need to mux it in this mode so let's declare a new pinctrl DT node for it. Signed-off-by: Quentin Schulz <quentin.schulz@bootlin.com> --- arch/mips/boot/dts/mscc/ocelot.dtsi | 5 +++++ 1 file changed, 5 insertions(+)