| Message ID | 20180822144039.5796-2-pavel.zbitskiy@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | Some improvements in z/Arch instructions support | expand |
On 22.08.2018 16:40, Pavel Zbitskiy wrote: > In a few places translate.c contains non-breaking spaces (0xc2 0xa0) > instead of regular ones (0x20): > > 7c 7c c2 a0 63 63 > 7c 7c 20 63 63 > | | c c > > This confuses some text editors. > > Signed-off-by: Pavel Zbitskiy <pavel.zbitskiy@gmail.com> > --- > target/s390x/translate.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target/s390x/translate.c b/target/s390x/translate.c > index 40e12ca2c4..7363aabf3a 100644 > --- a/target/s390x/translate.c > +++ b/target/s390x/translate.c > @@ -842,7 +842,7 @@ static void disas_jcc(DisasContext *s, DisasCompare *c, uint32_t mask) > cond = TCG_COND_NE; > c->u.s32.b = tcg_const_i32(1); > break; > - case 0x8 | 0x2: /* cc == 0 || cc == 2 => (cc & 1) == 0 */ > + case 0x8 | 0x2: /* cc == 0 || cc == 2 => (cc & 1) == 0 */ > cond = TCG_COND_EQ; > c->g1 = false; > c->u.s32.a = tcg_temp_new_i32(); > @@ -861,7 +861,7 @@ static void disas_jcc(DisasContext *s, DisasCompare *c, uint32_t mask) > cond = TCG_COND_NE; > c->u.s32.b = tcg_const_i32(0); > break; > - case 0x4 | 0x1: /* cc == 1 || cc == 3 => (cc & 1) != 0 */ > + case 0x4 | 0x1: /* cc == 1 || cc == 3 => (cc & 1) != 0 */ > cond = TCG_COND_NE; > c->g1 = false; > c->u.s32.a = tcg_temp_new_i32(); > (can't spot a difference in my mail editor ;) ) Reviewed-by: David Hildenbrand <david@redhat.com>
On 2018-08-22 16:40, Pavel Zbitskiy wrote: > In a few places translate.c contains non-breaking spaces (0xc2 0xa0) > instead of regular ones (0x20): > > 7c 7c c2 a0 63 63 > 7c 7c 20 63 63 > | | c c > > This confuses some text editors. Without your patch: $ file target/s390x/translate.c target/s390x/translate.c: C source, UTF-8 Unicode text With your patch: $ file target/s390x/translate.c target/s390x/translate.c: C source, ASCII text Looks like you've got all spots :-) Reviewed-by: Thomas Huth <thuth@redhat.com>
On Wed, 22 Aug 2018 10:40:37 -0400 Pavel Zbitskiy <pavel.zbitskiy@gmail.com> wrote: > In a few places translate.c contains non-breaking spaces (0xc2 0xa0) > instead of regular ones (0x20): > > 7c 7c c2 a0 63 63 > 7c 7c 20 63 63 > | | c c > > This confuses some text editors. Fun :) > > Signed-off-by: Pavel Zbitskiy <pavel.zbitskiy@gmail.com> > --- > target/s390x/translate.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Thanks, applied.
diff --git a/target/s390x/translate.c b/target/s390x/translate.c index 40e12ca2c4..7363aabf3a 100644 --- a/target/s390x/translate.c +++ b/target/s390x/translate.c @@ -842,7 +842,7 @@ static void disas_jcc(DisasContext *s, DisasCompare *c, uint32_t mask) cond = TCG_COND_NE; c->u.s32.b = tcg_const_i32(1); break; - case 0x8 | 0x2: /* cc == 0 || cc == 2 => (cc & 1) == 0 */ + case 0x8 | 0x2: /* cc == 0 || cc == 2 => (cc & 1) == 0 */ cond = TCG_COND_EQ; c->g1 = false; c->u.s32.a = tcg_temp_new_i32(); @@ -861,7 +861,7 @@ static void disas_jcc(DisasContext *s, DisasCompare *c, uint32_t mask) cond = TCG_COND_NE; c->u.s32.b = tcg_const_i32(0); break; - case 0x4 | 0x1: /* cc == 1 || cc == 3 => (cc & 1) != 0 */ + case 0x4 | 0x1: /* cc == 1 || cc == 3 => (cc & 1) != 0 */ cond = TCG_COND_NE; c->g1 = false; c->u.s32.a = tcg_temp_new_i32();
In a few places translate.c contains non-breaking spaces (0xc2 0xa0) instead of regular ones (0x20): 7c 7c c2 a0 63 63 7c 7c 20 63 63 | | c c This confuses some text editors. Signed-off-by: Pavel Zbitskiy <pavel.zbitskiy@gmail.com> --- target/s390x/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)