| Message ID | 1532433463-42508-1-git-send-email-zhongjiang@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | [linux-next] gpio: fix meaningless return expression | expand |
On Tue, 24 Jul 2018 19:57:43 +0800 zhong jiang <zhongjiang@huawei.com> wrote: > Fix the following sparse error: > > drivers/gpio/gpio-ath79.c:54:16: error: return expression in void > function > > Signed-off-by: zhong jiang <zhongjiang@huawei.com> Acked-by: Alban Bedel <albeu@free.fr>
On Tue, Jul 24, 2018 at 2:09 PM zhong jiang <zhongjiang@huawei.com> wrote: > Fix the following sparse error: > > drivers/gpio/gpio-ath79.c:54:16: error: return expression in void function > > Signed-off-by: zhong jiang <zhongjiang@huawei.com> Patch applied with Alban's ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpio/gpio-ath79.c b/drivers/gpio/gpio-ath79.c index 684e9d6..0a553d6 100644 --- a/drivers/gpio/gpio-ath79.c +++ b/drivers/gpio/gpio-ath79.c @@ -51,7 +51,7 @@ static u32 ath79_gpio_read(struct ath79_gpio_ctrl *ctrl, unsigned reg) static void ath79_gpio_write(struct ath79_gpio_ctrl *ctrl, unsigned reg, u32 val) { - return writel(val, ctrl->base + reg); + writel(val, ctrl->base + reg); } static bool ath79_gpio_update_bits(
Fix the following sparse error: drivers/gpio/gpio-ath79.c:54:16: error: return expression in void function Signed-off-by: zhong jiang <zhongjiang@huawei.com> --- drivers/gpio/gpio-ath79.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)