| Message ID | 20180521210502.11082-3-saeedm@mellanox.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net-next,1/6] net/dcb: Add dcbnl buffer attribute | expand |
On Tue, May 22, 2018 at 12:04 AM, Saeed Mahameed <saeedm@mellanox.com> wrote: > From: Huy Nguyen <huyn@mellanox.com> > > Add pbmc and pptb in the port_access_reg_cap_mask. These two > bits determine if device supports receive buffer configuration. > > Signed-off-by: Huy Nguyen <huyn@mellanox.com> Huy, Parav reviewed your code to death (but he's still alive and kicking!), go a head and add his R.Bs note to the entire series. > Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
On Tue, May 22, 2018 at 1:19 PM, Or Gerlitz <gerlitz.or@gmail.com> wrote: > On Tue, May 22, 2018 at 12:04 AM, Saeed Mahameed <saeedm@mellanox.com> wrote: >> From: Huy Nguyen <huyn@mellanox.com> >> >> Add pbmc and pptb in the port_access_reg_cap_mask. These two >> bits determine if device supports receive buffer configuration. >> >> Signed-off-by: Huy Nguyen <huyn@mellanox.com> > > Huy, Parav reviewed your code to death (but he's still alive and kicking!), > go a head and add his R.Bs note to the entire series. when you fix that, also address checkpatch's scream on WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 in four cases along the series >> Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
On Tue, May 22, 2018 at 3:21 AM, Or Gerlitz <gerlitz.or@gmail.com> wrote: > On Tue, May 22, 2018 at 1:19 PM, Or Gerlitz <gerlitz.or@gmail.com> wrote: >> On Tue, May 22, 2018 at 12:04 AM, Saeed Mahameed <saeedm@mellanox.com> wrote: >>> From: Huy Nguyen <huyn@mellanox.com> >>> >>> Add pbmc and pptb in the port_access_reg_cap_mask. These two >>> bits determine if device supports receive buffer configuration. >>> >>> Signed-off-by: Huy Nguyen <huyn@mellanox.com> >> >> Huy, Parav reviewed your code to death (but he's still alive and kicking!), >> go a head and add his R.Bs note to the entire series. > > when you fix that, also address checkpatch's scream on > > WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 > > in four cases along the series > We are going to do this once for all mlx5 files soon, i don't want to have two types of license headers in the meanwhile. let's keep this as is until then. > >>> Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
On Tue, May 22, 2018 at 7:01 PM, Saeed Mahameed <saeedm@dev.mellanox.co.il> wrote: > On Tue, May 22, 2018 at 3:21 AM, Or Gerlitz <gerlitz.or@gmail.com> wrote: >> On Tue, May 22, 2018 at 1:19 PM, Or Gerlitz <gerlitz.or@gmail.com> wrote: >>> On Tue, May 22, 2018 at 12:04 AM, Saeed Mahameed <saeedm@mellanox.com> wrote: >>>> From: Huy Nguyen <huyn@mellanox.com> >>>> >>>> Add pbmc and pptb in the port_access_reg_cap_mask. These two >>>> bits determine if device supports receive buffer configuration. >>>> >>>> Signed-off-by: Huy Nguyen <huyn@mellanox.com> >>> >>> Huy, Parav reviewed your code to death (but he's still alive and kicking!), >>> go a head and add his R.Bs note to the entire series. Just wanted to make sure you didn't miss this one, ack? >> when you fix that, also address checkpatch's scream on >> >> WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 >> >> in four cases along the series >> > > We are going to do this once for all mlx5 files soon, i don't want to > have two types of license headers in the meanwhile. > let's keep this as is until then. > >> >>>> Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
On Thu, May 24, 2018 at 2:21 PM, Or Gerlitz <gerlitz.or@gmail.com> wrote: > On Tue, May 22, 2018 at 7:01 PM, Saeed Mahameed > <saeedm@dev.mellanox.co.il> wrote: >> On Tue, May 22, 2018 at 3:21 AM, Or Gerlitz <gerlitz.or@gmail.com> wrote: >>> On Tue, May 22, 2018 at 1:19 PM, Or Gerlitz <gerlitz.or@gmail.com> wrote: >>>> On Tue, May 22, 2018 at 12:04 AM, Saeed Mahameed <saeedm@mellanox.com> wrote: >>>>> From: Huy Nguyen <huyn@mellanox.com> >>>>> >>>>> Add pbmc and pptb in the port_access_reg_cap_mask. These two >>>>> bits determine if device supports receive buffer configuration. >>>>> >>>>> Signed-off-by: Huy Nguyen <huyn@mellanox.com> >>>> >>>> Huy, Parav reviewed your code to death (but he's still alive and kicking!), >>>> go a head and add his R.Bs note to the entire series. > > Just wanted to make sure you didn't miss this one, ack? > ack
diff --git a/include/linux/mlx5/device.h b/include/linux/mlx5/device.h index 2bc27f8c5b87..db0332a6d23c 100644 --- a/include/linux/mlx5/device.h +++ b/include/linux/mlx5/device.h @@ -1152,6 +1152,9 @@ enum mlx5_qcam_feature_groups { #define MLX5_CAP_PCAM_FEATURE(mdev, fld) \ MLX5_GET(pcam_reg, (mdev)->caps.pcam, feature_cap_mask.enhanced_features.fld) +#define MLX5_CAP_PCAM_REG(mdev, reg) \ + MLX5_GET(pcam_reg, (mdev)->caps.pcam, port_access_reg_cap_mask.regs_5000_to_507f.reg) + #define MLX5_CAP_MCAM_REG(mdev, reg) \ MLX5_GET(mcam_reg, (mdev)->caps.mcam, mng_access_reg_cap_mask.access_regs.reg) diff --git a/include/linux/mlx5/mlx5_ifc.h b/include/linux/mlx5/mlx5_ifc.h index b4ea8a9914c4..f687989d336b 100644 --- a/include/linux/mlx5/mlx5_ifc.h +++ b/include/linux/mlx5/mlx5_ifc.h @@ -8003,6 +8003,17 @@ struct mlx5_ifc_pcam_enhanced_features_bits { u8 ppcnt_statistical_group[0x1]; }; +struct mlx5_ifc_pcam_regs_5000_to_507f_bits { + u8 port_access_reg_cap_mask_127_to_96[0x20]; + u8 port_access_reg_cap_mask_95_to_64[0x20]; + u8 port_access_reg_cap_mask_63_to_32[0x20]; + + u8 port_access_reg_cap_mask_31_to_13[0x13]; + u8 pbmc[0x1]; + u8 pptb[0x1]; + u8 port_access_reg_cap_mask_10_to_0[0xb]; +}; + struct mlx5_ifc_pcam_reg_bits { u8 reserved_at_0[0x8]; u8 feature_group[0x8]; @@ -8012,6 +8023,7 @@ struct mlx5_ifc_pcam_reg_bits { u8 reserved_at_20[0x20]; union { + struct mlx5_ifc_pcam_regs_5000_to_507f_bits regs_5000_to_507f; u8 reserved_at_0[0x80]; } port_access_reg_cap_mask;