| Message ID | 20180514223810.21197-1-saeedm@mellanox.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net,1/1] net/mlx5: Fix build break when CONFIG_SMP=n | expand |
On 05/14/2018 03:38 PM, Saeed Mahameed wrote: > Avoid using the kernel's irq_descriptor and return IRQ vector affinity > directly from the driver. > > This fixes the following build break when CONFIG_SMP=n > > include/linux/mlx5/driver.h: In function ‘mlx5_get_vector_affinity_hint’: > include/linux/mlx5/driver.h:1299:13: error: > ‘struct irq_desc’ has no member named ‘affinity_hint’ > > Fixes: 6082d9c9c94a ("net/mlx5: Fix mlx5_get_vector_affinity function") > Signed-off-by: Saeed Mahameed <saeedm@mellanox.com> > CC: Randy Dunlap <rdunlap@infradead.org> > CC: Guenter Roeck <linux@roeck-us.net> > CC: Thomas Gleixner <tglx@linutronix.de> > Tested-by: Israel Rukshin <israelr@mellanox.com> Reported-by: kbuild test robot <lkp@intel.com> Reported-by: Randy Dunlap <rdunlap@infradead.org> Tested-by: Randy Dunlap <rdunlap@infradead.org> Thanks. > --- > > For -stable v4.14 > > include/linux/mlx5/driver.h | 12 +----------- > 1 file changed, 1 insertion(+), 11 deletions(-) > > diff --git a/include/linux/mlx5/driver.h b/include/linux/mlx5/driver.h > index 2a156c5dfadd..d703774982ca 100644 > --- a/include/linux/mlx5/driver.h > +++ b/include/linux/mlx5/driver.h > @@ -1286,17 +1286,7 @@ enum { > static inline const struct cpumask * > mlx5_get_vector_affinity_hint(struct mlx5_core_dev *dev, int vector) > { > - struct irq_desc *desc; > - unsigned int irq; > - int eqn; > - int err; > - > - err = mlx5_vector2eqn(dev, vector, &eqn, &irq); > - if (err) > - return NULL; > - > - desc = irq_to_desc(irq); > - return desc->affinity_hint; > + return dev->priv.irq_info[vector].mask; > } > > #endif /* MLX5_DRIVER_H */ >
On Mon, 14 May 2018, Randy Dunlap wrote: > On 05/14/2018 03:38 PM, Saeed Mahameed wrote: > > Avoid using the kernel's irq_descriptor and return IRQ vector affinity > > directly from the driver. > > > > This fixes the following build break when CONFIG_SMP=n > > > > include/linux/mlx5/driver.h: In function ‘mlx5_get_vector_affinity_hint’: > > include/linux/mlx5/driver.h:1299:13: error: > > ‘struct irq_desc’ has no member named ‘affinity_hint’ > > > > Fixes: 6082d9c9c94a ("net/mlx5: Fix mlx5_get_vector_affinity function") > > Signed-off-by: Saeed Mahameed <saeedm@mellanox.com> > > CC: Randy Dunlap <rdunlap@infradead.org> > > CC: Guenter Roeck <linux@roeck-us.net> > > CC: Thomas Gleixner <tglx@linutronix.de> > > Tested-by: Israel Rukshin <israelr@mellanox.com> > > Reported-by: kbuild test robot <lkp@intel.com> > Reported-by: Randy Dunlap <rdunlap@infradead.org> > Tested-by: Randy Dunlap <rdunlap@infradead.org> Acked-by: Thomas Gleixner <tglx@linutronix.de>
On Mon, May 14, 2018 at 03:38:10PM -0700, Saeed Mahameed wrote: > Avoid using the kernel's irq_descriptor and return IRQ vector affinity > directly from the driver. > > This fixes the following build break when CONFIG_SMP=n > > include/linux/mlx5/driver.h: In function ‘mlx5_get_vector_affinity_hint’: > include/linux/mlx5/driver.h:1299:13: error: > ‘struct irq_desc’ has no member named ‘affinity_hint’ > > Fixes: 6082d9c9c94a ("net/mlx5: Fix mlx5_get_vector_affinity function") > Signed-off-by: Saeed Mahameed <saeedm@mellanox.com> > CC: Randy Dunlap <rdunlap@infradead.org> > CC: Guenter Roeck <linux@roeck-us.net> > CC: Thomas Gleixner <tglx@linutronix.de> > Tested-by: Israel Rukshin <israelr@mellanox.com> Tested-by: Guenter Roeck <linux@roeck-us.net> > --- > > For -stable v4.14 > > include/linux/mlx5/driver.h | 12 +----------- > 1 file changed, 1 insertion(+), 11 deletions(-) > > diff --git a/include/linux/mlx5/driver.h b/include/linux/mlx5/driver.h > index 2a156c5dfadd..d703774982ca 100644 > --- a/include/linux/mlx5/driver.h > +++ b/include/linux/mlx5/driver.h > @@ -1286,17 +1286,7 @@ enum { > static inline const struct cpumask * > mlx5_get_vector_affinity_hint(struct mlx5_core_dev *dev, int vector) > { > - struct irq_desc *desc; > - unsigned int irq; > - int eqn; > - int err; > - > - err = mlx5_vector2eqn(dev, vector, &eqn, &irq); > - if (err) > - return NULL; > - > - desc = irq_to_desc(irq); > - return desc->affinity_hint; > + return dev->priv.irq_info[vector].mask; > } > > #endif /* MLX5_DRIVER_H */ > -- > 2.17.0 >
From: Saeed Mahameed <saeedm@mellanox.com> Date: Mon, 14 May 2018 15:38:10 -0700 > Avoid using the kernel's irq_descriptor and return IRQ vector affinity > directly from the driver. > > This fixes the following build break when CONFIG_SMP=n > > include/linux/mlx5/driver.h: In function ‘mlx5_get_vector_affinity_hint’: > include/linux/mlx5/driver.h:1299:13: error: > ‘struct irq_desc’ has no member named ‘affinity_hint’ > > Fixes: 6082d9c9c94a ("net/mlx5: Fix mlx5_get_vector_affinity function") > Signed-off-by: Saeed Mahameed <saeedm@mellanox.com> > CC: Randy Dunlap <rdunlap@infradead.org> > CC: Guenter Roeck <linux@roeck-us.net> > CC: Thomas Gleixner <tglx@linutronix.de> > Tested-by: Israel Rukshin <israelr@mellanox.com> > --- > > For -stable v4.14 Applied and queued up for -stable, thanks.
diff --git a/include/linux/mlx5/driver.h b/include/linux/mlx5/driver.h index 2a156c5dfadd..d703774982ca 100644 --- a/include/linux/mlx5/driver.h +++ b/include/linux/mlx5/driver.h @@ -1286,17 +1286,7 @@ enum { static inline const struct cpumask * mlx5_get_vector_affinity_hint(struct mlx5_core_dev *dev, int vector) { - struct irq_desc *desc; - unsigned int irq; - int eqn; - int err; - - err = mlx5_vector2eqn(dev, vector, &eqn, &irq); - if (err) - return NULL; - - desc = irq_to_desc(irq); - return desc->affinity_hint; + return dev->priv.irq_info[vector].mask; } #endif /* MLX5_DRIVER_H */
Avoid using the kernel's irq_descriptor and return IRQ vector affinity directly from the driver. This fixes the following build break when CONFIG_SMP=n include/linux/mlx5/driver.h: In function ‘mlx5_get_vector_affinity_hint’: include/linux/mlx5/driver.h:1299:13: error: ‘struct irq_desc’ has no member named ‘affinity_hint’ Fixes: 6082d9c9c94a ("net/mlx5: Fix mlx5_get_vector_affinity function") Signed-off-by: Saeed Mahameed <saeedm@mellanox.com> CC: Randy Dunlap <rdunlap@infradead.org> CC: Guenter Roeck <linux@roeck-us.net> CC: Thomas Gleixner <tglx@linutronix.de> Tested-by: Israel Rukshin <israelr@mellanox.com> --- For -stable v4.14 include/linux/mlx5/driver.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-)