| Message ID | 20180504092053.GA20277@orion |
|---|---|
| State | Deferred |
| Headers | show |
| Series | mmc: tegra: remove redundant return statement | expand |
On Fri, May 04, 2018 at 12:20:53PM +0300, Aapo Vienamo wrote: > A redundant return statement is removed from > tegra_sdhci_set_uhs_signaling(). The function returns void and the > return does not affect the control flow of the function. > > Signed-off-by: Aapo Vienamo <aapo.vienamo@iki.fi> > --- > drivers/mmc/host/sdhci-tegra.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c > index b877c13184c2..970d38f68939 100644 > --- a/drivers/mmc/host/sdhci-tegra.c > +++ b/drivers/mmc/host/sdhci-tegra.c > @@ -231,7 +231,7 @@ static void tegra_sdhci_set_uhs_signaling(struct sdhci_host *host, > if (timing == MMC_TIMING_UHS_DDR50) > tegra_host->ddr_signaling = true; > > - return sdhci_set_uhs_signaling(host, timing); > + sdhci_set_uhs_signaling(host, timing); > } > > static unsigned int tegra_sdhci_get_max_clock(struct sdhci_host *host) Good catch! Acked-by: Thierry Reding <treding@nvidia.com>
On 04/05/18 12:20, Aapo Vienamo wrote: > A redundant return statement is removed from > tegra_sdhci_set_uhs_signaling(). The function returns void and the > return does not affect the control flow of the function. > > Signed-off-by: Aapo Vienamo <aapo.vienamo@iki.fi> Acked-by: Adrian Hunter <adrian.hunter@intel.com> > --- > drivers/mmc/host/sdhci-tegra.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c > index b877c13184c2..970d38f68939 100644 > --- a/drivers/mmc/host/sdhci-tegra.c > +++ b/drivers/mmc/host/sdhci-tegra.c > @@ -231,7 +231,7 @@ static void tegra_sdhci_set_uhs_signaling(struct sdhci_host *host, > if (timing == MMC_TIMING_UHS_DDR50) > tegra_host->ddr_signaling = true; > > - return sdhci_set_uhs_signaling(host, timing); > + sdhci_set_uhs_signaling(host, timing); > } > > static unsigned int tegra_sdhci_get_max_clock(struct sdhci_host *host) > -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 4 May 2018 at 11:20, Aapo Vienamo <aapo.vienamo@iki.fi> wrote: > A redundant return statement is removed from > tegra_sdhci_set_uhs_signaling(). The function returns void and the > return does not affect the control flow of the function. > > Signed-off-by: Aapo Vienamo <aapo.vienamo@iki.fi> Thanks, applied for next! Kind regards Uffe > --- > drivers/mmc/host/sdhci-tegra.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c > index b877c13184c2..970d38f68939 100644 > --- a/drivers/mmc/host/sdhci-tegra.c > +++ b/drivers/mmc/host/sdhci-tegra.c > @@ -231,7 +231,7 @@ static void tegra_sdhci_set_uhs_signaling(struct sdhci_host *host, > if (timing == MMC_TIMING_UHS_DDR50) > tegra_host->ddr_signaling = true; > > - return sdhci_set_uhs_signaling(host, timing); > + sdhci_set_uhs_signaling(host, timing); > } > > static unsigned int tegra_sdhci_get_max_clock(struct sdhci_host *host) > -- > 2.16.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c index b877c13184c2..970d38f68939 100644 --- a/drivers/mmc/host/sdhci-tegra.c +++ b/drivers/mmc/host/sdhci-tegra.c @@ -231,7 +231,7 @@ static void tegra_sdhci_set_uhs_signaling(struct sdhci_host *host, if (timing == MMC_TIMING_UHS_DDR50) tegra_host->ddr_signaling = true; - return sdhci_set_uhs_signaling(host, timing); + sdhci_set_uhs_signaling(host, timing); } static unsigned int tegra_sdhci_get_max_clock(struct sdhci_host *host)
A redundant return statement is removed from tegra_sdhci_set_uhs_signaling(). The function returns void and the return does not affect the control flow of the function. Signed-off-by: Aapo Vienamo <aapo.vienamo@iki.fi> --- drivers/mmc/host/sdhci-tegra.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)