| Message ID | 152468799766.12449.11245066753252100117.stgit@w520.home |
|---|---|
| State | Accepted |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
| Series | PCI: Add Intel 7th & 8th Gen mobile to ACS quirks | expand |
On Wed, Apr 25, 2018 at 02:27:37PM -0600, Alex Williamson wrote: > The specification update indicates these have the same errate for > implementing non-standard ACS capabilities. > > Signed-off-by: Alex Williamson <alex.williamson@redhat.com> Applied to pci/virtualization for v4.18, thanks! I'm guessing a stable tag would make sense here? > --- > drivers/pci/quirks.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c > index 2990ad1e7c99..6d0dee40dbe5 100644 > --- a/drivers/pci/quirks.c > +++ b/drivers/pci/quirks.c > @@ -4230,11 +4230,24 @@ static int pci_quirk_qcom_rp_acs(struct pci_dev *dev, u16 acs_flags) > * 0xa290-0xa29f PCI Express Root port #{0-16} > * 0xa2e7-0xa2ee PCI Express Root port #{17-24} > * > + * Mobile chipsets are also affected, 7th & 8th Generation > + * Specification update confirms ACS errata 22, status no fix: (7th Generation > + * Intel Processor Family I/O for U/Y Platforms and 8th Generation Intel > + * Processor Family I/O for U Quad Core Platforms Specification Update, > + * August 2017, Revision 002, Document#: 334660-002)[6] > + * Device IDs from I/O datasheet: (7th Generation Intel Processor Family I/O > + * for U/Y Platforms and 8th Generation Intel ® Processor Family I/O for U > + * Quad Core Platforms, Vol 1 of 2, August 2017, Document#: 334658-003)[7] > + * > + * 0x9d10-0x9d1b PCI Express Root port #{1-12} > + * > * [1] http://www.intel.com/content/www/us/en/chipsets/100-series-chipset-datasheet-vol-2.html > * [2] http://www.intel.com/content/www/us/en/chipsets/100-series-chipset-datasheet-vol-1.html > * [3] http://www.intel.com/content/www/us/en/chipsets/100-series-chipset-spec-update.html > * [4] http://www.intel.com/content/www/us/en/chipsets/200-series-chipset-pch-spec-update.html > * [5] http://www.intel.com/content/www/us/en/chipsets/200-series-chipset-pch-datasheet-vol-1.html > + * [6] https://www.intel.com/content/www/us/en/processors/core/7th-gen-core-family-mobile-u-y-processor-lines-i-o-spec-update.html > + * [7] https://www.intel.com/content/www/us/en/processors/core/7th-gen-core-family-mobile-u-y-processor-lines-i-o-datasheet-vol-1.html > */ > static bool pci_quirk_intel_spt_pch_acs_match(struct pci_dev *dev) > { > @@ -4244,6 +4257,7 @@ static bool pci_quirk_intel_spt_pch_acs_match(struct pci_dev *dev) > switch (dev->device) { > case 0xa110 ... 0xa11f: case 0xa167 ... 0xa16a: /* Sunrise Point */ > case 0xa290 ... 0xa29f: case 0xa2e7 ... 0xa2ee: /* Union Point */ > + case 0x9d10 ... 0x9d1b: /* 7th & 8th Gen Mobile */ > return true; > } > >
On Fri, 27 Apr 2018 13:09:56 -0500 Bjorn Helgaas <helgaas@kernel.org> wrote: > On Wed, Apr 25, 2018 at 02:27:37PM -0600, Alex Williamson wrote: > > The specification update indicates these have the same errate for > > implementing non-standard ACS capabilities. > > > > Signed-off-by: Alex Williamson <alex.williamson@redhat.com> > > Applied to pci/virtualization for v4.18, thanks! > > I'm guessing a stable tag would make sense here? Yeah, why not. Thanks, Alex > > --- > > drivers/pci/quirks.c | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c > > index 2990ad1e7c99..6d0dee40dbe5 100644 > > --- a/drivers/pci/quirks.c > > +++ b/drivers/pci/quirks.c > > @@ -4230,11 +4230,24 @@ static int pci_quirk_qcom_rp_acs(struct pci_dev *dev, u16 acs_flags) > > * 0xa290-0xa29f PCI Express Root port #{0-16} > > * 0xa2e7-0xa2ee PCI Express Root port #{17-24} > > * > > + * Mobile chipsets are also affected, 7th & 8th Generation > > + * Specification update confirms ACS errata 22, status no fix: (7th Generation > > + * Intel Processor Family I/O for U/Y Platforms and 8th Generation Intel > > + * Processor Family I/O for U Quad Core Platforms Specification Update, > > + * August 2017, Revision 002, Document#: 334660-002)[6] > > + * Device IDs from I/O datasheet: (7th Generation Intel Processor Family I/O > > + * for U/Y Platforms and 8th Generation Intel ® Processor Family I/O for U > > + * Quad Core Platforms, Vol 1 of 2, August 2017, Document#: 334658-003)[7] > > + * > > + * 0x9d10-0x9d1b PCI Express Root port #{1-12} > > + * > > * [1] http://www.intel.com/content/www/us/en/chipsets/100-series-chipset-datasheet-vol-2.html > > * [2] http://www.intel.com/content/www/us/en/chipsets/100-series-chipset-datasheet-vol-1.html > > * [3] http://www.intel.com/content/www/us/en/chipsets/100-series-chipset-spec-update.html > > * [4] http://www.intel.com/content/www/us/en/chipsets/200-series-chipset-pch-spec-update.html > > * [5] http://www.intel.com/content/www/us/en/chipsets/200-series-chipset-pch-datasheet-vol-1.html > > + * [6] https://www.intel.com/content/www/us/en/processors/core/7th-gen-core-family-mobile-u-y-processor-lines-i-o-spec-update.html > > + * [7] https://www.intel.com/content/www/us/en/processors/core/7th-gen-core-family-mobile-u-y-processor-lines-i-o-datasheet-vol-1.html > > */ > > static bool pci_quirk_intel_spt_pch_acs_match(struct pci_dev *dev) > > { > > @@ -4244,6 +4257,7 @@ static bool pci_quirk_intel_spt_pch_acs_match(struct pci_dev *dev) > > switch (dev->device) { > > case 0xa110 ... 0xa11f: case 0xa167 ... 0xa16a: /* Sunrise Point */ > > case 0xa290 ... 0xa29f: case 0xa2e7 ... 0xa2ee: /* Union Point */ > > + case 0x9d10 ... 0x9d1b: /* 7th & 8th Gen Mobile */ > > return true; > > } > > > >
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index 2990ad1e7c99..6d0dee40dbe5 100644 --- a/drivers/pci/quirks.c +++ b/drivers/pci/quirks.c @@ -4230,11 +4230,24 @@ static int pci_quirk_qcom_rp_acs(struct pci_dev *dev, u16 acs_flags) * 0xa290-0xa29f PCI Express Root port #{0-16} * 0xa2e7-0xa2ee PCI Express Root port #{17-24} * + * Mobile chipsets are also affected, 7th & 8th Generation + * Specification update confirms ACS errata 22, status no fix: (7th Generation + * Intel Processor Family I/O for U/Y Platforms and 8th Generation Intel + * Processor Family I/O for U Quad Core Platforms Specification Update, + * August 2017, Revision 002, Document#: 334660-002)[6] + * Device IDs from I/O datasheet: (7th Generation Intel Processor Family I/O + * for U/Y Platforms and 8th Generation Intel ® Processor Family I/O for U + * Quad Core Platforms, Vol 1 of 2, August 2017, Document#: 334658-003)[7] + * + * 0x9d10-0x9d1b PCI Express Root port #{1-12} + * * [1] http://www.intel.com/content/www/us/en/chipsets/100-series-chipset-datasheet-vol-2.html * [2] http://www.intel.com/content/www/us/en/chipsets/100-series-chipset-datasheet-vol-1.html * [3] http://www.intel.com/content/www/us/en/chipsets/100-series-chipset-spec-update.html * [4] http://www.intel.com/content/www/us/en/chipsets/200-series-chipset-pch-spec-update.html * [5] http://www.intel.com/content/www/us/en/chipsets/200-series-chipset-pch-datasheet-vol-1.html + * [6] https://www.intel.com/content/www/us/en/processors/core/7th-gen-core-family-mobile-u-y-processor-lines-i-o-spec-update.html + * [7] https://www.intel.com/content/www/us/en/processors/core/7th-gen-core-family-mobile-u-y-processor-lines-i-o-datasheet-vol-1.html */ static bool pci_quirk_intel_spt_pch_acs_match(struct pci_dev *dev) { @@ -4244,6 +4257,7 @@ static bool pci_quirk_intel_spt_pch_acs_match(struct pci_dev *dev) switch (dev->device) { case 0xa110 ... 0xa11f: case 0xa167 ... 0xa16a: /* Sunrise Point */ case 0xa290 ... 0xa29f: case 0xa2e7 ... 0xa2ee: /* Union Point */ + case 0x9d10 ... 0x9d1b: /* 7th & 8th Gen Mobile */ return true; }
The specification update indicates these have the same errate for implementing non-standard ACS capabilities. Signed-off-by: Alex Williamson <alex.williamson@redhat.com> --- drivers/pci/quirks.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+)