| Message ID | 1523930895-6973-4-git-send-email-schmitzmic@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | None | expand |
Hi Michael, Adrian, Thanks for your patch! On Tue, Apr 17, 2018 at 4:08 AM, Michael Schmitz <schmitzmic@gmail.com> wrote: > From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> > > This complements the fix in 82533ad9a1c that removed the free_irq Please quote the commit's subject, too, like ... fix in commit 82533ad9a1 ("net: ethernet: ax88796: don't call free_irq without request_irq first") BTW, I have a git alias for that: $ git help fixes `git fixes' is aliased to `show --format='Fixes: %h ("%s")' -s' $ git fixes 82533ad9a1c Fixes: 82533ad9a1c ("net: ethernet: ax88796: don't call free_irq without request_irq first") > call in the error path of probe, to also not call free_irq when > remove is called to revert the effects of probe. > > Signed-off-by: Michael Karcher <kernel@mkarcher.dialup.fu-berlin.de> The patch is authored by Adrian, but his SoB is missing? Michael (Schmitz): as you took the patch, you should add your SoB, too. For the actual patch contents: Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org> Gr{oetje,eeting}s, Geert
On 04/17/2018 04:08 AM, Michael Schmitz wrote: > From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> This should be: From: Michael Karcher <debian@mkarcher.dialup.fu-berlin.de>
From: Geert Uytterhoeven <geert@linux-m68k.org> Date: Tue, 17 Apr 2018 10:20:25 +0200 > BTW, I have a git alias for that: > > $ git help fixes > `git fixes' is aliased to `show --format='Fixes: %h ("%s")' -s' > $ git fixes 82533ad9a1c > Fixes: 82533ad9a1c ("net: ethernet: ax88796: don't call free_irq > without request_irq first") Thanks for sharing :)
Hi Adrian, On Tue, Apr 17, 2018 at 11:40 PM, John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> wrote: > On 04/17/2018 04:08 AM, Michael Schmitz wrote: >> >> From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> > > This should be: > > From: Michael Karcher <debian@mkarcher.dialup.fu-berlin.de> I haven't found a way to change that in my tree yet, sorry. Unless someone has a simple way to fix patch authorship after a merge, I may have to reimport from scratch. Cheers, Michael
Thanks Geert, I'll fix that. I see my v2 series shows up as new series on patchwork - do I need to do something different when tagging the next version, Dave? Cheers, Michael On Wed, Apr 18, 2018 at 1:51 AM, David Miller <davem@davemloft.net> wrote: > From: Geert Uytterhoeven <geert@linux-m68k.org> > Date: Tue, 17 Apr 2018 10:20:25 +0200 > >> BTW, I have a git alias for that: >> >> $ git help fixes >> `git fixes' is aliased to `show --format='Fixes: %h ("%s")' -s' >> $ git fixes 82533ad9a1c >> Fixes: 82533ad9a1c ("net: ethernet: ax88796: don't call free_irq >> without request_irq first") > > Thanks for sharing :)
On 04/17/2018 10:32 PM, Michael Schmitz wrote: >> From: Michael Karcher <debian@mkarcher.dialup.fu-berlin.de> > > I haven't found a way to change that in my tree yet, sorry. Unless > someone has a simple way to fix patch authorship after a merge, I may > have to reimport from scratch. I guess you'll have to re-import then, sorry :(. The correct mail address is: Michael Karcher <kernel@mkarcher.dialup.fu-berlin.de> which Michael uses for all his kernel work. Adrian
On Wed, Apr 18, 2018 at 08:32:25AM +1200, Michael Schmitz wrote: > Hi Adrian, > > On Tue, Apr 17, 2018 at 11:40 PM, John Paul Adrian Glaubitz > <glaubitz@physik.fu-berlin.de> wrote: > > On 04/17/2018 04:08 AM, Michael Schmitz wrote: > >> > >> From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> > > > > This should be: > > > > From: Michael Karcher <debian@mkarcher.dialup.fu-berlin.de> > > I haven't found a way to change that in my tree yet, sorry. Unless > someone has a simple way to fix patch authorship after a merge, I may > have to reimport from scratch. git commit --am --author=<author> Andrew
Hi Andrew, thanks, that's what I was looking for. The next version will have all but one patch correctly attributed to Michael Karcher. Cheers, Michael On Wed, Apr 18, 2018 at 9:13 AM, Andrew Lunn <andrew@lunn.ch> wrote: > On Wed, Apr 18, 2018 at 08:32:25AM +1200, Michael Schmitz wrote: >> Hi Adrian, >> >> On Tue, Apr 17, 2018 at 11:40 PM, John Paul Adrian Glaubitz >> <glaubitz@physik.fu-berlin.de> wrote: >> > On 04/17/2018 04:08 AM, Michael Schmitz wrote: >> >> >> >> From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> >> > >> > This should be: >> > >> > From: Michael Karcher <debian@mkarcher.dialup.fu-berlin.de> >> >> I haven't found a way to change that in my tree yet, sorry. Unless >> someone has a simple way to fix patch authorship after a merge, I may >> have to reimport from scratch. > > git commit --am --author=<author> > > Andrew
diff --git a/drivers/net/ethernet/8390/ax88796.c b/drivers/net/ethernet/8390/ax88796.c index 83e59ae..ecf104c 100644 --- a/drivers/net/ethernet/8390/ax88796.c +++ b/drivers/net/ethernet/8390/ax88796.c @@ -793,7 +793,6 @@ static int ax_remove(struct platform_device *pdev) struct resource *mem; unregister_netdev(dev); - free_irq(dev->irq, dev); iounmap(ei_local->mem); mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);