Message ID | 1523349348-20778-3-git-send-email-yogeshnarayan.gaur@nxp.com |
---|---|
State | Changes Requested |
Headers | show
Return-Path: <linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tyPfm4+1"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="izTQohaE"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40L10B4Hrtz9s3B for <incoming@patchwork.ozlabs.org>; Tue, 10 Apr 2018 18:43:06 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CqMGI2dWfvVmyxbHJXZrIc51Z19WlfMHqqQjpy5CyEg=; b=tyPfm4+1ybvUVG wJu3YJf+3ZBnRkzxq8W8cWm58h8pPkaMi7BuJxqfY7n0CItuvq7h3Y+8ySC7BuNiQKCHRZuKMWHdh BldHC9WfkGBf/uN5TqcUHZwVURobBEtfhw4VEgOFhCbqytPltNBLPRaTGxv4C3NxfWNns4DUnWMI0 DKaXwSkXvWnky7/3P2p7OAqP69m1bEh1+D8HSUqxWqF+cotwnu6WJZ/Ln9E02JkBPl5EKjM7+TiSk jsRNmcpHORApM+LVX7+AIsLK2pbeZVERD/P+1bteA4Ggc98uUvNxkJtI4ebN9w1BtNf++dHbnJXiR 02sZIINjV8d8ekDiYQqw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1f5ork-0004R2-6P; Tue, 10 Apr 2018 08:43:00 +0000 Received: from mail-eopbgr20059.outbound.protection.outlook.com ([40.107.2.59] helo=EUR02-VE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1f5omy-0000Iy-Ir for linux-mtd@lists.infradead.org; Tue, 10 Apr 2018 08:38:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=qaZI3PWq4niWrjUeg480gcLRT8YhPWrq5giI3ih+X7I=; b=izTQohaEEC/qYUsQBZYOro7o1Pw9PY6lipV94wIOL9Oo3cHbYU0UFu3JES7SKvEptfwAR+uTXXTCyhKjGNQYgZNhfmn3Ef+PXHYsjqgsdKL4ndOGyB9XKi5d8xYEywIzBOQzYfoSkc5UJyTk31p4JzrvkIeUycZl4eTxPI4SrLQ= Received: from idcbfarm.ap.freescale.net (14.142.187.166) by HE1PR0402MB2843.eurprd04.prod.outlook.com (2603:10a6:3:d6::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.653.12; Tue, 10 Apr 2018 08:37:15 +0000 From: Yogesh Gaur <yogeshnarayan.gaur@nxp.com> To: linux-mtd@lists.infradead.org Subject: [PATCH v10 2/2] mtd: fsl-quadspi: fix init AHB read in fsl_qspi_nor_setup() Date: Tue, 10 Apr 2018 14:05:48 +0530 Message-Id: <1523349348-20778-3-git-send-email-yogeshnarayan.gaur@nxp.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1523349348-20778-1-git-send-email-yogeshnarayan.gaur@nxp.com> References: <1523349348-20778-1-git-send-email-yogeshnarayan.gaur@nxp.com> MIME-Version: 1.0 X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: HK2PR02CA0180.apcprd02.prod.outlook.com (2603:1096:201:21::16) To HE1PR0402MB2843.eurprd04.prod.outlook.com (2603:10a6:3:d6::12) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(48565401081)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:HE1PR0402MB2843; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0402MB2843; 3:FzVd/2ccfeG6F87BWsUYzE+b1dFctvckz5kyg8wJwNXW2VyVNIPfoJJcfljRlyohwc2oH4jsbdXR45ckzjIQpqKLluKTCV6lR+PrUBPluV4Mp3SxfuV1l0yTWxpzJFjCbp38i2/35JKATh7Gq6P8+zbvqcqxRG+iGQpkzTmJ2POUqEXSqKcfTGFIeabSubbNvpCorD1z6z0UtURQlke+6H36zlph/xZ5FKukMf1loBCkjFkwJdVpVjuIPeMC4EtI; 25:JzskF4AODvjn6aVlFnKhgn92JYRl5Cf7a60JT1OdCwhoNHVNOifuX+89EaA7c3HU/dZCzIpQ3vA8ow7EfmZcpRGyz9MUNY84X7iPiCV6SGx3MeyLRTMdTQ6C0s2+aCxjREuiBxdEORJNyDnLGIN4ES70MVdTsog8mxtPcikNh2T+iWHgmOFKJszgfPweVSMKCFVJqs20H6mGjh4sQHUTrDgirtxgR0tTgldIMk1nk15C0m8VWsAMv9XN/plgw5/yyLSHy38Ivpcy6DzNhbgEfiVd54qQFZibTFmVI55g22/xlH7gPI8GqIYhGF4y3CDU0ir6feknAnUdDdkWNF6hHw==; 31:z4arJt87UKVH/E3K12xXVXPI7j1PE/C56KxRTfImdpVnoq9sYpYAbWTOqYvdPR8LPiWTOXhX6q+2ZLz1+zHW8NtMjPY5q+pnrEjn/BDws9X9qVlrl1yFik8jORdHnrxudH7T5yXouG4FaicUnuY3MJcKPxNHSSqgpuMQZCECeW2qkuBg6Hr6usoBtC2PjTm94nFVddV5P9vu9mNp4qXg0sv52VurUgCZa2cwQnTXGVs= X-MS-TrafficTypeDiagnostic: HE1PR0402MB2843: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yogeshnarayan.gaur@nxp.com; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0402MB2843; 20:TEaN22YGr8OEQnjSPXk9Ptb+uiNZdaD7S1gTG9J/8wDc5eGWAf+eywrSa1owlxPK5dACdDWoqnkFrlSqAuXZz7QqbgwOhOjVU89FeRQKdmqBJRqQ8DWEEu8SkrEu6g85QfxhS0gM3AJNV1yL71IRmGtVBaFKQOINSefjX3Euv8qtYFLuHw/rebMZGplBCjJJ/iK505he9u2nJ+T8fiafkP+1MCTxPJdYM+28oxrJo5i6GYBr8BXVj8W1pwOAPhFD6TPf6PjmIb67yuudThD241KlwSl0wJQyND2MsQukC30q9WgY3IZP3f3iWAtkun5upU/CxC2z1qlGJTo/KL8HyFB7mbPwiQ66gjsLC3KIBnVxsTuIEVc2W4pm4GwEBrkZES8Xnl6KzIw8xR7tQY/Ket1ioxi0tR5K3ezusrKW7qFEswcl92jQX2RtZLHvj3LQpX1LniVosC6qsDa3rTU9Lk7OVPmodzmItcjN7XJ5L4aYBVO/Pte6H2v2qDovM8Ij; 4:D4Y9Xj/tQllU+bN6Ov0H8kANw1JfOqqJ99NQSCin8JVD2EiaEPOYKh33QG2esIQ/1XejJFm+QmFRjmZSeKbSp721h9LpY0M6/ZGMg7XGDCfF62O5Zqg1bQtbQVK0sfkPV0PxzsqD58KpiV/REl1iqndoF2KvYGeQVgTCOg66qj38XpYpTKARVUTHTcf8opOwtnOAgam3WuGZ6OzB7qGcvJ1iVfHyNj3i1XPHDhWkeiwyOBsv4hxtE3otQ9YhZWeEIXkSmuFmM8QjgbPRBp7NPBB54B3Q4fUf+Yi578j0uJSDHw99LrbSS3lMYXpB6PVrN9VApLkTQ3gUpAMEPsguoKV6+RzapUirXt//Our2pws= X-Microsoft-Antispam-PRVS: <HE1PR0402MB2843FECA69FA749B651FBD7699BE0@HE1PR0402MB2843.eurprd04.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(17755550239193); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231221)(944501327)(52105095)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041310)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:HE1PR0402MB2843; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0402MB2843; X-Forefront-PRVS: 0638FD5066 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(39380400002)(346002)(366004)(376002)(396003)(189003)(199004)(8936002)(2906002)(97736004)(2351001)(386003)(25786009)(86362001)(16586007)(6506007)(39060400002)(66066001)(6486002)(55236004)(36756003)(26005)(2616005)(6666003)(956004)(106356001)(68736007)(446003)(316002)(476003)(186003)(7736002)(81166006)(4326008)(2361001)(48376002)(50466002)(305945005)(11346002)(47776003)(51416003)(8676002)(5660300001)(6916009)(52116002)(105586002)(50226002)(478600001)(6512007)(81156014)(53936002)(6116002)(16526019)(486006)(5009440100003)(76176011)(3846002)(110426004); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0402MB2843; H:idcbfarm.ap.freescale.net; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR0402MB2843; 23:ykxhCYNmjw7veV07Ds2vL1XGyFm7ovK0xax19kD?= I66Yb0IybX3XyyVgDVpIGOBj4Z+s74mQlVCZeEM/BO2MF2PuHnTiS9ytqLESzaEvSnCnCvg1HiNJ8wer8UaLRSs58rTA9RhiF0VqGHDXJT5No7g3RNAMMKrNcE7/ZTMFLQVSoduTJCoigekYCBmpvucULUD8ybyqTzXln/W2+CewSRTCh8ZUdZPUm+nDNVRPeXQf8vRWVlb5O2CAewIoNBq04pQvBR0J9m1tnk2cYux9FTL8RNNdkQ85xvWEwohcHkq2aivQJuty61VPW+70SuOj6k8HSas1pM3yzmBNAlpXlq10mBEOw+GxIchxkO7bR0Qfru+QKrpQZBJ4JhgysZPxc6Lu5L4r++xoeD37viL5nNozTYnpbdmOqbQoIewnB5FaaT8XEc0tPDTdajkXxyrRPdthMlKJJmGnmJSOtuSuyXwdB4KewRJom87BU8El6cwvs62woBLmBcXRQWiXsrH2JvuJErc3YtNdoGyJ3pE/uRVtGj+9orwgtEJLj1Jtb3eJtuZ9EWaW5n+GibnehMBfwHS3/iSnOl+5w/vajbDWrWGrPTNZlixFLgLVQQfn5VSZwd4XLL8Sjlu7SlNV9XJaH8QOMQ6CwEkoUKtnRb9GndWSWpju50vnaLM+8Q++cudXF7y2RFAMoZ1j+f3BeBIxJp7QPpyGd+ogiGCwBGYelvu2GeipwGff2dHBdRvprgJUL+8FizsBjd9z4pZG3TxHDoIwop+mbdlnz/Hf1qMfl5rr427cOJ5lyM2AHFl6S/FJfvcCkX1cFPp31Fqy5AuWhYHmyrLRe53nVrEmt5oRZfOPm6iY24qh2NiuY4qBBryAMwo79osmgbFY04y9cIkS2V16oI9Zgn6XGwr/n5RcXkzkYyOSMf/M9b5ACUZp03urCKbBxpYtLezWPJsxWMrkmwb2vLQQCEcuZGEdrXLPAMPe/6tfWcxYPpJ032V93TjzHIl7jKmeMXWCnKSLsbq6qAfhlOsFZpNBw1m4WjA+KFiDNT1IatHkHrlU0M+5r4T2L92xU9MGyUGwtcXFD7+iZ/Wqiu64L7Fb5gaN8w7jKnQjLkL/7T0gIbeVZ5iGq3dNgs/7JG7F6w5vqv3WKJG5volIQA54OiuW/vyXYEst3fUS64GGCg7AV6OLBy8tOiyupRqco4laaFM6xPWZg2+JoCDYeo0i2oig9ORpshrWHfipmVKTVzJeeC1mjHzqw+xdr8GB6CrYBxN5Ygs3Tw2uVd9+s6JzFKd8+YODb++svAyCjH0xcsnk4n2GhaNwPnqw= X-Microsoft-Antispam-Message-Info: mskuaddbaP38Bek+a4mOcqFrY4hUJXPjAShKlXglF8OPklzBjZn1rQHuMI5T1j3hIhZilZprkJT7+e53Uf3ssVqy68BGNcaIX2bK/ibP7QhCbGFc9pk+BowILGLxH0Zx4G1DLq9IxBUzCRP6+1E7Mxgsu7HTJpGthDmaZhtActhKGiPLgQO+y6OWSJT6HVJu X-Microsoft-Exchange-Diagnostics: 1; HE1PR0402MB2843; 6:l6KGBWmmDoswdnGwQ8GLJkWSuFj+cH8hg4bPE+6ZaY1ySnR2YTIyvFVNrPtI4s/nPxWsWP3RI6JECO2KULcxbATskoKzGfshFGJNsfUVjf9dWCauQV2uRGbC44yShlDe/OZm/E1BQUKsj7mJEv2b8Me/tA68crvMIphHupgMyFVQ3uNQw2kY5nIZdrse5oO3VJvPCoRSaVWFZ9kQs9T0dvDM7doELcU3+1EuLEUn3LfzlV+E+g5evEFK8MAWNFI7ZuM+H48ZHnUIEm7hEJDziZwvU4IMVnhjF3HBmFDvYSc4GZ/Z3rco9R8D+BQp6ZbxVix7KBBbWotFUFEzU62dna8zAUvnJDCZnE0TMqd7EDpIEttFV3qchLG1s3J9kmh1wjYKezQ97Ufl21IFOYrqKrd065nBch+vgMwA2EzrkGgyOlFkOtT5MCZXBTx7aS+/5Al6dffJzbJWlsgQbJDKgQ==; 5:ozej/+ZL4tFbLXDNue7V9Jy2k5FKjki3vXNLp5FWEYW5yJgdoXmo1suVukyDLCyWg1dqNeOM2OfNQbqvk9DRz3Uyga+V4dNyr+gnXgsZ3i+Sylr8cL1wvyRvb93OyFs0vT4oy39EUxV4FoGheNYt1QpNCjts3sI5Ck5zJ8THPIY=; 24:Ok2CAjpi0xswMFo6THddaGRlt7Tr8oHNBxivcp8h5DadPAB/rBKyV43UVU2qKe4dWE4io0Pd48v3KcoEc45YkZ7D3IWO+0t9PXYxXkndE1s= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; HE1PR0402MB2843; 7:5qoJ8pLgFOY+QneVCq/vMo1VeMU28gdTKyi1AsuX8JUUsj2WC5mBlhQlEiekN25A5gk1gSnF4cn0VYSBo1nB07H4y2sHgclFpWsk0Cozv02hjrbUcqbLIjxVZpgdePWRMOE3dlV9Xof2OVD1tOtQE/ImFBbWO4pYgycbTjJBJKdenh2ovCfs1WWRccgpH65x3dEBqGCPz07d+LIIT0G3dDa8+sjw2gg7GGJfumq1oGcumhKb6e/pCOR4Le+yT7MJ X-MS-Office365-Filtering-Correlation-Id: 59bdf6fe-d9e9-4712-31e9-08d59ebe46a7 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2018 08:37:15.7098 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 59bdf6fe-d9e9-4712-31e9-08d59ebe46a7 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB2843 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180410_013804_829150_ECC98D99 X-CRM114-Status: GOOD ( 12.81 ) X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [40.107.2.59 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list <linux-mtd.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-mtd>, <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-mtd/> List-Post: <mailto:linux-mtd@lists.infradead.org> List-Help: <mailto:linux-mtd-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>, <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe> Cc: boris.brezillon@free-electrons.com, Yogesh Gaur <yogeshnarayan.gaur@nxp.com>, marek.vasut@gmail.com, frieder.schrempf@exceet.de, prabhakar.kushwaha@nxp.com, suresh.gupta@nxp.com, cyrille.pitchen@wedev4u.fr, han.xu@nxp.com, computersforpeace@gmail.com, festevam@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" <linux-mtd-bounces@lists.infradead.org> Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org |
Series |
mtd: fsl-quadspi: add support to create dynamic LUT entry
|
expand
|
On 04/10/2018 10:35 AM, Yogesh Gaur wrote: > Move AHB read initialize in fsl_qspi_nor_setup(). > > In file spi-nor.c, func spi_nor_scan() calls nor->read() thru > spi_nor_read_sfdp() API. > > Presently, fsl_qspi_init_ahb_read() called from fsl_qspi_nor_setup_last(). > Func fsl_qspi_probe() calls spi_nor_scan() first and then calls > fsl_qspi_nor_setup_last(). > > When nor->read() being called from inside spi_nor_read_sfdp(), QSPI cntlr > AHB mode initialization is not yet done results in data read error. > > Initialize AHB read inside fsl_qspi_nor_setup(). Please run the commit message through aspell or somesuch, hint : func, thru, cntlr .
diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c index 667cab2..401a783 100644 --- a/drivers/mtd/spi-nor/fsl-quadspi.c +++ b/drivers/mtd/spi-nor/fsl-quadspi.c @@ -796,6 +796,9 @@ static int fsl_qspi_nor_setup(struct fsl_qspi *q) /* enable the interrupt */ qspi_writel(q, QUADSPI_RSER_TFIE, q->iobase + QUADSPI_RSER); + /* Init for AHB read */ + fsl_qspi_init_ahb_read(q); + return 0; } @@ -818,9 +821,6 @@ static int fsl_qspi_nor_setup_last(struct fsl_qspi *q) if (ret) return ret; - /* Init for AHB read */ - fsl_qspi_init_ahb_read(q); - /* Prepare LUT for AHB read - required for read from devmem interface */ fsl_qspi_prep_ahb_read(q);
Move AHB read initialize in fsl_qspi_nor_setup(). In file spi-nor.c, func spi_nor_scan() calls nor->read() thru spi_nor_read_sfdp() API. Presently, fsl_qspi_init_ahb_read() called from fsl_qspi_nor_setup_last(). Func fsl_qspi_probe() calls spi_nor_scan() first and then calls fsl_qspi_nor_setup_last(). When nor->read() being called from inside spi_nor_read_sfdp(), QSPI cntlr AHB mode initialization is not yet done results in data read error. Initialize AHB read inside fsl_qspi_nor_setup(). Signed-off-by: Yogesh Gaur <yogeshnarayan.gaur@nxp.com> --- Changes for v10: - None Changes for v9: - None Changes for v8: - None Changes for v7: - None Changes for v6: - None Changes for v5: - None Changes for v4: - None Changes for v3: - None Changes for v2: - None drivers/mtd/spi-nor/fsl-quadspi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)