| Message ID | AANLkTikHidY=BkKDjUbOAp=tNvGYBq=Z7Wsdzk4amBYA@mail.gmail.com |
|---|---|
| State | New |
| Headers | show |
On Sun, Jan 09, 2011 at 04:56:59PM +0000, Blue Swirl wrote: > Avoid a warning with GCC 4.6.0: > /src/qemu/target-cris/translate.c: In function 'gen_intermediate_code_internal': > /src/qemu/target-cris/translate.c:3185:25: error: variable > 'orig_flags' set but not used [-Werror=unused-but-set-variable] Hi, Looks good but you are using spaces in a tab only file. I don't mind much but it's maybe better to switch to entirely to spaces or not at all. Cheers > Signed-off-by: Blue Swirl <blauwirbel@gmail.com> > --- > target-cris/translate.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/target-cris/translate.c b/target-cris/translate.c > index 5184155..21983eb 100644 > --- a/target-cris/translate.c > +++ b/target-cris/translate.c > @@ -3182,7 +3182,7 @@ gen_intermediate_code_internal(CPUState *env, > TranslationBlock *tb, > { > uint16_t *gen_opc_end; > uint32_t pc_start; > - unsigned int insn_len, orig_flags; > + unsigned int insn_len; > int j, lj; > struct DisasContext ctx; > struct DisasContext *dc = &ctx; > @@ -3224,8 +3224,8 @@ gen_intermediate_code_internal(CPUState *env, > TranslationBlock *tb, > dc->cc_size_uptodate = -1; > > /* Decode TB flags. */ > - orig_flags = dc->tb_flags = tb->flags & (S_FLAG | P_FLAG | U_FLAG \ > - | X_FLAG | PFIX_FLAG); > + dc->tb_flags = tb->flags & (S_FLAG | P_FLAG | U_FLAG | X_FLAG \ > + | PFIX_FLAG); > dc->delayed_branch = !!(tb->flags & 7); > if (dc->delayed_branch) > dc->jmp = JMP_INDIRECT; > -- > 1.6.2.4
On Mon, Jan 10, 2011 at 9:06 AM, Edgar E. Iglesias <edgar.iglesias@gmail.com> wrote: > On Sun, Jan 09, 2011 at 04:56:59PM +0000, Blue Swirl wrote: >> Avoid a warning with GCC 4.6.0: >> /src/qemu/target-cris/translate.c: In function 'gen_intermediate_code_internal': >> /src/qemu/target-cris/translate.c:3185:25: error: variable >> 'orig_flags' set but not used [-Werror=unused-but-set-variable] > > Hi, > > Looks good but you are using spaces in a tab only file. I don't mind > much but it's maybe better to switch to entirely to spaces or not > at all. OK, I'll leave this to you.
diff --git a/target-cris/translate.c b/target-cris/translate.c index 5184155..21983eb 100644 --- a/target-cris/translate.c +++ b/target-cris/translate.c @@ -3182,7 +3182,7 @@ gen_intermediate_code_internal(CPUState *env, TranslationBlock *tb, { uint16_t *gen_opc_end; uint32_t pc_start; - unsigned int insn_len, orig_flags; + unsigned int insn_len; int j, lj; struct DisasContext ctx;
Avoid a warning with GCC 4.6.0: /src/qemu/target-cris/translate.c: In function 'gen_intermediate_code_internal': /src/qemu/target-cris/translate.c:3185:25: error: variable 'orig_flags' set but not used [-Werror=unused-but-set-variable] Signed-off-by: Blue Swirl <blauwirbel@gmail.com> --- target-cris/translate.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) struct DisasContext *dc = &ctx; @@ -3224,8 +3224,8 @@ gen_intermediate_code_internal(CPUState *env, TranslationBlock *tb, dc->cc_size_uptodate = -1; /* Decode TB flags. */ - orig_flags = dc->tb_flags = tb->flags & (S_FLAG | P_FLAG | U_FLAG \ - | X_FLAG | PFIX_FLAG); + dc->tb_flags = tb->flags & (S_FLAG | P_FLAG | U_FLAG | X_FLAG \ + | PFIX_FLAG); dc->delayed_branch = !!(tb->flags & 7); if (dc->delayed_branch) dc->jmp = JMP_INDIRECT;