| Message ID | 1510312397-29040-1-git-send-email-j-keerthy@ti.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] gpio: davinci: Assign first bank regs for unbanked case | expand |
On Friday 10 November 2017 04:43 PM, Keerthy wrote: > As per the re-design assign the first bank regs for unbanked > irq case. This was missed out in the original patch. Linus, A gentle ping. - Keerthy > > Signed-off-by: Keerthy <j-keerthy@ti.com> > Fixes: b5cf3fd827d2e1 ("gpio: davinci: Redesign driver to accommodate ngpios in one gpio chip") > --- > > Changes in v2: > > * Fixed $Author > > drivers/gpio/gpio-davinci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c > index f75d844..e4b3d7d 100644 > --- a/drivers/gpio/gpio-davinci.c > +++ b/drivers/gpio/gpio-davinci.c > @@ -383,7 +383,7 @@ static int gpio_irq_type_unbanked(struct irq_data *data, unsigned trigger) > u32 mask; > > d = (struct davinci_gpio_controller *)irq_data_get_irq_handler_data(data); > - g = (struct davinci_gpio_regs __iomem *)d->regs; > + g = (struct davinci_gpio_regs __iomem *)d->regs[0]; > mask = __gpio_mask(data->irq - d->base_irq); > > if (trigger & ~(IRQ_TYPE_EDGE_FALLING | IRQ_TYPE_EDGE_RISING)) > -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Nov 10, 2017 at 12:13 PM, Keerthy <j-keerthy@ti.com> wrote: > As per the re-design assign the first bank regs for unbanked > irq case. This was missed out in the original patch. > > Signed-off-by: Keerthy <j-keerthy@ti.com> > Fixes: b5cf3fd827d2e1 ("gpio: davinci: Redesign driver to accommodate ngpios in one gpio chip") > --- > > Changes in v2: > > * Fixed $Author Patch applied for fixes, sorry for eternal delay. Keerthy, if you work on DaVinci, would you mind looking quickly at this patch: https://marc.info/?l=linux-input&m=151151651401442&w=2 Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thursday 30 November 2017 08:12 PM, Linus Walleij wrote: > On Fri, Nov 10, 2017 at 12:13 PM, Keerthy <j-keerthy@ti.com> wrote: > >> As per the re-design assign the first bank regs for unbanked >> irq case. This was missed out in the original patch. >> >> Signed-off-by: Keerthy <j-keerthy@ti.com> >> Fixes: b5cf3fd827d2e1 ("gpio: davinci: Redesign driver to accommodate ngpios in one gpio chip") >> --- >> >> Changes in v2: >> >> * Fixed $Author > > Patch applied for fixes, sorry for eternal delay. No issues and Thanks! > > Keerthy, if you work on DaVinci, would you mind looking quickly at this > patch: > https://marc.info/?l=linux-input&m=151151651401442&w=2 Sure. I will get back on this. > > Yours, > Linus Walleij > -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Friday 01 December 2017 10:10 AM, Keerthy wrote: > > > On Thursday 30 November 2017 08:12 PM, Linus Walleij wrote: >> On Fri, Nov 10, 2017 at 12:13 PM, Keerthy <j-keerthy@ti.com> wrote: >> >>> As per the re-design assign the first bank regs for unbanked >>> irq case. This was missed out in the original patch. >>> >>> Signed-off-by: Keerthy <j-keerthy@ti.com> >>> Fixes: b5cf3fd827d2e1 ("gpio: davinci: Redesign driver to accommodate ngpios in one gpio chip") >>> --- >>> >>> Changes in v2: >>> >>> * Fixed $Author >> >> Patch applied for fixes, sorry for eternal delay. > > No issues and Thanks! > >> >> Keerthy, if you work on DaVinci, would you mind looking quickly at this >> patch: >> https://marc.info/?l=linux-input&m=151151651401442&w=2 > > Sure. I will get back on this. Linus, Could you please Cc nsekhar@ti.com who Maintains arch/arm/mach-davinci/board-da850-evm.c Also could you see Cc me as well on that patch? Regards, Keerthy > >> >> Yours, >> Linus Walleij >> -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c index f75d844..e4b3d7d 100644 --- a/drivers/gpio/gpio-davinci.c +++ b/drivers/gpio/gpio-davinci.c @@ -383,7 +383,7 @@ static int gpio_irq_type_unbanked(struct irq_data *data, unsigned trigger) u32 mask; d = (struct davinci_gpio_controller *)irq_data_get_irq_handler_data(data); - g = (struct davinci_gpio_regs __iomem *)d->regs; + g = (struct davinci_gpio_regs __iomem *)d->regs[0]; mask = __gpio_mask(data->irq - d->base_irq); if (trigger & ~(IRQ_TYPE_EDGE_FALLING | IRQ_TYPE_EDGE_RISING))
As per the re-design assign the first bank regs for unbanked irq case. This was missed out in the original patch. Signed-off-by: Keerthy <j-keerthy@ti.com> Fixes: b5cf3fd827d2e1 ("gpio: davinci: Redesign driver to accommodate ngpios in one gpio chip") --- Changes in v2: * Fixed $Author drivers/gpio/gpio-davinci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)