| Message ID | 20171012090047.GA4479@ingrassia.epigenesys.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: stmmac: dwmac_lib: fix interchanged sleep/timeout values in DMA reset function | expand |
From: Emiliano Ingrassia <ingrassia@epigenesys.com> Date: Thu, 12 Oct 2017 11:00:47 +0200 > The DMA reset timeout, used in read_poll_timeout, is > ten times shorter than the sleep time. > This patch fixes these values interchanging them, as it was > before the read_poll_timeout introduction. > > Fixes: 8a70aeca80c2 ("net: stmmac: Use readl_poll_timeout") > > Signed-off-by: Emiliano Ingrassia <ingrassia@epigenesys.com> Applied.
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c b/drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c index 67af0bdd7f10..7516ca210855 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c @@ -34,7 +34,7 @@ int dwmac_dma_reset(void __iomem *ioaddr) err = readl_poll_timeout(ioaddr + DMA_BUS_MODE, value, !(value & DMA_BUS_MODE_SFT_RESET), - 100000, 10000); + 10000, 100000); if (err) return -EBUSY;
The DMA reset timeout, used in read_poll_timeout, is ten times shorter than the sleep time. This patch fixes these values interchanging them, as it was before the read_poll_timeout introduction. Fixes: 8a70aeca80c2 ("net: stmmac: Use readl_poll_timeout") Signed-off-by: Emiliano Ingrassia <ingrassia@epigenesys.com> --- drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)