| Message ID | 482a6c92-a85e-0bcd-edf7-3c2f63ea74c5@users.sourceforge.net |
|---|---|
| Headers | show |
| Series | S5P MFC: Adjustments for five function implementations | expand |
On 09/08/2017 10:51 PM, SF Markus Elfring wrote: > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring<elfring@users.sourceforge.net> Could you make the commit summary shorter, to keep it below 70 characters [1]? With that changed feel free to add Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com> -- Regards, Sylwester [1] Documentation/process/submitting-patches.rst
On 09/08/2017 10:52 PM, SF Markus Elfring wrote: > Replace the specification of a data structure by a pointer dereference > as the parameter for the operator "sizeof" to make the corresponding size > determination a bit safer according to the Linux coding style convention. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring<elfring@users.sourceforge.net> Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> Could you make the commit summary shorter, to keep it > below 70 characters [1]? With that changed feel free to add > > Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com> … > [1] Documentation/process/submitting-patches.rst Will it be sufficient that a patch committer will adjust the summary phrase a bit? Regards, Markus
From: Markus Elfring <elfring@users.sourceforge.net> Date: Fri, 8 Sep 2017 22:44:55 +0200 Three update suggestions were taken into account from static source code analysis. Markus Elfring (3): Delete an error message for a failed memory allocation in s5p_mfc_probe() Improve a size determination ins5p_mfc_alloc_memdev() Adjust a null pointer check in four functions drivers/media/platform/s5p-mfc/s5p_mfc.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-)