| Message ID | 4CF91A32.6080706@redhat.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Fri, Dec 03, 2010 at 10:26:26AM -0600, Eric Sandeen wrote: > As reported by Cezary Sliwa in > https://bugzilla.kernel.org/show_bug.cgi?id=24282 > ext2_fs.h references FS_DIRSYNC_FL etc, but does not > include <linux/fs.h> to define them. This seems ok > for kernelspace builds, but breaks userspace applications > which include ext2_fs.h. > > Reported-by: Cezary Sliwa <sliwa@blue.cft.edu.pl> > Signed-off-by: Eric Sandeen <sandeen@redhat.com> I wonder if we would be better off getting application programs weaned off of trying to use the kernel's version of ext2_fs.h altogether. E2fsprogs ships one which is going to be more uptodate, and works for ext2/ext3/ext4. Certainly if you plan to be using libext2fs (which I would strongly advise for any program hoping to manipulate ext2 filesystem structures directly), you should be using the header file shipped with e2fsprogs. Debian and Ubuntu for example ships /usr/include/ext2fs/ext2_fs.h as part of its e2fslibs-dev package. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/linux/ext2_fs.h b/include/linux/ext2_fs.h index 2dfa707..91f90e4 100644 --- a/include/linux/ext2_fs.h +++ b/include/linux/ext2_fs.h @@ -16,6 +16,7 @@ #ifndef _LINUX_EXT2_FS_H #define _LINUX_EXT2_FS_H +#include <linux/fs.h> #include <linux/types.h> #include <linux/magic.h> -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
As reported by Cezary Sliwa in https://bugzilla.kernel.org/show_bug.cgi?id=24282 ext2_fs.h references FS_DIRSYNC_FL etc, but does not include <linux/fs.h> to define them. This seems ok for kernelspace builds, but breaks userspace applications which include ext2_fs.h. Reported-by: Cezary Sliwa <sliwa@blue.cft.edu.pl> Signed-off-by: Eric Sandeen <sandeen@redhat.com> --- the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html