toplev.h includes cleanup

One consequence of my options changes is that toplev.h no longer has
such a large grab bag of miscellaneous declarations as it did before.
It is still essentially a grab bag of miscellaneous declarations (many
of which probably belong elsewhere), but a smaller one; diagnostics
are in diagnostic-core.h (and Manuel removed the diagnostic-core.h
include from toplev.h) and various flags and other variables related
to command-line options are now in the gcc_options structure (so
declared through the automatically generated options.h).

So it seems appropriate to remove toplev.h includes from files that
included it only for some declarations that are no longer there, which
this patch does for 148 files, more than half the total that included
this header (some files included toplev.h more than once; I didn't
check for any other duplicate includes).  In more detail:

* bversion.h has defines used only in diagnostic-core.h.  Thus the
  include of bversion.h from toplev.h belongs instead in
  diagnostic-core.h (I failed to spot this when creating
  diagnostic-core.h) and is now moved by this patch.

* Every file that includes toplev.h also includes input.h either
  directly or via another .h file that includes input.h directly or
  indirectly but not via toplev.h.  Thus no file depends on the
  include of input.h in toplev.h, which is removed by this patch.

* parse_optimize_options, declared by toplev.h, is a C-family function
  and is moved by this patch to c-common.h.

* Using grep I identified source files including toplev.h but not
  using any declaration from it, and removed the includes.  Testing
  showed the following cases where they needed restoring because of
  declarations being indirectly used via macros.

  - SET_DECL_OFFSET_ALIGN uses ffs_hwi, and is used by stor-layout.c
    which doesn't otherwise use anything from toplev.h.  (In my view
    the HOST_WIDE_INT functions in toplev.h belong in hwint.h - which
    is included everywhere via system.h - with the out-of-line
    fallback versions in a new hwint.c.)

  - All target $arch.c files need toplev.h for the declarations of the
    target hook functions default_get_pch_validity and
    default_pch_valid_p.  No targets actually have non-default
    versions of these hooks.  I'm not sure these really make sense as
    hooks - any hooks should operate at the level of the individual
    option rather than overriding the whole functions - but
    targhooks.h and targhooks.c would probably be better places for
    them as hooks.

  (It is of course possible that other cases might arise from target
  macros on targets not among those I tested, in which case more
  includes might need restoring with appropriate comments - or
  declarations moving, or macros converting to hooks.)

Bootstrapped with no regressions on x86_64-unknown-linux-gnu.  Also
tested building cc1 for crosses to: arm-wince-pe i686-darwin
i686-mingw32 i686-netware i686-solaris2.10 i686-wrs-vxworks
ia64-hp-hpux11.23 m32c-elf mep-elf microblaze-elf powerpc-eabi
score-elf sh-symbianelf v850-elf.  (sh-symbianelf fails for unrelated
reasons: sh/symbian-base.c, which is not modified, gets 'error:
attempt to use poisoned "GCC_RTL_H"'.)  OK to commit?

2010-11-29  Joseph Myers  <joseph@codesourcery.com>

	* diagnostic-core.h: Include bversion.h.
	* toplev.h: Don't include input.h or bversion.h.
	(parse_optimize_options): Don't declare here.
	* alias.c, auto-inc-dec.c, c-aux-info.c, c-convert.c, c-parser.c,
	caller-save.c, cfg.c, cfganal.c, cfgbuild.c, cfgcleanup.c,
	combine-stack-adj.c, config/arm/pe.c, config/darwin-c.c,
	config/host-darwin.c, config/i386/host-cygwin.c,
	config/i386/host-mingw32.c, config/i386/msformat-c.c,
	config/i386/netware.c, config/i386/nwld.c,
	config/i386/winnt-cxx.c, config/i386/winnt-stubs.c,
	config/ia64/ia64-c.c, config/m32c/m32c-pragma.c,
	config/mep/mep-pragma.c, config/microblaze/microblaze-c.c,
	config/rs6000/host-darwin.c, config/rs6000/rs6000-c.c,
	config/score/score3.c, config/score/score7.c,
	config/sh/symbian-base.c, config/sh/symbian-c.c,
	config/sh/symbian-cxx.c, config/sol2-c.c, config/sol2.c,
	config/v850/v850-c.c, config/vxworks.c, convert.c, cppbuiltin.c,
	cselib.c, dbgcnt.c, ddg.c, dfp.c, dominance.c, emit-rtl.c,
	fixed-value.c, fwprop.c, ggc-common.c, gimple.c, gimplify.c,
	graphite-blocking.c, graphite-clast-to-gimple.c,
	graphite-dependences.c, graphite-flattening.c,
	graphite-interchange.c, graphite-poly.c,
	graphite-scop-detection.c, graphite.c, haifa-sched.c,
	implicit-zee.c, integrate.c, ipa-pure-const.c, ipa-reference.c,
	ira-build.c, ira-conflicts.c, ira-costs.c, ira-lives.c, jump.c,
	lists.c, loop-doloop.c, loop-iv.c, lto-cgraph.c, lto-compress.c,
	lto-opts.c, lto-section-in.c, lto-section-out.c,
	lto-streamer-out.c, lto-symtab.c, modulo-sched.c, optabs.c,
	params.c, postreload-gcse.c, postreload.c, predict.c, profile.c,
	regcprop.c, reginfo.c, regmove.c, reorg.c, resource.c,
	sched-deps.c, sched-ebb.c, sched-rgn.c, sdbout.c,
	sel-sched-dump.c, sel-sched-ir.c, sese.c, stmt.c, targhooks.c,
	tree-cfgcleanup.c, tree-mudflap.c, tree-nomudflap.c,
	tree-object-size.c, tree-outof-ssa.c, tree-phinodes.c,
	tree-profile.c, tree-sra.c, tree-ssa-ccp.c, tree-ssa-coalesce.c,
	tree-ssa-live.c, tree-ssa-loop-prefetch.c, tree-ssa-loop.c,
	tree-ssa-operands.c, tree-ssa-structalias.c, tree-ssa-uninit.c,
	tree-vect-patterns.c, value-prof.c, var-tracking.c, web.c: Don't
	include toplev.h.
	* Makefile.in (TOPLEV_H): Remove.  All uses changed to use
	toplev.h.  Dependencies for above files and c-family files changed
	to remove $(TOPLEV_H) or toplev.h.
	(C_TREE_H): Don't include $(TOPLEV_H).
	(DIAGNOSTIC_CORE_H): Use $(INPUT_H) instead of input.h.  Add
	bversion.h.
	* config/arm/t-pe, config/arm/t-wince-pe, config/i386/t-cygming,
	config/ia64/t-ia64, config/mep/t-mep, config/score/t-score-elf,
	config/t-darwin, config/t-sol2,
	config/t-vxworks, config/v850/t-v850, config/v850/t-v850e:
	Dependencies for above files changed to remove $(TOPLEV_H) or
	toplev.h.

c-family:
2010-11-29  Joseph Myers  <joseph@codesourcery.com>

	* c-common.h (parse_optimize_options): Declare.
	* c-cppbuiltin.c, c-format.c, c-gimplify.c, c-lex.c, c-omp.c,
	c-pch.c, c-pragma.c, c-semantics.c: Don't include toplev.h.

cp:
2010-11-29  Joseph Myers  <joseph@codesourcery.com>

	* cp-gimplify.c, cp-lang.c, cvt.c, cxx-pretty-print.c, error.c,
	except.c, expr.c, friend.c, init.c, mangle.c, name-lookup.c,
	optimize.c, parser.c, rtti.c, tree.c, typeck2.c: Don't include
	toplev.h.
	* Make-lang.in: Dependencies for above files changed to remove
	toplev.h.

java:
2010-11-29  Joseph Myers  <joseph@codesourcery.com>

	* expr.c, lang.c, mangle.c, mangle_name.c, typeck.c,
	verify-glue.c: Don't include toplev.h.
	* Make-lang.in: Dependencies for above files changed to remove
	toplev.h.

lto:
2010-11-29  Joseph Myers  <joseph@codesourcery.com>

	* Make-lang.in (lto/lto-object.o): Depend on toplev.h instead of
	$(TOPLEV_H).

toplev.h includes cleanup

Commit Message

Comments

Patch