| Message ID | 1498681836-3765-4-git-send-email-andrea.adami@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
Please use the $SUBJECT line expected by the subsystem. `git log --oneline -- $SUBSYSTEM` can help with this. You also need a commit log. > Signed-off-by: Andrea Adami <andrea.adami@gmail.com> > --- > include/linux/mfd/tmio.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/mfd/tmio.h b/include/linux/mfd/tmio.h > index a1520d8..23bb069 100644 > --- a/include/linux/mfd/tmio.h > +++ b/include/linux/mfd/tmio.h > @@ -139,6 +139,7 @@ struct tmio_nand_data { > struct nand_bbt_descr *badblock_pattern; > struct mtd_partition *partition; > unsigned int num_partitions; > + const char *const *types; /* names of parsers to use if any */ I'm okay with this if it's suits the MTD folk. > }; > > #define FBIO_TMIO_ACC_WRITE 0x7C639300
On Mon, Jul 3, 2017 at 1:26 PM, Lee Jones <lee.jones@linaro.org> wrote: > Please use the $SUBJECT line expected by the subsystem. > > `git log --oneline -- $SUBSYSTEM` can help with this. > > You also need a commit log. > Lee, thanks for spotting it. I'll fix the subject and add a little text in these patches touching headers. I am awaiting for a new review of the big piece of the patch, the ftl/parser, then I'll send a fixed v5. >> Signed-off-by: Andrea Adami <andrea.adami@gmail.com> >> --- >> include/linux/mfd/tmio.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/include/linux/mfd/tmio.h b/include/linux/mfd/tmio.h >> index a1520d8..23bb069 100644 >> --- a/include/linux/mfd/tmio.h >> +++ b/include/linux/mfd/tmio.h >> @@ -139,6 +139,7 @@ struct tmio_nand_data { >> struct nand_bbt_descr *badblock_pattern; >> struct mtd_partition *partition; >> unsigned int num_partitions; >> + const char *const *types; /* names of parsers to use if any */ > > I'm okay with this if it's suits the MTD folk. > Other than kerneldoc comments there are maybe other little discordances to settle: see above is *partition, num_partitions. In the other header it is *partitions, nr_partitions ...I'll see if oneday I can janiitor this. Regards Andrea >> }; >> >> #define FBIO_TMIO_ACC_WRITE 0x7C639300 > > -- > Lee Jones > Linaro STMicroelectronics Landing Team Lead > Linaro.org │ Open source software for ARM SoCs > Follow Linaro: Facebook | Twitter | Blog
On Mon, Jul 3, 2017 at 2:03 PM, Andrea Adami <andrea.adami@gmail.com> wrote: > On Mon, Jul 3, 2017 at 1:26 PM, Lee Jones <lee.jones@linaro.org> wrote: >> Please use the $SUBJECT line expected by the subsystem. >> >> `git log --oneline -- $SUBSYSTEM` can help with this. >> >> You also need a commit log. >> > > Lee, > > thanks for spotting it. > I'll fix the subject and add a little text in these patches touching headers. > > I am awaiting for a new review of the big piece of the patch, the > ftl/parser, then I'll send a fixed v5. > > Lee, I have looked at the history of mfd/tmio.h but couldn't find unambiguous examples. Do you prefer Subject: mfd: tmio: tmio_nand: add partition parsers platform data or Subject: mfd: tmio: tmio-nand: add partition parsers platform data or Subject: mfd: tmio: tmio/nand: add partition parsers platform data Thanks Andrea >>> Signed-off-by: Andrea Adami <andrea.adami@gmail.com> >>> --- >>> include/linux/mfd/tmio.h | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/include/linux/mfd/tmio.h b/include/linux/mfd/tmio.h >>> index a1520d8..23bb069 100644 >>> --- a/include/linux/mfd/tmio.h >>> +++ b/include/linux/mfd/tmio.h >>> @@ -139,6 +139,7 @@ struct tmio_nand_data { >>> struct nand_bbt_descr *badblock_pattern; >>> struct mtd_partition *partition; >>> unsigned int num_partitions; >>> + const char *const *types; /* names of parsers to use if any */ >> >> I'm okay with this if it's suits the MTD folk. >> > > Other than kerneldoc comments there are maybe other little > discordances to settle: see above is *partition, num_partitions. > In the other header it is *partitions, nr_partitions ...I'll see if > oneday I can janiitor this. > > Regards > Andrea > >>> }; >>> >>> #define FBIO_TMIO_ACC_WRITE 0x7C639300 >> >> -- >> Lee Jones >> Linaro STMicroelectronics Landing Team Lead >> Linaro.org │ Open source software for ARM SoCs >> Follow Linaro: Facebook | Twitter | Blog
On Wed, 12 Jul 2017, Andrea Adami wrote: > On Mon, Jul 3, 2017 at 2:03 PM, Andrea Adami <andrea.adami@gmail.com> wrote: > > On Mon, Jul 3, 2017 at 1:26 PM, Lee Jones <lee.jones@linaro.org> wrote: > >> Please use the $SUBJECT line expected by the subsystem. > >> > >> `git log --oneline -- $SUBSYSTEM` can help with this. > >> > >> You also need a commit log. > >> > > > > Lee, > > > > thanks for spotting it. > > I'll fix the subject and add a little text in these patches touching headers. > > > > I am awaiting for a new review of the big piece of the patch, the > > ftl/parser, then I'll send a fixed v5. > > > > > > Lee, > > I have looked at the history of mfd/tmio.h but couldn't find > unambiguous examples. > Do you prefer > > Subject: mfd: tmio: tmio_nand: add partition parsers platform data > or > Subject: mfd: tmio: tmio-nand: add partition parsers platform data > or > Subject: mfd: tmio: tmio/nand: add partition parsers platform data Better to look at the subsystem as a whole. `git log --oneline -- drivers/mfd` You will see something like: mfd: device-driver: Short subject starting with an uppercase char > >>> Signed-off-by: Andrea Adami <andrea.adami@gmail.com> > >>> --- > >>> include/linux/mfd/tmio.h | 1 + > >>> 1 file changed, 1 insertion(+) > >>> > >>> diff --git a/include/linux/mfd/tmio.h b/include/linux/mfd/tmio.h > >>> index a1520d8..23bb069 100644 > >>> --- a/include/linux/mfd/tmio.h > >>> +++ b/include/linux/mfd/tmio.h > >>> @@ -139,6 +139,7 @@ struct tmio_nand_data { > >>> struct nand_bbt_descr *badblock_pattern; > >>> struct mtd_partition *partition; > >>> unsigned int num_partitions; > >>> + const char *const *types; /* names of parsers to use if any */ > >> > >> I'm okay with this if it's suits the MTD folk. > >> > > > > Other than kerneldoc comments there are maybe other little > > discordances to settle: see above is *partition, num_partitions. > > In the other header it is *partitions, nr_partitions ...I'll see if > > oneday I can janiitor this. > > > > Regards > > Andrea > > > >>> }; > >>> > >>> #define FBIO_TMIO_ACC_WRITE 0x7C639300 > >>
diff --git a/include/linux/mfd/tmio.h b/include/linux/mfd/tmio.h index a1520d8..23bb069 100644 --- a/include/linux/mfd/tmio.h +++ b/include/linux/mfd/tmio.h @@ -139,6 +139,7 @@ struct tmio_nand_data { struct nand_bbt_descr *badblock_pattern; struct mtd_partition *partition; unsigned int num_partitions; + const char *const *types; /* names of parsers to use if any */ }; #define FBIO_TMIO_ACC_WRITE 0x7C639300
Signed-off-by: Andrea Adami <andrea.adami@gmail.com> --- include/linux/mfd/tmio.h | 1 + 1 file changed, 1 insertion(+)