Message ID | 1289331475.2774.41.camel@edumazet-laptop |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
From: Eric Dumazet <eric.dumazet@gmail.com> Date: Tue, 09 Nov 2010 20:37:55 +0100 > [PATCH] net/dst: dst_dev_event() called after other notifiers Nice, applied. However, I had to apply this by hand: > static struct notifier_block dst_dev_notifier = { > .notifier_call = dst_dev_event, > + .priority = -10, /* must be called after other network notifiers */ > }; The character after ".notifier_call" in my tree is a TAB character but in your patch it is a sequence of spaces. This isn't looking like the usual email corruption, because the leading TAB characters on these lines are properly there. Please figure out why this happened so that it doesn't repeat in future patches :-) Thanks! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 11/09/2010 11:48 AM, David Miller wrote: > From: Eric Dumazet<eric.dumazet@gmail.com> > Date: Tue, 09 Nov 2010 20:37:55 +0100 > >> [PATCH] net/dst: dst_dev_event() called after other notifiers > > Nice, applied. > > However, I had to apply this by hand: > >> static struct notifier_block dst_dev_notifier = { >> .notifier_call = dst_dev_event, >> + .priority = -10, /* must be called after other network notifiers */ >> }; > > The character after ".notifier_call" in my tree is a TAB character but > in your patch it is a sequence of spaces. This isn't looking like the > usual email corruption, because the leading TAB characters on these > lines are properly there. > > Please figure out why this happened so that it doesn't repeat in > future patches :-) I manually applied this as well and can confirm that interface deletion with a global IPv6 address on it is now comparable to any other device delete (about 30ms). Tested-by: Ben Greear <greearb@candelatech.com> I'd love to test patches that made all interface deletes faster, btw :) Thanks, Ben
Le mardi 09 novembre 2010 à 11:48 -0800, David Miller a écrit : > From: Eric Dumazet <eric.dumazet@gmail.com> > Date: Tue, 09 Nov 2010 20:37:55 +0100 > > > [PATCH] net/dst: dst_dev_event() called after other notifiers > > Nice, applied. > > However, I had to apply this by hand: > > > static struct notifier_block dst_dev_notifier = { > > .notifier_call = dst_dev_event, > > + .priority = -10, /* must be called after other network notifiers */ > > }; > > The character after ".notifier_call" in my tree is a TAB character but > in your patch it is a sequence of spaces. This isn't looking like the > usual email corruption, because the leading TAB characters on these > lines are properly there. > > Please figure out why this happened so that it doesn't repeat in > future patches :-) > I am very sorry David, I had to run yesterday night and did a stupid hand editing right before doing so. It was a human error, not a tool error. Next time, I'll delay the patch to next day :) Thanks ! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/core/dst.c b/net/core/dst.c index 8abe628..e234bf1 100644 --- a/net/core/dst.c +++ b/net/core/dst.c @@ -370,6 +370,7 @@ static int dst_dev_event(struct notifier_block *this, unsigned long event, static struct notifier_block dst_dev_notifier = { .notifier_call = dst_dev_event, + .priority = -10, /* must be called after other network notifiers */ }; void __init dst_init(void)