| Message ID | 20170530111332.3829080-1-arnd@arndb.de |
|---|---|
| State | New |
| Headers | show |
> -----Original Message----- > From: Arnd Bergmann [mailto:arnd@arndb.de] > Sent: 30 May 2017 14:13 > To: Linus Walleij <linus.walleij@linaro.org> > Cc: Han, Nandor (GE Healthcare) <nandor.han@ge.com>; Arnd Bergmann <arnd@arndb.de>; linux-gpio@vger.kernel.org; > linux-kernel@vger.kernel.org > Subject: EXT: [PATCH] gpio: xra1403: select REGMAP_SPI > > Without the regmap code, we get a link error: > > drivers/gpio/built-in.o: In function `xra1403_probe': > (.text+0x132e0): undefined reference to `__devm_regmap_init_spi' > > Fixes: 5704520d7880 ("gpio: xra1403: Add EXAR XRA1403 SPI GPIO expander driver") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Nandor Han <nandor.han@ge.com> > --- > drivers/gpio/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig > index 66d1f353ca73..238fc231081a 100644 > --- a/drivers/gpio/Kconfig > +++ b/drivers/gpio/Kconfig > @@ -1241,6 +1241,7 @@ config GPIO_PISOSR > > config GPIO_XRA1403 > tristate "EXAR XRA1403 16-bit GPIO expander" > + select REGMAP_SPI > help > GPIO driver for EXAR XRA1403 16-bit SPI-based GPIO expander. > > -- > 2.9.0 -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, May 30, 2017 at 1:13 PM, Arnd Bergmann <arnd@arndb.de> wrote: > Without the regmap code, we get a link error: > > drivers/gpio/built-in.o: In function `xra1403_probe': > (.text+0x132e0): undefined reference to `__devm_regmap_init_spi' > > Fixes: 5704520d7880 ("gpio: xra1403: Add EXAR XRA1403 SPI GPIO expander driver") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index 66d1f353ca73..238fc231081a 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -1241,6 +1241,7 @@ config GPIO_PISOSR config GPIO_XRA1403 tristate "EXAR XRA1403 16-bit GPIO expander" + select REGMAP_SPI help GPIO driver for EXAR XRA1403 16-bit SPI-based GPIO expander.
Without the regmap code, we get a link error: drivers/gpio/built-in.o: In function `xra1403_probe': (.text+0x132e0): undefined reference to `__devm_regmap_init_spi' Fixes: 5704520d7880 ("gpio: xra1403: Add EXAR XRA1403 SPI GPIO expander driver") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/gpio/Kconfig | 1 + 1 file changed, 1 insertion(+)