@@ -502,6 +502,19 @@ cp_lexer_token_at (cp_lexer *lexer ATTRIBUTE_UNUSED, cp_token_position pos)
return pos;
}
+static inline cp_token *
+cp_lexer_previous_token (cp_lexer *lexer)
+{
+ cp_token_position tp;
+
+ if (lexer->next_token == &eof_token)
+ tp = lexer->last_token - 1;
+ else
+ tp = cp_lexer_token_position (lexer, true);
+
+ return cp_lexer_token_at (lexer, tp);
+}
+
/* nonzero if we are presently saving tokens. */
static inline int
@@ -2273,21 +2286,22 @@ cp_parser_is_keyword (cp_token* token, enum rid keyword)
return token->keyword == keyword;
}
-/* If not parsing tentatively, issue a diagnostic of the form
- FILE:LINE: MESSAGE before TOKEN
- where TOKEN is the next token in the input stream. MESSAGE
+/* If not parsing tenatively, issue a diagnostic of the form
+ FILE:LINE: GMSGID before TOKEN
+ where TOKEN is the next token in the input stream. GMSGID
(specified by the caller) is usually of the form "expected
- OTHER-TOKEN". */
+ OTHER-TOKEN". LOC_TOKEN is a token from which the source
+ position of the lexer should be set. */
static void
-cp_parser_error (cp_parser* parser, const char* gmsgid)
+cp_parser_error_at_token (cp_parser* parser, const char* gmsgid,
+ cp_token* loc_token)
{
if (!cp_parser_simulate_error (parser))
{
cp_token *token = cp_lexer_peek_token (parser->lexer);
- /* This diagnostic makes more sense if it is tagged to the line
- of the token we just peeked at. */
- cp_lexer_set_source_position_from_token (token);
+
+ cp_lexer_set_source_position_from_token (loc_token);
if (token->type == CPP_PRAGMA)
{
@@ -2306,6 +2320,23 @@ cp_parser_error (cp_parser* parser, const char* gmsgid)
}
}
+/* If not parsing tentatively, issue a diagnostic of the form
+ FILE:LINE: MESSAGE before TOKEN
+ where TOKEN is the next token in the input stream. MESSAGE
+ (specified by the caller) is usually of the form "expected
+ OTHER-TOKEN". */
+
+static void
+cp_parser_error (cp_parser* parser, const char* gmsgid)
+{
+ if (!cp_parser_simulate_error (parser))
+ {
+ cp_token *token = cp_lexer_peek_token (parser->lexer);
+
+ cp_parser_error_at_token (parser, gmsgid, token);
+ }
+}
+
/* Issue an error about name-lookup failing. NAME is the
IDENTIFIER_NODE DECL is the result of
the lookup (as returned from cp_parser_lookup_name). DESIRED is
@@ -17627,6 +17658,8 @@ cp_parser_member_declaration (cp_parser* parser)
}
else
{
+ bool assume_semicolon = false;
+
/* See if these declarations will be friends. */
friend_p = cp_parser_friend_p (&decl_specifiers);
@@ -17820,11 +17853,18 @@ cp_parser_member_declaration (cp_parser* parser)
else if (cp_lexer_next_token_is_not (parser->lexer,
CPP_SEMICOLON))
{
- cp_parser_error (parser, "expected %<;%>");
- /* Skip tokens until we find a `;'. */
- cp_parser_skip_to_end_of_statement (parser);
+ /* The next token might be a ways away from where the
+ actual semicolon is missing. Find the previous token
+ and use that for our error position. */
+ cp_token *token = cp_lexer_previous_token (parser->lexer);
+ error_at (token->location,
+ "expected %<;%> at end of member declaration");
- break;
+ /* Assume that the user meant to provide a semicolon. If
+ we were to cp_parser_skip_to_end_of_statement, we might
+ skip to a semicolon inside a member function definition
+ and issue nonsensical error messages. */
+ assume_semicolon = true;
}
if (decl)
@@ -17836,6 +17876,9 @@ cp_parser_member_declaration (cp_parser* parser)
if (TREE_CODE (decl) == FUNCTION_DECL)
cp_parser_save_default_args (parser, decl);
}
+
+ if (assume_semicolon)
+ return;
}
}
@@ -3,6 +3,6 @@
struct A
{
- int i __asm__(int); // { dg-error "before" }
- static int j __asm__(int); // { dg-error "before" }
+ int i __asm__(int); // { dg-error "expected" }
+ static int j __asm__(int); // { dg-error "expected" }
};
@@ -5,7 +5,7 @@
struct A
{
- void* operator new(__SIZE_TYPE__) throw(X); // { dg-error "" }
+ void* operator new(__SIZE_TYPE__) throw(X); // { dg-error "expected|type" }
};
-A* p = new A; // { dg-error "no suitable" }
+A* p = new A;
@@ -2,9 +2,9 @@
struct A
{
- int i;
- A() i() {} // { dg-error "expected" }
-}; // { dg-error "expected" }
+ int i; // { dg-error "conflicts" }
+ A() i() {} // { dg-error "declaration" }
+};
struct B
{
new file mode 100644
@@ -0,0 +1,9 @@
+// PR c++/45332
+// { dg-do compile }
+
+class C
+{
+ int x // { dg-error "expected" }
+
+ const int foo() { return x; }
+};