Message ID | 1477751795-20128-3-git-send-email-hegdevasant@linux.vnet.ibm.com |
---|---|
State | Accepted |
Headers | show |
Vasant Hegde <hegdevasant@linux.vnet.ibm.com> writes: > Host services ntuple is deprecated on P9. > > Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> > --- > hdata/spira.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/hdata/spira.c b/hdata/spira.c > index 592197e..59ffc1d 100644 > --- a/hdata/spira.c > +++ b/hdata/spira.c > @@ -1023,6 +1023,10 @@ static void hostservices_parse(void) > unsigned int size; > unsigned int ntuples_size; > > + /* Deprecated on P9 */ > + if (proc_gen >= proc_gen_p9) > + return; > + I'd prefer we print an error rather than failing silently.
On Tue, Dec 20, 2016 at 2:34 PM, Stewart Smith <stewart@linux.vnet.ibm.com> wrote: > Vasant Hegde <hegdevasant@linux.vnet.ibm.com> writes: >> Host services ntuple is deprecated on P9. >> >> Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> >> --- >> hdata/spira.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/hdata/spira.c b/hdata/spira.c >> index 592197e..59ffc1d 100644 >> --- a/hdata/spira.c >> +++ b/hdata/spira.c >> @@ -1023,6 +1023,10 @@ static void hostservices_parse(void) >> unsigned int size; >> unsigned int ntuples_size; >> >> + /* Deprecated on P9 */ >> + if (proc_gen >= proc_gen_p9) >> + return; >> + > > I'd prefer we print an error rather than failing silently. Why? Ignoring a deprecated tuple is perfectly fine and the FSP/HB sometimes populate the fields anyway. > > -- > Stewart Smith > OPAL Architect, IBM. >
Oliver O'Halloran <oohall@gmail.com> writes: > On Tue, Dec 20, 2016 at 2:34 PM, Stewart Smith > <stewart@linux.vnet.ibm.com> wrote: >> Vasant Hegde <hegdevasant@linux.vnet.ibm.com> writes: >>> Host services ntuple is deprecated on P9. >>> >>> Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> >>> --- >>> hdata/spira.c | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/hdata/spira.c b/hdata/spira.c >>> index 592197e..59ffc1d 100644 >>> --- a/hdata/spira.c >>> +++ b/hdata/spira.c >>> @@ -1023,6 +1023,10 @@ static void hostservices_parse(void) >>> unsigned int size; >>> unsigned int ntuples_size; >>> >>> + /* Deprecated on P9 */ >>> + if (proc_gen >= proc_gen_p9) >>> + return; >>> + >> >> I'd prefer we print an error rather than failing silently. > > Why? Ignoring a deprecated tuple is perfectly fine and the FSP/HB > sometimes populate the fields anyway. Ahhh, reality interferes - then I'm okay with no error/warning.
Vasant Hegde <hegdevasant@linux.vnet.ibm.com> writes: > Host services ntuple is deprecated on P9. > > Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> > --- > hdata/spira.c | 4 ++++ > 1 file changed, 4 insertions(+) Merged to master as of d32b462b313273f5a2a4c7257ea05d86e6331925
diff --git a/hdata/spira.c b/hdata/spira.c index 592197e..59ffc1d 100644 --- a/hdata/spira.c +++ b/hdata/spira.c @@ -1023,6 +1023,10 @@ static void hostservices_parse(void) unsigned int size; unsigned int ntuples_size; + /* Deprecated on P9 */ + if (proc_gen >= proc_gen_p9) + return; + ntuples_size = sizeof(struct HDIF_array_hdr) + be32_to_cpu(spira.ntuples.array_hdr.ecnt) * sizeof(struct spira_ntuple);
Host services ntuple is deprecated on P9. Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> --- hdata/spira.c | 4 ++++ 1 file changed, 4 insertions(+)