| Message ID | 4C73D99C.5050205@users.sourceforge.net |
|---|---|
| State | New |
| Headers | show |
On Tue, 24 Aug 2010, JonY wrote: > Hi, > > Attached patch enables i?86-w64-mingw32 and x86_64-w64-mingw32 decimal float > support with bid. My previous comments about the several places to keep in sync <http://gcc.gnu.org/ml/gcc-patches/2010-02/msg00933.html> apply equally to this patch (see also followups to the previous comments).
2010/8/24 JonY <jon_y@users.sourceforge.net>: > Hi, > > Attached patch enables i?86-w64-mingw32 and x86_64-w64-mingw32 decimal float > support with bid. > > Tested with x86_64-w64-mingw32. Is attached patch OK for trunk? > > > > 2010-08-24 Jonathan Yong <jon_y@users.sourceforge.net> > > * configure.ac: Allow w64 targets to use bid decimal floats. > * configure: Regenerated. > > Patch is from my side ok. I added Dave to CC. Maybe he wants that it gets added for cygwin, too? I tried to find out more detail about the specification MS used for the #C implementation of __decimal128, but sadly I didn't got any reply here. Some users were asking us some time ago, if we couldn't enable decimal float support for mingw-w64. So I assume it is up to us to decided, which standard to follow here, and bid is ok. Kai
On 24/08/2010 16:06, Kai Tietz wrote: > 2010/8/24 JonY <jon_y@users.sourceforge.net>: >> Hi, >> >> Attached patch enables i?86-w64-mingw32 and x86_64-w64-mingw32 decimal float >> support with bid. >> >> Tested with x86_64-w64-mingw32. Is attached patch OK for trunk? >> >> >> >> 2010-08-24 Jonathan Yong <jon_y@users.sourceforge.net> >> >> * configure.ac: Allow w64 targets to use bid decimal floats. >> * configure: Regenerated. >> >> > > Patch is from my side ok. I added Dave to CC. Maybe he wants that it > gets added for cygwin, too? I'm currently testing a build that I did with Uros' patch and manually configuring with '--enable-decimal-float' and it seems to be going pretty well, so yes please Jon, if you don't mind spinning another respin. BTW, re Ralf's earlier point: for preference please actually /omit/ the diffs of the generated configure files altogether, we only need to see the change to the .ac file, because autoconf is very deterministic, and the actual configure file diffs often contain tons of uninformative noise from the expansions of all the macros and the changes in error line number reporting(*). cheers, DaveK
Index: gcc/configure.ac =================================================================== --- gcc/configure.ac (revision 163517) +++ gcc/configure.ac (working copy) @@ -620,7 +620,7 @@ ], [ case $target in - powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux*) + powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux* | i?86*-w64-mingw* | x86_64*-w64-mingw*) enable_decimal_float=yes ;; *) @@ -638,7 +638,7 @@ case x$enable_decimal_float in xyes) case $target in - i?86*-*-linux* | x86_64*-*-linux*) + i?86*-*-linux* | x86_64*-*-linux* | i?86*-w64-mingw* | x86_64*-w64-mingw*) enable_decimal_float=bid ;; *) Index: gcc/configure =================================================================== --- gcc/configure (revision 163517) +++ gcc/configure (working copy) @@ -6661,7 +6661,7 @@ else case $target in - powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux*) + powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux* | i?86*-w64-mingw* | x86_64*-w64-mingw*) enable_decimal_float=yes ;; *) @@ -6685,7 +6685,7 @@ case x$enable_decimal_float in xyes) case $target in - i?86*-*-linux* | x86_64*-*-linux*) + i?86*-*-linux* | x86_64*-*-linux* | i?86*-w64-mingw* | x86_64*-w64-mingw*) enable_decimal_float=bid ;; *)