Message ID | CABV8kRzPpdhRsWOsU+zNEc7AcAqTqm1xdWxM0rufGAjk=yn4TA@mail.gmail.com |
---|---|
State | New |
Headers | show |
Keno Fischer <keno@juliacomputing.com> writes: > diff --git a/sysdeps/x86_64/dl-machine.h b/sysdeps/x86_64/dl-machine.h > index ed0c1a8..7a246d4 100644 > --- a/sysdeps/x86_64/dl-machine.h > +++ b/sysdeps/x86_64/dl-machine.h > @@ -141,10 +141,15 @@ elf_machine_runtime_setup (struct link_map *l, > int lazy, int profile) > .align 16\n\ > .globl _start\n\ > .globl _dl_start_user\n\ > -_start:\n\ > +_start:\n"\ > +CFI_STARTPROC "\n"\ > +CFI_UNDEFINED(%rip) "\n\ No need for backslash continuation outside of the string literals. Andreas.
I should have probably sent this patch with more diff context, but since this is part of a preprocessor `#define`, the backslashes are still required, no?
Keno Fischer <keno@juliacomputing.com> writes: > I should have probably sent this patch with more diff context, but > since this is part of a preprocessor `#define`, the backslashes are > still required, no? Yes, sorry, I missed that. But please put a space before the backslashes outside of the string literals. Andreas.
Might it make sense to change the macro to clearly separate the string literals and the backslashes, i.e. ".globl _start\n" \ ".globl _dl_start_user\n" \ "_start:\n" \ etc.? On Mon, Jul 4, 2016 at 3:37 PM, Andreas Schwab <schwab@linux-m68k.org> wrote: > Keno Fischer <keno@juliacomputing.com> writes: > >> I should have probably sent this patch with more diff context, but >> since this is part of a preprocessor `#define`, the backslashes are >> still required, no? > > Yes, sorry, I missed that. But please put a space before the > backslashes outside of the string literals. > > Andreas. > > -- > Andreas Schwab, schwab@linux-m68k.org > GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 > "And now for something completely different."
Hello again. I'd be happy to change this patch in whatever way you deem best. Could you suggest what you would like me to do? Thanks, Keno
Bump again, I would like to make sure this doesn't get lost. Please let me know how I should proceed. On Mon, Aug 1, 2016 at 11:21 PM, Keno Fischer <keno@juliacomputing.com> wrote: > Hello again. I'd be happy to change this patch in whatever way you > deem best. Could you suggest what you would like me to do? > > Thanks, > Keno
Bump. Please let me know the stylistic preferences for the assembly code as well as any other comments on the patch. On Thu, Aug 11, 2016 at 3:38 PM, Keno Fischer <keno@juliacomputing.com> wrote: > Bump again, I would like to make sure this doesn't get lost. > Please let me know how I should proceed. > > On Mon, Aug 1, 2016 at 11:21 PM, Keno Fischer <keno@juliacomputing.com> wrote: >> Hello again. I'd be happy to change this patch in whatever way you >> deem best. Could you suggest what you would like me to do? >> >> Thanks, >> Keno
On Tue, Nov 1, 2016 at 1:48 PM, Keno Fischer <keno@juliacomputing.com> wrote: > Bump. Please let me know the stylistic preferences for the assembly > code as well as any other comments > on the patch. > > On Thu, Aug 11, 2016 at 3:38 PM, Keno Fischer <keno@juliacomputing.com> wrote: >> Bump again, I would like to make sure this doesn't get lost. >> Please let me know how I should proceed. >> >> On Mon, Aug 1, 2016 at 11:21 PM, Keno Fischer <keno@juliacomputing.com> wrote: >>> Hello again. I'd be happy to change this patch in whatever way you >>> deem best. Could you suggest what you would like me to do? >>> >>> Thanks, >>> Keno It looks good to me.
Thanks for taking a look H.J. What's the next step? Can somebody commit this (or the reformatted version I sent as v2)? I'd also be happy to do another revision, if there are any further review comments - just want to make sure this doesn't get forgotten. Thanks, Keno
diff --git a/sysdeps/x86_64/dl-machine.h b/sysdeps/x86_64/dl-machine.h index ed0c1a8..7a246d4 100644 --- a/sysdeps/x86_64/dl-machine.h +++ b/sysdeps/x86_64/dl-machine.h @@ -141,10 +141,15 @@ elf_machine_runtime_setup (struct link_map *l, int lazy, int profile) .align 16\n\ .globl _start\n\ .globl _dl_start_user\n\ -_start:\n\ +_start:\n"\ +CFI_STARTPROC "\n"\ +CFI_UNDEFINED(%rip) "\n\ movq %rsp, %rdi\n\ - call _dl_start\n\ -_dl_start_user:\n\ + call _dl_start\n"\ +CFI_ENDPROC "\n\ +_dl_start_user:\n"\ +CFI_STARTPROC "\n"\ +CFI_UNDEFINED(%rip) "\n\ # Save the user entry point address in %r12.\n\ movq %rax, %r12\n\