Message ID | Pine.LNX.4.64.0810271821340.7072@wrl-59.cs.helsinki.fi |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
Hi Ilpo, >> 2) Couple places trying to pass sk_buff to kfree() instead of >> kfree_skb(). Fixed by Sergio Luis > > I tried with coccinelle and found one more of these, though my > other attempts with it haven't been all that successful... > > > -- > [PATCH] bpa10x: free sk_buff with kfree_skb > > Inspired by Sergio Luis' similar patches, I finally found > a case which is trivial enough that spatch won't choke > on it. > > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi> good catch. Acked-by: Marcel Holtmann <marcel@holtmann.org> Dave, feel free to take this directly and apply it to your trees. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Marcel Holtmann <marcel@holtmann.org> Date: Thu, 30 Oct 2008 05:09:34 +0100 > Hi Ilpo, > > >> 2) Couple places trying to pass sk_buff to kfree() instead of > >> kfree_skb(). Fixed by Sergio Luis > > > > I tried with coccinelle and found one more of these, though my > > other attempts with it haven't been all that successful... > > > > > > -- > > [PATCH] bpa10x: free sk_buff with kfree_skb > > > > Inspired by Sergio Luis' similar patches, I finally found > > a case which is trivial enough that spatch won't choke > > on it. > > > > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi> > > good catch. > > Acked-by: Marcel Holtmann <marcel@holtmann.org> > > Dave, feel free to take this directly and apply it to your trees. Thanks, I will. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/bluetooth/bpa10x.c b/drivers/bluetooth/bpa10x.c index 32f3a8e..b936d8c 100644 --- a/drivers/bluetooth/bpa10x.c +++ b/drivers/bluetooth/bpa10x.c @@ -443,8 +443,8 @@ static void bpa10x_destruct(struct hci_dev *hdev) BT_DBG("%s", hdev->name); - kfree(data->rx_skb[0]); - kfree(data->rx_skb[1]); + kfree_skb(data->rx_skb[0]); + kfree_skb(data->rx_skb[1]); kfree(data); }