Message ID | C7B2EF24-D619-4667-8B0D-925934EADE98@sandoe-acoustics.co.uk |
---|---|
State | New |
Headers | show |
On Jul 11, 2010, at 12:02 PM, IainS wrote: > This has been hanging around my local tree for a couple of months.. > .. and Jack and I realized that it hadn't been approved when we were considering making the (approved) back-port of the plug-in enabler to 4.5. > > In Janis' absence would one of the global reviewers please take a look? The important issues are the spelling, and that looks good to me, and the ordering... having this last should be very safe. I'd normally just check this in as obvious as it makes testing a new feature better on all systems that don't have an installed intl.h.
On 11 Jul 2010, at 21:11, Mike Stump wrote: > On Jul 11, 2010, at 12:02 PM, IainS wrote: >> This has been hanging around my local tree for a couple of months.. >> .. and Jack and I realized that it hadn't been approved when we >> were considering making the (approved) back-port of the plug-in >> enabler to 4.5. >> >> In Janis' absence would one of the global reviewers please take a >> look? > > The important issues are the spelling, and that looks good to me, > and the ordering... having this last should be very safe. I'd > normally just check this in as obvious as it makes testing a new > feature better on all systems that don't have an installed intl.h. checked in as, r162259 Iain
Index: gcc/testsuite/lib/plugin-support.exp =================================================================== --- gcc/testsuite/lib/plugin-support.exp (revision 162059) +++ gcc/testsuite/lib/plugin-support.exp (working copy) @@ -84,7 +84,7 @@ proc plugin-test-execute { plugin_src plugin_tests set gcc_objdir "$objdir/../../.." set includes "-I. -I${srcdir} -I${gcc_srcdir}/gcc -I$ {gcc_objdir}/gcc \ -I${gcc_srcdir}/include -I${gcc_srcdir}/libcpp/ include \ - $GMPINC" + $GMPINC -I${gcc_objdir}/intl "